From: Tejun Heo <tj@kernel.org> To: Gavin Shan <shangw@linux.vnet.ibm.com> Cc: Sasha Levin <levinsasha928@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, David Miller <davem@davemloft.net>, hpa@linux.intel.com, linux-mm <linux-mm@kvack.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: Early boot panic on machine with lots of memory Date: Thu, 21 Jun 2012 13:19:35 -0700 [thread overview] Message-ID: <20120621201935.GC4642@google.com> (raw) In-Reply-To: <20120619212059.GJ32733@google.com> Hello, Sasha, can you please apply the following patch and verify that the issue is gone? Thanks. diff --git a/mm/nobootmem.c b/mm/nobootmem.c index d23415c..4aa5e5d 100644 --- a/mm/nobootmem.c +++ b/mm/nobootmem.c @@ -111,9 +111,6 @@ unsigned long __init free_low_memory_core_early(int nodeid) phys_addr_t start, end; u64 i; - /* free reserved array temporarily so that it's treated as free area */ - memblock_free_reserved_regions(); - for_each_free_mem_range(i, MAX_NUMNODES, &start, &end, NULL) { unsigned long start_pfn = PFN_UP(start); unsigned long end_pfn = min_t(unsigned long, @@ -124,8 +121,6 @@ unsigned long __init free_low_memory_core_early(int nodeid) } } - /* put region array back? */ - memblock_reserve_reserved_regions(); return count; }
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org> To: Gavin Shan <shangw@linux.vnet.ibm.com> Cc: Sasha Levin <levinsasha928@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, David Miller <davem@davemloft.net>, hpa@linux.intel.com, linux-mm <linux-mm@kvack.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: Early boot panic on machine with lots of memory Date: Thu, 21 Jun 2012 13:19:35 -0700 [thread overview] Message-ID: <20120621201935.GC4642@google.com> (raw) In-Reply-To: <20120619212059.GJ32733@google.com> Hello, Sasha, can you please apply the following patch and verify that the issue is gone? Thanks. diff --git a/mm/nobootmem.c b/mm/nobootmem.c index d23415c..4aa5e5d 100644 --- a/mm/nobootmem.c +++ b/mm/nobootmem.c @@ -111,9 +111,6 @@ unsigned long __init free_low_memory_core_early(int nodeid) phys_addr_t start, end; u64 i; - /* free reserved array temporarily so that it's treated as free area */ - memblock_free_reserved_regions(); - for_each_free_mem_range(i, MAX_NUMNODES, &start, &end, NULL) { unsigned long start_pfn = PFN_UP(start); unsigned long end_pfn = min_t(unsigned long, @@ -124,8 +121,6 @@ unsigned long __init free_low_memory_core_early(int nodeid) } } - /* put region array back? */ - memblock_reserve_reserved_regions(); return count; } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-21 20:19 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-13 21:38 Early boot panic on machine with lots of memory Sasha Levin 2012-06-14 3:20 ` Tejun Heo 2012-06-14 3:20 ` Tejun Heo 2012-06-14 9:50 ` Sasha Levin 2012-06-14 9:50 ` Sasha Levin 2012-06-14 20:56 ` Yinghai Lu 2012-06-14 20:56 ` Yinghai Lu 2012-06-14 21:34 ` Sasha Levin 2012-06-14 21:34 ` Sasha Levin 2012-06-14 23:57 ` Yinghai Lu 2012-06-14 23:57 ` Yinghai Lu 2012-06-15 0:59 ` Sasha Levin 2012-06-15 0:59 ` Sasha Levin 2012-06-15 0:59 ` Sasha Levin 2012-06-15 2:21 ` Yinghai Lu 2012-06-15 2:21 ` Yinghai Lu 2012-06-15 7:41 ` Sasha Levin 2012-06-15 7:41 ` Sasha Levin 2012-06-18 22:32 ` Tejun Heo 2012-06-18 22:32 ` Tejun Heo 2012-06-18 22:50 ` Sasha Levin 2012-06-18 22:50 ` Sasha Levin 2012-06-19 4:11 ` Gavin Shan 2012-06-19 4:11 ` Gavin Shan 2012-06-19 5:43 ` Yinghai Lu 2012-06-19 5:43 ` Yinghai Lu 2012-06-19 6:09 ` Gavin Shan 2012-06-19 6:09 ` Gavin Shan 2012-06-19 18:12 ` Yinghai Lu 2012-06-19 18:12 ` Yinghai Lu 2012-06-19 21:20 ` Tejun Heo 2012-06-19 21:20 ` Tejun Heo 2012-06-19 21:26 ` Tejun Heo 2012-06-19 21:26 ` Tejun Heo 2012-06-20 2:57 ` Yinghai Lu 2012-06-21 20:17 ` Tejun Heo 2012-06-21 20:17 ` Tejun Heo 2012-06-22 1:47 ` Yinghai Lu 2012-06-22 1:58 ` Yinghai Lu 2012-06-22 18:51 ` Tejun Heo 2012-06-22 18:51 ` Tejun Heo 2012-06-22 19:23 ` Yinghai Lu 2012-06-22 19:23 ` Yinghai Lu 2012-06-22 19:29 ` Tejun Heo 2012-06-22 19:29 ` Tejun Heo 2012-06-22 20:01 ` Yinghai Lu 2012-06-22 20:01 ` Yinghai Lu 2012-06-22 20:14 ` Tejun Heo 2012-06-22 20:14 ` Tejun Heo 2012-06-22 20:23 ` Yinghai Lu 2012-06-22 20:23 ` Yinghai Lu 2012-06-23 2:14 ` Yinghai Lu 2012-06-27 18:13 ` Tejun Heo 2012-06-27 18:13 ` Tejun Heo 2012-06-27 19:22 ` Yinghai Lu 2012-06-27 19:22 ` Yinghai Lu 2012-06-27 19:26 ` Tejun Heo 2012-06-27 19:26 ` Tejun Heo 2012-06-27 21:15 ` Yinghai Lu 2012-06-29 18:27 ` [PATCH for -3.5] memblock: free allocated memblock_reserved_regions later Yinghai Lu 2012-06-29 18:27 ` Yinghai Lu 2012-06-29 18:32 ` Tejun Heo 2012-06-29 18:32 ` Tejun Heo 2012-06-29 18:38 ` Yinghai Lu 2012-06-29 18:38 ` Yinghai Lu 2012-06-21 20:19 ` Tejun Heo [this message] 2012-06-21 20:19 ` Early boot panic on machine with lots of memory Tejun Heo 2012-06-22 10:29 ` Sasha Levin 2012-06-22 10:29 ` Sasha Levin 2012-06-22 18:15 ` Yinghai Lu 2012-06-22 18:15 ` Yinghai Lu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120621201935.GC4642@google.com \ --to=tj@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=davem@davemloft.net \ --cc=hpa@linux.intel.com \ --cc=levinsasha928@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=shangw@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.