[PATCH] regulator: enable module build for lp872x driver

[PATCH] regulator: enable module build for lp872x driver

[Kim, Milo]

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
 drivers/regulator/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 27fe52f..7abe31a 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -233,8 +233,8 @@ config REGULATOR_LP3972
 	 on National Semiconductors LP3972 PMIC
 
 config REGULATOR_LP872X
-	bool "TI/National Semiconductor LP8720/LP8725 voltage regulators"
-	depends on I2C=y
+	tristate "TI/National Semiconductor LP8720/LP8725 voltage regulators"
+	depends on I2C
 	select REGMAP_I2C
 	help
 	  This driver supports LP8720/LP8725 PMIC
-- 
1.7.2.5


Best Regards,
Milo

Re: [PATCH] regulator: enable module build for lp872x driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

On Tue, Jul 03, 2012 at 01:18:53AM +0000, Kim, Milo wrote:
> 
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>

No, this won't build.  As we went through when we had to fix that only
the other week...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

RE: [PATCH] regulator: enable module build for lp872x driver

[Kim, Milo]

> 
> On Tue, Jul 03, 2012 at 01:18:53AM +0000, Kim, Milo wrote:
> >
> > Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> 
> No, this won't build.  As we went through when we had to fix that only
> the other week...

Oh, sorry for bothering you again.
Please correct me if I miss something.
My understanding is boolean bulid configuration is temporary because the devm_gpio_request_one() is not exported.
But this gpio function had been patched in the linux-next tree and now we can use it in the module.
So that's why I've sent this patch again.

Thanks & BR
Milo -

Re: [PATCH] regulator: enable module build for lp872x driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

On Tue, Jul 03, 2012 at 11:58:43AM +0000, Kim, Milo wrote:

As I think I've mentioned before please fix your mailer to word wrap
within paragraphs.

> But this gpio function had been patched in the linux-next tree and now
> we can use it in the module.

No, we need the change to migrate into the regulator tree otherwise the
build will break in the regualtor tree.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]