* [PATCH] regulator: enable module build for lp872x driver
@ 2012-07-03 1:18 Kim, Milo
2012-07-03 9:34 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Kim, Milo @ 2012-07-03 1:18 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
drivers/regulator/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 27fe52f..7abe31a 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -233,8 +233,8 @@ config REGULATOR_LP3972
on National Semiconductors LP3972 PMIC
config REGULATOR_LP872X
- bool "TI/National Semiconductor LP8720/LP8725 voltage regulators"
- depends on I2C=y
+ tristate "TI/National Semiconductor LP8720/LP8725 voltage regulators"
+ depends on I2C
select REGMAP_I2C
help
This driver supports LP8720/LP8725 PMIC
--
1.7.2.5
Best Regards,
Milo
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: enable module build for lp872x driver
2012-07-03 1:18 [PATCH] regulator: enable module build for lp872x driver Kim, Milo
@ 2012-07-03 9:34 ` Mark Brown
2012-07-03 11:58 ` Kim, Milo
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2012-07-03 9:34 UTC (permalink / raw)
To: Kim, Milo; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
On Tue, Jul 03, 2012 at 01:18:53AM +0000, Kim, Milo wrote:
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
No, this won't build. As we went through when we had to fix that only
the other week...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] regulator: enable module build for lp872x driver
2012-07-03 9:34 ` Mark Brown
@ 2012-07-03 11:58 ` Kim, Milo
2012-07-03 12:36 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Kim, Milo @ 2012-07-03 11:58 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel
>
> On Tue, Jul 03, 2012 at 01:18:53AM +0000, Kim, Milo wrote:
> >
> > Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
>
> No, this won't build. As we went through when we had to fix that only
> the other week...
Oh, sorry for bothering you again.
Please correct me if I miss something.
My understanding is boolean bulid configuration is temporary because the devm_gpio_request_one() is not exported.
But this gpio function had been patched in the linux-next tree and now we can use it in the module.
So that's why I've sent this patch again.
Thanks & BR
Milo -
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: enable module build for lp872x driver
2012-07-03 11:58 ` Kim, Milo
@ 2012-07-03 12:36 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-07-03 12:36 UTC (permalink / raw)
To: Kim, Milo; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Tue, Jul 03, 2012 at 11:58:43AM +0000, Kim, Milo wrote:
As I think I've mentioned before please fix your mailer to word wrap
within paragraphs.
> But this gpio function had been patched in the linux-next tree and now
> we can use it in the module.
No, we need the change to migrate into the regulator tree otherwise the
build will break in the regualtor tree.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-03 12:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-03 1:18 [PATCH] regulator: enable module build for lp872x driver Kim, Milo
2012-07-03 9:34 ` Mark Brown
2012-07-03 11:58 ` Kim, Milo
2012-07-03 12:36 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.