From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Kevin Hilman <khilman@ti.com>,
Javier Martinez Canillas <martinez.javier@gmail.com>,
linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
linux-mmc@vger.kernel.org, "Shilimkar,
Santosh" <santosh.shilimkar@ti.com>, Chris Ball <cjb@laptop.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default
Date: Sat, 25 Aug 2012 08:57:42 +0100 [thread overview]
Message-ID: <20120825075742.GC25765@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.01.1208241404440.21552@pmeerw.net>
On Fri, Aug 24, 2012 at 02:10:38PM +0200, Peter Meerwald wrote:
> with Linux 3.6-rc3:
>
> CONFIG_DMA_OMAP=m
> CONFIG_DMA_ENGINE=y
> CONFIG_DMA_VIRTUAL_CHANNELS=m
> CONFIG_MMC_OMAP_HS=y
> CONFIG_SPI_OMAP24XX=y
> CONFIG_MTD_NAND_OMAP2=y
>
> LD init/built-in.o
> drivers/built-in.o: In function `omap2_mcspi_setup':
> /home/pmeerw/linux-pmeerw/drivers/spi/spi-omap2-mcspi.c:859: undefined reference to `omap_dma_filter_fn'
> drivers/built-in.o: In function `omap_nand_probe':
> /home/pmeerw/linux-pmeerw/drivers/mtd/nand/omap2.c:1371: undefined reference to `omap_dma_filter_fn'
> drivers/built-in.o: In function `omap_hsmmc_probe':
> /home/pmeerw/linux-pmeerw/drivers/mmc/host/omap_hsmmc.c:2039: undefined reference to `omap_dma_filter_fn'
> make: *** [vmlinux] Error 1
>
> in addition to SPI and MMC, there seems to be also a NAND dependency
Yes. Unlike the PL08x driver, OMAP has no way to pass the filter function
into its drivers, and I didn't want the pain of fiddling around with DT
crap to try and work out how to do this. So what you have here is
something that I got as far as I could, and TI then wanted it pushed into
mainline.
I have no solution for the above at present - the long term solution is
to sort out how to deal with DMA engine with DT etc. At the moment,
there has been discussion about this but no solution.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default
Date: Sat, 25 Aug 2012 08:57:42 +0100 [thread overview]
Message-ID: <20120825075742.GC25765@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.01.1208241404440.21552@pmeerw.net>
On Fri, Aug 24, 2012 at 02:10:38PM +0200, Peter Meerwald wrote:
> with Linux 3.6-rc3:
>
> CONFIG_DMA_OMAP=m
> CONFIG_DMA_ENGINE=y
> CONFIG_DMA_VIRTUAL_CHANNELS=m
> CONFIG_MMC_OMAP_HS=y
> CONFIG_SPI_OMAP24XX=y
> CONFIG_MTD_NAND_OMAP2=y
>
> LD init/built-in.o
> drivers/built-in.o: In function `omap2_mcspi_setup':
> /home/pmeerw/linux-pmeerw/drivers/spi/spi-omap2-mcspi.c:859: undefined reference to `omap_dma_filter_fn'
> drivers/built-in.o: In function `omap_nand_probe':
> /home/pmeerw/linux-pmeerw/drivers/mtd/nand/omap2.c:1371: undefined reference to `omap_dma_filter_fn'
> drivers/built-in.o: In function `omap_hsmmc_probe':
> /home/pmeerw/linux-pmeerw/drivers/mmc/host/omap_hsmmc.c:2039: undefined reference to `omap_dma_filter_fn'
> make: *** [vmlinux] Error 1
>
> in addition to SPI and MMC, there seems to be also a NAND dependency
Yes. Unlike the PL08x driver, OMAP has no way to pass the filter function
into its drivers, and I didn't want the pain of fiddling around with DT
crap to try and work out how to do this. So what you have here is
something that I got as far as I could, and TI then wanted it pushed into
mainline.
I have no solution for the above at present - the long term solution is
to sort out how to deal with DMA engine with DT etc. At the moment,
there has been discussion about this but no solution.
next prev parent reply other threads:[~2012-08-25 7:57 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1342485005-5178-1-git-send-email-javier@dowhile0.org>
2012-07-17 6:45 ` [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default Shilimkar, Santosh
2012-07-17 6:45 ` Shilimkar, Santosh
2012-07-17 6:51 ` Javier Martinez Canillas
2012-07-17 6:51 ` Javier Martinez Canillas
2012-07-18 6:59 ` Tony Lindgren
2012-07-18 6:59 ` Tony Lindgren
2012-07-18 7:04 ` Shilimkar, Santosh
2012-07-18 7:04 ` Shilimkar, Santosh
2012-07-18 7:10 ` Tony Lindgren
2012-07-18 7:10 ` Tony Lindgren
2012-07-18 7:44 ` S, Venkatraman
2012-07-18 7:44 ` S, Venkatraman
2012-07-18 8:36 ` Shilimkar, Santosh
2012-07-18 8:36 ` Shilimkar, Santosh
2012-07-18 8:49 ` Javier Martinez Canillas
2012-07-18 8:49 ` Javier Martinez Canillas
2012-07-18 9:11 ` Shilimkar, Santosh
2012-07-18 9:11 ` Shilimkar, Santosh
2012-07-18 9:16 ` Javier Martinez Canillas
2012-07-18 9:16 ` Javier Martinez Canillas
2012-07-18 9:38 ` S, Venkatraman
2012-07-18 9:38 ` S, Venkatraman
2012-07-18 9:44 ` Shilimkar, Santosh
2012-07-18 9:44 ` Shilimkar, Santosh
2012-07-19 11:32 ` Tony Lindgren
2012-07-19 11:32 ` Tony Lindgren
2012-07-20 9:28 ` S, Venkatraman
2012-07-20 9:28 ` S, Venkatraman
2012-07-20 10:01 ` S, Venkatraman
2012-07-20 10:01 ` S, Venkatraman
2012-08-23 21:00 ` Peter Meerwald
2012-08-23 21:00 ` Peter Meerwald
2012-08-24 7:10 ` Shilimkar, Santosh
2012-08-24 7:10 ` Shilimkar, Santosh
2012-08-24 7:51 ` Peter Meerwald
2012-08-24 7:51 ` Peter Meerwald
2012-08-24 9:42 ` Russell King - ARM Linux
2012-08-24 9:42 ` Russell King - ARM Linux
2012-08-24 10:21 ` Shilimkar, Santosh
2012-08-24 10:21 ` Shilimkar, Santosh
2012-08-24 10:39 ` Russell King - ARM Linux
2012-08-24 10:39 ` Russell King - ARM Linux
2012-08-24 10:45 ` Shilimkar, Santosh
2012-08-24 10:45 ` Shilimkar, Santosh
2012-08-24 12:10 ` Peter Meerwald
2012-08-24 12:10 ` Peter Meerwald
2012-08-25 7:57 ` Russell King - ARM Linux [this message]
2012-08-25 7:57 ` Russell King - ARM Linux
2012-07-18 8:25 ` Javier Martinez Canillas
2012-07-18 8:25 ` Javier Martinez Canillas
2012-07-19 11:31 ` Tony Lindgren
2012-07-19 11:31 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120825075742.GC25765@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=cjb@laptop.org \
--cc=javier@dowhile0.org \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.