From: Mark Brown <broonie@opensource.wolfsonmicro.com> To: Krystian Garbaciak <krystian.garbaciak@diasemi.com> Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, lm-sensors@lm-sensors.org, linux-input@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-leds@vger.kernel.org, "Samuel Ortiz" <sameo@linux.intel.com>, "Liam Girdwood" <lrg@ti.com>, "Alessandro Zummo" <a.zummo@towertech.it>, "Jean Delvare" <khali@linux-fr.org>, "Guenter Roeck" <linux@roeck-us.net>, "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Ashish Jangam" <ashish.jangam@kpitcummins.com>, "Andrew Jones" <drjones@redhat.com>, "Donggeun Kim" <dg77.kim@samsung.com>, "Philippe Rétornaz" <philippe.retornaz@epfl.ch>, "Wim Van Sebroeck" <wim@iguana.be>, "Bryan Wu" <bryan.wu@canonical.com>, "Richard Purdie <rpurdie@rpsys.net> Anthony Olech" <anthony.olech@diasemi.com> Subject: Re: [PATCH 1/8] mfd: Add Dialog DA906x core driver. Date: Sat, 25 Aug 2012 11:31:14 -0700 [thread overview] Message-ID: <20120825183113.GE6520@opensource.wolfsonmicro.com> (raw) In-Reply-To: <201208241450@sw-eng-lt-dc-vm2> On Fri, Aug 24, 2012 at 02:50:00PM +0100, Krystian Garbaciak wrote: > This is MFD module providing access to registers and interrupts of DA906x > series PMIC. It is used by other functional modules, registered as MFD cells. > Driver uses regmap with paging to access extended register list. Register map > is divided into two pages, where the second page is used during initialisation. Your selection of people to CC here appears both large and random... > +inline unsigned int da906x_to_range_reg(u16 reg) > +{ > + return reg + DA906X_MAPPING_BASE; > +} I've no real idea what this stuff is all about, it at least needs some comments somewhere. The fact that you're just adding a constant offset to all registers is at best odd. > + if (pdata->flags & DA906X_FLG_NO_CACHE) > + config = &da906x_no_cache_regmap_config; No, why would anyone ever want this and why would this not apply to all other drivers? > +static const struct i2c_device_id da906x_i2c_id[] = { > + {"da906x", PMIC_DA9063}, > + {}, > +}; > +MODULE_DEVICE_TABLE(i2c, da906x_i2c_id); List the actual devices here. > +#define DA906X_IRQ_BASE_OFFSET 0 Hrm?
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com> To: Krystian Garbaciak <krystian.garbaciak@diasemi.com> Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, lm-sensors@lm-sensors.org, linux-input@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-leds@vger.kernel.org, "Samuel Ortiz" <sameo@linux.intel.com>, "Liam Girdwood" <lrg@ti.com>, "Alessandro Zummo" <a.zummo@towertech.it>, "Jean Delvare" <khali@linux-fr.org>, "Guenter Roeck" <linux@roeck-us.net>, "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Ashish Jangam" <ashish.jangam@kpitcummins.com>, "Andrew Jones" <drjones@redhat.com>, "Donggeun Kim" <dg77.kim@samsung.com>, "Philippe Rétornaz" <philippe.retornaz@epfl.ch>, "Wim Van Sebroeck" <wim@iguana.be>, "Bryan Wu" <bryan.wu@canonical.com>, "Richard Purdie <rpurdie@rpsys.net> Anthony Olech" <anthony.olech@diasemi.com> Subject: Re: [lm-sensors] [PATCH 1/8] mfd: Add Dialog DA906x core driver. Date: Sat, 25 Aug 2012 18:31:14 +0000 [thread overview] Message-ID: <20120825183113.GE6520@opensource.wolfsonmicro.com> (raw) In-Reply-To: <201208241450@sw-eng-lt-dc-vm2> On Fri, Aug 24, 2012 at 02:50:00PM +0100, Krystian Garbaciak wrote: > This is MFD module providing access to registers and interrupts of DA906x > series PMIC. It is used by other functional modules, registered as MFD cells. > Driver uses regmap with paging to access extended register list. Register map > is divided into two pages, where the second page is used during initialisation. Your selection of people to CC here appears both large and random... > +inline unsigned int da906x_to_range_reg(u16 reg) > +{ > + return reg + DA906X_MAPPING_BASE; > +} I've no real idea what this stuff is all about, it at least needs some comments somewhere. The fact that you're just adding a constant offset to all registers is at best odd. > + if (pdata->flags & DA906X_FLG_NO_CACHE) > + config = &da906x_no_cache_regmap_config; No, why would anyone ever want this and why would this not apply to all other drivers? > +static const struct i2c_device_id da906x_i2c_id[] = { > + {"da906x", PMIC_DA9063}, > + {}, > +}; > +MODULE_DEVICE_TABLE(i2c, da906x_i2c_id); List the actual devices here. > +#define DA906X_IRQ_BASE_OFFSET 0 Hrm? _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-08-25 18:31 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-24 13:45 [RFC PATCH 0/8] DA906x PMIC driver Krystian Garbaciak 2012-08-24 13:45 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 13:50 ` [PATCH 1/8] mfd: Add Dialog DA906x core driver Krystian Garbaciak 2012-08-24 13:50 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 13:55 ` [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support Krystian Garbaciak 2012-08-24 13:55 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 14:00 ` [RFC PATCH 3/8] rtc: Add RTC driver for DA906x PMIC Krystian Garbaciak 2012-08-24 14:00 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 14:05 ` [RFC PATCH 4/8] hwmon: Add DA906x hardware monitoring support Krystian Garbaciak 2012-08-24 14:05 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 14:10 ` [RFC PATCH 5/8] input: Add support for DA906x PMIC OnKey detection Krystian Garbaciak 2012-08-24 14:10 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 14:15 ` [RFC PATCH 6/8] input: Add support for DA906x vibration motor driver Krystian Garbaciak 2012-08-24 14:15 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 14:20 ` [RFC PATCH 7/8] watchdog: Add DA906x PMIC watchdog driver Krystian Garbaciak 2012-08-24 14:20 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 14:25 ` [RFC PATCH 8/8] leds: Add DA906x PMIC LED driver Krystian Garbaciak 2012-08-24 14:25 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 18:45 ` [RFC PATCH 4/8] hwmon: Add DA906x hardware monitoring support Guenter Roeck 2012-08-24 18:45 ` [lm-sensors] " Guenter Roeck 2012-08-29 13:25 ` [PATCH] regulator: Fix bug in regulator_mode_to_status() core function Krystian Garbaciak 2012-08-29 13:25 ` [lm-sensors] " Krystian Garbaciak 2012-08-25 15:10 ` [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support Mark Brown 2012-08-25 15:10 ` [lm-sensors] " Mark Brown 2012-08-29 14:50 ` Krystian Garbaciak 2012-08-29 14:50 ` [lm-sensors] " Krystian Garbaciak 2012-08-29 14:50 ` Krystian Garbaciak 2012-08-30 17:47 ` Mark Brown 2012-08-30 17:47 ` [lm-sensors] " Mark Brown 2012-08-31 10:00 ` Krystian Garbaciak 2012-08-31 10:00 ` [lm-sensors] " Krystian Garbaciak 2012-08-31 10:00 ` Krystian Garbaciak 2013-05-09 14:05 ` Guennadi Liakhovetski 2013-05-09 14:18 ` Anthony Olech 2013-05-09 14:28 ` Guennadi Liakhovetski 2013-05-09 14:42 ` Anthony Olech 2013-05-09 14:50 ` Guennadi Liakhovetski 2012-08-25 18:31 ` Mark Brown [this message] 2012-08-25 18:31 ` [lm-sensors] [PATCH 1/8] mfd: Add Dialog DA906x core driver Mark Brown 2012-08-31 11:20 ` Krystian Garbaciak 2012-08-31 11:20 ` [lm-sensors] " Krystian Garbaciak 2012-08-31 11:20 ` Krystian Garbaciak 2012-08-31 11:37 ` Philippe Rétornaz 2012-08-31 11:37 ` [lm-sensors] " Philippe Rétornaz 2012-08-31 11:37 ` Philippe Rétornaz 2012-08-31 11:37 ` Philippe Rétornaz 2012-08-31 17:16 ` Mark Brown 2012-08-31 17:16 ` [lm-sensors] " Mark Brown -- strict thread matches above, loose matches on Subject: below -- 2012-08-24 8:32 [RFC PATCH 0/8] DA906x PMIC driver Krystian Garbaciak 2012-08-24 8:32 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 8:32 ` [PATCH 1/8] mfd: Add Dialog DA906x core driver Krystian Garbaciak 2012-08-24 8:32 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 8:32 ` [PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support Krystian Garbaciak 2012-08-24 8:32 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 8:32 ` [PATCH 3/8] rtc: Add RTC driver for DA906x PMIC Krystian Garbaciak 2012-08-24 8:32 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 8:32 ` [PATCH 4/8] hwmon: Add DA906x hardware monitoring support Krystian Garbaciak 2012-08-24 8:32 ` [lm-sensors] " Krystian Garbaciak 2012-08-24 8:32 ` [PATCH 5/8] input: Add support for DA906x PMIC OnKey detection Krystian Garbaciak 2012-08-24 8:32 ` [lm-sensors] " Krystian Garbaciak
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120825183113.GE6520@opensource.wolfsonmicro.com \ --to=broonie@opensource.wolfsonmicro.com \ --cc=a.zummo@towertech.it \ --cc=anthony.olech@diasemi.com \ --cc=ashish.jangam@kpitcummins.com \ --cc=bryan.wu@canonical.com \ --cc=dg77.kim@samsung.com \ --cc=dmitry.torokhov@gmail.com \ --cc=drjones@redhat.com \ --cc=khali@linux-fr.org \ --cc=krystian.garbaciak@diasemi.com \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=lm-sensors@lm-sensors.org \ --cc=lrg@ti.com \ --cc=philippe.retornaz@epfl.ch \ --cc=rtc-linux@googlegroups.com \ --cc=sameo@linux.intel.com \ --cc=wim@iguana.be \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.