From: Zach Brown <zab@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>,
Kent Overstreet <koverstreet@google.com>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com
Subject: Re: [PATCH 2/5] aio: kiocb_cancel()
Date: Wed, 10 Oct 2012 14:20:51 -0700 [thread overview]
Message-ID: <20121010212051.GD6371@lenny.home.zabbo.net> (raw)
In-Reply-To: <20121010110356.GA11468@thunk.org>
> And maybe the current way of doing things isn't the best way. But it
> would be nice if we didn't completely give up on the functionality of
> aio_cancel.
I sympathize, but the reality is that the current infrastructure
is very bad and no one is using it.
It's not like we're getting rid of the syscall. I'll be behaving
exactly as it does today: returning the error code that indicates that
cancellation failed because it lost the race with completion. Every
caller has to cope with that to use cancel safely.
So if someone eventually implements iocb cancel safely we'll be able to
plumb it back under the aio syscalls. But until that day I see no
reason to carry around buggy infrastructure that is only slowing down
the fast path.
- z
WARNING: multiple messages have this Message-ID (diff)
From: Zach Brown <zab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
Kent Overstreet
<koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 2/5] aio: kiocb_cancel()
Date: Wed, 10 Oct 2012 14:20:51 -0700 [thread overview]
Message-ID: <20121010212051.GD6371@lenny.home.zabbo.net> (raw)
In-Reply-To: <20121010110356.GA11468-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
> And maybe the current way of doing things isn't the best way. But it
> would be nice if we didn't completely give up on the functionality of
> aio_cancel.
I sympathize, but the reality is that the current infrastructure
is very bad and no one is using it.
It's not like we're getting rid of the syscall. I'll be behaving
exactly as it does today: returning the error code that indicates that
cancellation failed because it lost the race with completion. Every
caller has to cope with that to use cancel safely.
So if someone eventually implements iocb cancel safely we'll be able to
plumb it back under the aio syscalls. But until that day I see no
reason to carry around buggy infrastructure that is only slowing down
the fast path.
- z
next prev parent reply other threads:[~2012-10-10 21:21 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 6:39 [PATCH 1/5] aio: Kill return value of aio_complete() Kent Overstreet
2012-10-09 6:39 ` Kent Overstreet
2012-10-09 6:39 ` [PATCH 2/5] aio: kiocb_cancel() Kent Overstreet
2012-10-09 6:39 ` Kent Overstreet
2012-10-09 18:26 ` Zach Brown
2012-10-09 18:26 ` Zach Brown
2012-10-09 21:37 ` Kent Overstreet
2012-10-09 21:37 ` Kent Overstreet
2012-10-10 11:03 ` Theodore Ts'o
2012-10-10 11:03 ` Theodore Ts'o
2012-10-10 21:20 ` Zach Brown [this message]
2012-10-10 21:20 ` Zach Brown
2012-10-10 23:21 ` Theodore Ts'o
2012-10-10 23:21 ` Theodore Ts'o
2012-10-11 2:41 ` Kent Overstreet
2012-10-11 2:41 ` Kent Overstreet
2012-10-09 6:39 ` [PATCH 3/5] aio: Rewrite refcounting Kent Overstreet
2012-10-09 18:27 ` Zach Brown
2012-10-09 18:27 ` Zach Brown
2012-10-09 22:21 ` Kent Overstreet
2012-10-09 22:21 ` Kent Overstreet
2012-10-09 22:35 ` Zach Brown
2012-10-09 22:35 ` Zach Brown
2012-10-10 0:17 ` Kent Overstreet
2012-10-10 0:17 ` Kent Overstreet
2012-10-09 6:39 ` [PATCH 4/5] aio: vmap ringbuffer Kent Overstreet
2012-10-09 18:29 ` Zach Brown
2012-10-09 18:29 ` Zach Brown
2012-10-09 21:31 ` Kent Overstreet
2012-10-09 22:32 ` Zach Brown
2012-10-09 22:32 ` Zach Brown
2012-10-09 22:44 ` Kent Overstreet
2012-10-09 22:58 ` Zach Brown
2012-10-09 22:58 ` Zach Brown
2012-10-10 0:16 ` Kent Overstreet
2012-10-10 0:16 ` Kent Overstreet
2012-10-10 0:36 ` Zach Brown
2012-10-10 0:36 ` Zach Brown
2012-10-10 1:09 ` Kent Overstreet
2012-10-10 1:09 ` Kent Overstreet
2012-10-09 6:39 ` [PATCH 5/5] aio: Refactor aio_read_evt, use cmxchg(), fix bug Kent Overstreet
2012-10-09 6:39 ` Kent Overstreet
2012-10-09 18:37 ` Zach Brown
2012-10-09 18:37 ` Zach Brown
2012-10-09 21:27 ` Kent Overstreet
2012-10-09 21:27 ` Kent Overstreet
2012-10-09 22:47 ` Zach Brown
2012-10-09 22:47 ` Zach Brown
2012-10-09 22:55 ` Kent Overstreet
2012-10-09 22:55 ` Kent Overstreet
2012-10-09 23:10 ` Zach Brown
2012-10-09 23:10 ` Zach Brown
2012-10-10 0:06 ` Kent Overstreet
2012-10-10 0:06 ` Kent Overstreet
2012-10-10 0:26 ` Zach Brown
2012-10-10 0:26 ` Zach Brown
2012-10-10 0:47 ` Kent Overstreet
2012-10-10 0:47 ` Kent Overstreet
2012-10-10 21:43 ` Zach Brown
2012-10-10 21:43 ` Zach Brown
2012-10-11 2:51 ` Kent Overstreet
2012-10-11 2:51 ` Kent Overstreet
2012-10-11 16:43 ` Zach Brown
2012-10-11 16:43 ` Zach Brown
2012-10-09 18:25 ` [PATCH 1/5] aio: Kill return value of aio_complete() Zach Brown
2012-10-09 18:25 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010212051.GD6371@lenny.home.zabbo.net \
--to=zab@redhat.com \
--cc=dm-devel@redhat.com \
--cc=koverstreet@google.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.