From: "Theodore Ts'o" <tytso@mit.edu>
To: Zach Brown <zab@redhat.com>
Cc: Kent Overstreet <koverstreet@google.com>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com
Subject: Re: [PATCH 2/5] aio: kiocb_cancel()
Date: Wed, 10 Oct 2012 19:21:51 -0400 [thread overview]
Message-ID: <20121010232151.GC11468@thunk.org> (raw)
In-Reply-To: <20121010212051.GD6371@lenny.home.zabbo.net>
On Wed, Oct 10, 2012 at 02:20:51PM -0700, Zach Brown wrote:
>
> I sympathize, but the reality is that the current infrastructure
> is very bad and no one is using it.
>
> It's not like we're getting rid of the syscall. I'll be behaving
> exactly as it does today: returning the error code that indicates that
> cancellation failed because it lost the race with completion. Every
> caller has to cope with that to use cancel safely.
Yes, I realize it doesn't work today. But hopefully we'll be able to
reimplement it in a cleaner way. That's why I said, I hope we don't
give up on the functionality of aio_cancel --- not that I'm against
removing what we currently have.
Cheers,
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>
To: Zach Brown <zab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Kent Overstreet
<koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 2/5] aio: kiocb_cancel()
Date: Wed, 10 Oct 2012 19:21:51 -0400 [thread overview]
Message-ID: <20121010232151.GC11468@thunk.org> (raw)
In-Reply-To: <20121010212051.GD6371-fypN+1c5dIyjpB87vu3CluTW4wlIGRCZ@public.gmane.org>
On Wed, Oct 10, 2012 at 02:20:51PM -0700, Zach Brown wrote:
>
> I sympathize, but the reality is that the current infrastructure
> is very bad and no one is using it.
>
> It's not like we're getting rid of the syscall. I'll be behaving
> exactly as it does today: returning the error code that indicates that
> cancellation failed because it lost the race with completion. Every
> caller has to cope with that to use cancel safely.
Yes, I realize it doesn't work today. But hopefully we'll be able to
reimplement it in a cleaner way. That's why I said, I hope we don't
give up on the functionality of aio_cancel --- not that I'm against
removing what we currently have.
Cheers,
- Ted
next prev parent reply other threads:[~2012-10-10 23:22 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 6:39 [PATCH 1/5] aio: Kill return value of aio_complete() Kent Overstreet
2012-10-09 6:39 ` Kent Overstreet
2012-10-09 6:39 ` [PATCH 2/5] aio: kiocb_cancel() Kent Overstreet
2012-10-09 6:39 ` Kent Overstreet
2012-10-09 18:26 ` Zach Brown
2012-10-09 18:26 ` Zach Brown
2012-10-09 21:37 ` Kent Overstreet
2012-10-09 21:37 ` Kent Overstreet
2012-10-10 11:03 ` Theodore Ts'o
2012-10-10 11:03 ` Theodore Ts'o
2012-10-10 21:20 ` Zach Brown
2012-10-10 21:20 ` Zach Brown
2012-10-10 23:21 ` Theodore Ts'o [this message]
2012-10-10 23:21 ` Theodore Ts'o
2012-10-11 2:41 ` Kent Overstreet
2012-10-11 2:41 ` Kent Overstreet
2012-10-09 6:39 ` [PATCH 3/5] aio: Rewrite refcounting Kent Overstreet
2012-10-09 18:27 ` Zach Brown
2012-10-09 18:27 ` Zach Brown
2012-10-09 22:21 ` Kent Overstreet
2012-10-09 22:21 ` Kent Overstreet
2012-10-09 22:35 ` Zach Brown
2012-10-09 22:35 ` Zach Brown
2012-10-10 0:17 ` Kent Overstreet
2012-10-10 0:17 ` Kent Overstreet
2012-10-09 6:39 ` [PATCH 4/5] aio: vmap ringbuffer Kent Overstreet
2012-10-09 18:29 ` Zach Brown
2012-10-09 18:29 ` Zach Brown
2012-10-09 21:31 ` Kent Overstreet
2012-10-09 22:32 ` Zach Brown
2012-10-09 22:32 ` Zach Brown
2012-10-09 22:44 ` Kent Overstreet
2012-10-09 22:58 ` Zach Brown
2012-10-09 22:58 ` Zach Brown
2012-10-10 0:16 ` Kent Overstreet
2012-10-10 0:16 ` Kent Overstreet
2012-10-10 0:36 ` Zach Brown
2012-10-10 0:36 ` Zach Brown
2012-10-10 1:09 ` Kent Overstreet
2012-10-10 1:09 ` Kent Overstreet
2012-10-09 6:39 ` [PATCH 5/5] aio: Refactor aio_read_evt, use cmxchg(), fix bug Kent Overstreet
2012-10-09 6:39 ` Kent Overstreet
2012-10-09 18:37 ` Zach Brown
2012-10-09 18:37 ` Zach Brown
2012-10-09 21:27 ` Kent Overstreet
2012-10-09 21:27 ` Kent Overstreet
2012-10-09 22:47 ` Zach Brown
2012-10-09 22:47 ` Zach Brown
2012-10-09 22:55 ` Kent Overstreet
2012-10-09 22:55 ` Kent Overstreet
2012-10-09 23:10 ` Zach Brown
2012-10-09 23:10 ` Zach Brown
2012-10-10 0:06 ` Kent Overstreet
2012-10-10 0:06 ` Kent Overstreet
2012-10-10 0:26 ` Zach Brown
2012-10-10 0:26 ` Zach Brown
2012-10-10 0:47 ` Kent Overstreet
2012-10-10 0:47 ` Kent Overstreet
2012-10-10 21:43 ` Zach Brown
2012-10-10 21:43 ` Zach Brown
2012-10-11 2:51 ` Kent Overstreet
2012-10-11 2:51 ` Kent Overstreet
2012-10-11 16:43 ` Zach Brown
2012-10-11 16:43 ` Zach Brown
2012-10-09 18:25 ` [PATCH 1/5] aio: Kill return value of aio_complete() Zach Brown
2012-10-09 18:25 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010232151.GC11468@thunk.org \
--to=tytso@mit.edu \
--cc=dm-devel@redhat.com \
--cc=koverstreet@google.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.