All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org,
	lindner_marek-LWAfsSFWpa4@public.gmane.org
Subject: Re: [PATCH 03/16] batman-adv: separate BATADV_ATTR_HIF_UINT sysfs name from hard-iface variable
Date: Mon, 29 Oct 2012 09:13:40 +0100	[thread overview]
Message-ID: <20121029081340.GA5944@ritirata.org> (raw)
In-Reply-To: <20121028.185927.374901219739099234.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

Hello David,

On Sun, Oct 28, 2012 at 06:59:27PM -0400, David Miller wrote:
> From: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
> Date: Sun, 28 Oct 2012 12:17:04 +0100
> 
> > From: Marek Lindner <lindner_marek-LWAfsSFWpa4@public.gmane.org>
> > 
> > Signed-off-by: Marek Lindner <lindner_marek-LWAfsSFWpa4@public.gmane.org>
> > Signed-off-by: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
> > ---
> >  net/batman-adv/sysfs.c | 15 ++++++++-------
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> I was wondering how you could possibly change the list of arguments to
> these macros, yet avoid changing any of the users.
> 
> And sure enough it's because these macros are completely unused.

when this macro was introduced a user was going to be added as well, but then we
delayed some work and the user was not introduced anymore..

> 
> Please just remove them instead of changing their interfaces when no
> users exist.

Yes, I will resend the pull request with a patch that removes this macro at all.
We will re-introduce it as soon as the user is ready too.


Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <ordex@autistici.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	lindner_marek@yahoo.de
Subject: Re: [B.A.T.M.A.N.] [PATCH 03/16] batman-adv: separate BATADV_ATTR_HIF_UINT sysfs name from hard-iface variable
Date: Mon, 29 Oct 2012 09:13:40 +0100	[thread overview]
Message-ID: <20121029081340.GA5944@ritirata.org> (raw)
In-Reply-To: <20121028.185927.374901219739099234.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

Hello David,

On Sun, Oct 28, 2012 at 06:59:27PM -0400, David Miller wrote:
> From: Antonio Quartulli <ordex@autistici.org>
> Date: Sun, 28 Oct 2012 12:17:04 +0100
> 
> > From: Marek Lindner <lindner_marek@yahoo.de>
> > 
> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> > Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> > ---
> >  net/batman-adv/sysfs.c | 15 ++++++++-------
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> I was wondering how you could possibly change the list of arguments to
> these macros, yet avoid changing any of the users.
> 
> And sure enough it's because these macros are completely unused.

when this macro was introduced a user was going to be added as well, but then we
delayed some work and the user was not introduced anymore..

> 
> Please just remove them instead of changing their interfaces when no
> users exist.

Yes, I will resend the pull request with a patch that removes this macro at all.
We will re-introduce it as soon as the user is ready too.


Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

  parent reply	other threads:[~2012-10-29  8:13 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-28 11:17 pull request: batman-adv 2012-10-28 Antonio Quartulli
2012-10-28 11:17 ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 01/16] batman-adv: use check_unicast_packet() in recv_roam_adv() Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 02/16] batman-adv: split hard_iface struct for each routing protocol Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 03/16] batman-adv: separate BATADV_ATTR_HIF_UINT sysfs name from hard-iface variable Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 22:59   ` David Miller
2012-10-28 22:59     ` [B.A.T.M.A.N.] " David Miller
     [not found]     ` <20121028.185927.374901219739099234.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-10-29  8:13       ` Antonio Quartulli [this message]
2012-10-29  8:13         ` Antonio Quartulli
2012-10-28 11:17 ` [PATCH 04/16] batman-adv: consolidate duplicated primary_if checking code Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 05/16] batman-adv: return proper value in case of hash_add failure Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 06/16] batman-adv: Set special lockdep classes to avoid lockdep warning Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 07/16] batman-adv: Remove extra check in batadv_bit_get_packet Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 08/16] batman-adv: Check return value of try_module_get Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 09/16] batman-adv: Only increase refcounter once for alternate router Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 10/16] batman-adv: don't allow ECTP traffic on batman-adv Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 11/16] batman-adv: properly store the roaming time Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 12/16] batman-adv: print packets re-routing on DBG_TT and ratelimit it Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 13/16] batman-adv: check for more space before accessing the skb Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 14/16] batman-adv: properly convert flag into a boolean value Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 15/16] batman-adv: pass the WIFI flag from the local to global entry Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-10-28 11:17 ` [PATCH 16/16] batman-adv: add kernel-doc for enum batadv_dbg_level Antonio Quartulli
2012-10-28 11:17   ` [B.A.T.M.A.N.] " Antonio Quartulli
     [not found]   ` <1351423037-5292-17-git-send-email-ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
2012-10-28 13:32     ` Walter Robert Ditzler
2012-10-28 13:32       ` [B.A.T.M.A.N.] " Walter Robert Ditzler
2012-10-28 14:33       ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121029081340.GA5944@ritirata.org \
    --to=ordex-gaufno9rbhfsroww+9zijq@public.gmane.org \
    --cc=b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=lindner_marek-LWAfsSFWpa4@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.