From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, monstr@monstr.eu,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: sigaltstack fun
Date: Sun, 18 Nov 2012 19:59:21 +0000 [thread overview]
Message-ID: <20121118195921.GH16916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20121118.140332.1273544560009594278.davem@davemloft.net>
On Sun, Nov 18, 2012 at 02:03:32PM -0500, David Miller wrote:
> > I have absolutely no objections. sigaltstack has always been kind of
> > messy, and made worse by the fact that it gets effectively no testing
> > (because it's generally not used by normal code and even code that
> > uses it tends to use it only for very uncommon events). So forcing all
> > the sigaltstack code into generic code and at least avoiding the
> > "different architectures can get things subtly - or not so subtly -
> > wrong in different ways" sounds like a good thing.
>
> FWIW, if folks are looking for testcases there are a small number in
> glibc, a quick grep shows:
>
> nptl/tst-cancel20.c
> nptl/tst-cancel21.c
> nptl/tst-signal6.c
> debug/tst-longjmp_chk2.c
>
> LTP probably has a bunch too.
Might be a good idea to start adding tests/* in the kernel tree, perhaps?
Ones in glibc had been present prior to the LGPLv3 clusterfuck, by the
look of it...
next prev parent reply other threads:[~2012-11-18 19:59 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 22:35 new execve/kernel_thread design Al Viro
2012-10-17 5:32 ` Max Filippov
2012-10-17 5:43 ` Al Viro
2012-10-17 14:07 ` Jonas Bonn
2012-10-17 14:27 ` Michal Simek
2012-10-17 14:27 ` Michal Simek
2012-10-17 16:07 ` Al Viro
2012-10-17 16:07 ` Al Viro
2012-10-17 16:19 ` Al Viro
2012-10-17 16:19 ` Al Viro
2012-11-15 16:41 ` Michal Simek
2012-11-15 16:41 ` Michal Simek
2012-11-15 21:55 ` Al Viro
2012-11-15 21:55 ` Al Viro
2012-11-16 7:59 ` Michal Simek
2012-11-18 5:45 ` sigaltstack fun (was Re: new execve/kernel_thread design) Al Viro
2012-11-18 18:45 ` Linus Torvalds
2012-11-18 19:03 ` sigaltstack fun David Miller
2012-11-18 19:59 ` Al Viro [this message]
2012-11-18 20:48 ` David Miller
2012-11-19 4:55 ` Greg KH
2012-11-18 21:02 ` Al Viro
2012-11-18 21:18 ` David Miller
2012-11-19 1:10 ` Al Viro
2012-11-19 1:30 ` David Miller
2012-11-19 2:35 ` Al Viro
2012-11-19 3:27 ` David Miller
2012-11-26 5:10 ` Al Viro
2012-11-26 5:15 ` Al Viro
2012-12-04 3:03 ` David Miller
2012-12-04 2:58 ` David Miller
2012-11-21 1:53 ` sigaltstack fun (was Re: new execve/kernel_thread design) Al Viro
2012-10-19 15:49 ` new execve/kernel_thread design Al Viro
2012-10-19 17:16 ` Luck, Tony
2012-10-19 17:30 ` Al Viro
2012-10-19 18:01 ` Tony Luck
2012-10-19 18:33 ` Al Viro
2012-10-19 20:25 ` [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE Chris Metcalf
2012-10-19 20:25 ` Chris Metcalf
2012-10-19 21:35 ` Al Viro
2012-10-20 13:06 ` Chris Metcalf
2012-10-20 13:06 ` Chris Metcalf
2012-10-20 15:34 ` Al Viro
2012-10-20 17:16 ` Al Viro
2012-10-23 17:30 ` Chris Metcalf
2012-10-23 17:30 ` Chris Metcalf
2012-10-23 18:41 ` Al Viro
2012-10-23 19:22 ` Chris Metcalf
2012-10-23 19:22 ` Chris Metcalf
2012-10-23 20:36 ` Al Viro
2012-10-25 13:31 ` Chris Metcalf
2012-10-25 13:31 ` Chris Metcalf
2012-10-25 14:25 ` Al Viro
2012-10-23 20:47 ` Thomas Gleixner
2012-10-23 20:51 ` Jeff King
2012-10-23 21:09 ` Catalin Marinas
2012-10-23 21:22 ` Jeff King
2012-10-24 11:18 ` Catalin Marinas
2012-10-23 21:25 ` Thomas Gleixner
2012-10-23 21:47 ` Jeff King
2012-10-23 22:06 ` Marc Gauthier
2012-10-23 22:23 ` Jeff King
2012-10-24 6:02 ` Johannes Sixt
2012-10-24 1:02 ` Linus Torvalds
2012-10-24 1:56 ` Al Viro
2012-10-24 2:14 ` Linus Torvalds
2012-10-24 6:02 ` Ingo Molnar
2012-10-23 17:30 ` [PATCH] arch/tile: eliminate pt_regs trampolines for syscalls Chris Metcalf
2012-10-23 17:30 ` Chris Metcalf
2012-10-22 14:23 ` [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE Catalin Marinas
2012-10-19 20:25 ` Chris Metcalf
2012-10-25 16:54 ` new execve/kernel_thread design Richard Kuo
2012-10-26 18:31 ` [update] " Al Viro
2012-10-26 18:31 ` Al Viro
2012-10-27 3:32 ` Al Viro
2012-10-27 3:32 ` Al Viro
2012-10-29 7:53 ` Martin Schwidefsky
2012-10-29 7:53 ` Martin Schwidefsky
2012-10-29 13:25 ` Al Viro
2012-10-29 13:25 ` Al Viro
2012-10-29 14:38 ` Martin Schwidefsky
2012-10-29 14:38 ` Martin Schwidefsky
2012-10-29 14:57 ` Al Viro
2012-10-29 14:57 ` Al Viro
2012-12-07 22:23 ` Al Viro
2012-12-07 22:23 ` Al Viro
2012-12-08 2:40 ` Chris Metcalf
2012-12-08 2:40 ` Chris Metcalf
2012-12-08 2:40 ` Chris Metcalf
2012-12-13 1:54 ` Hirokazu Takata
2012-12-13 1:54 ` Hirokazu Takata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121118195921.GH16916@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.