From: Al Viro <viro@ZenIV.linux.org.uk>
To: Michal Simek <monstr@monstr.eu>
Cc: Jonas Bonn <jonas@southpole.se>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Mike Frysinger <vapier@gentoo.org>,
Jesper Nilsson <jesper.nilsson@axis.com>,
David Howells <dhowells@redhat.com>,
Tony Luck <tony.luck@intel.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Hirokazu Takata <takata@linux-m32r.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Richard Kuo <rkuo@codeaurora.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Lennox Wu <lennox.wu@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Paul Mundt <lethal@linux-sh.org>, Chris Zankel <chris@zankel.net>,
Chris Metcalf <cmetcalf@tilera.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: Re: new execve/kernel_thread design
Date: Thu, 15 Nov 2012 21:55:29 +0000 [thread overview]
Message-ID: <20121115215529.GU2616@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHTX3dJN4Jun2KVXpda1wTrwkjT0mmH4fYmUUwq69d9sCTjXnA@mail.gmail.com>
On Thu, Nov 15, 2012 at 05:41:16PM +0100, Michal Simek wrote:
> Here is the branch based on rc5 (information below)
> and here is giweb.
> http://developer.petalogix.com/git/gitweb.cgi?p=linux-2.6-microblaze.git;a=shortlog;h=refs/heads/viro/arch-microblaze-rc5
>
> I have also looked at your sys_fork / sys_vfork / sys_clone unification
> and I have fixed it for Microblaze.
>
> Also I have done some tests on it for sure.
>
> I would add sys_execve/kernel_execve/kernel_thread patches to my next branch.
> Are you OK with that?
Umm... In principle - yes, but I've a couple of question abouts those.
1) What's that set_fs(USER_DS) in start_thread() for? Note that we do the same
thing in flush_old_exec(), at the same time we remove PF_KTHREAD from
current->flags.
While we are at it, if we *ever* hit do_signal() with KERNEL_DS, we are
very deep in trouble. set_fs(USER_DS) in setup_{rt_,}frame() is pointless.
2) your definition of current_pt_regs() is an exact copy of on in
include/linux/ptrace.h; why is "microblaze: Define current_pt_regs"
needed at all? IOW, I'd rather added #include <linux/ptrace.h> to
arch/microblaze/kernel/process.c instead...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Michal Simek <monstr@monstr.eu>
Cc: Jonas Bonn <jonas@southpole.se>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Mike Frysinger <vapier@gentoo.org>,
Jesper Nilsson <jesper.nilsson@axis.com>,
David Howells <dhowells@redhat.com>,
Tony Luck <tony.luck@intel.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Hirokazu Takata <takata@linux-m32r.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Richard Kuo <rkuo@codeaurora.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Lennox Wu <lennox.wu@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Paul Mundt <lethal@linux-sh.org>, Chris Zankel <chris@zankel.net>,
Chris Metcalf <cmetcalf@tilera.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>, Guan Xuetao <gx>
Subject: Re: new execve/kernel_thread design
Date: Thu, 15 Nov 2012 21:55:29 +0000 [thread overview]
Message-ID: <20121115215529.GU2616@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHTX3dJN4Jun2KVXpda1wTrwkjT0mmH4fYmUUwq69d9sCTjXnA@mail.gmail.com>
On Thu, Nov 15, 2012 at 05:41:16PM +0100, Michal Simek wrote:
> Here is the branch based on rc5 (information below)
> and here is giweb.
> http://developer.petalogix.com/git/gitweb.cgi?p=linux-2.6-microblaze.git;a=shortlog;h=refs/heads/viro/arch-microblaze-rc5
>
> I have also looked at your sys_fork / sys_vfork / sys_clone unification
> and I have fixed it for Microblaze.
>
> Also I have done some tests on it for sure.
>
> I would add sys_execve/kernel_execve/kernel_thread patches to my next branch.
> Are you OK with that?
Umm... In principle - yes, but I've a couple of question abouts those.
1) What's that set_fs(USER_DS) in start_thread() for? Note that we do the same
thing in flush_old_exec(), at the same time we remove PF_KTHREAD from
current->flags.
While we are at it, if we *ever* hit do_signal() with KERNEL_DS, we are
very deep in trouble. set_fs(USER_DS) in setup_{rt_,}frame() is pointless.
2) your definition of current_pt_regs() is an exact copy of on in
include/linux/ptrace.h; why is "microblaze: Define current_pt_regs"
needed at all? IOW, I'd rather added #include <linux/ptrace.h> to
arch/microblaze/kernel/process.c instead...
next prev parent reply other threads:[~2012-11-15 21:55 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 22:35 new execve/kernel_thread design Al Viro
2012-10-17 5:32 ` Max Filippov
2012-10-17 5:43 ` Al Viro
2012-10-17 14:07 ` Jonas Bonn
2012-10-17 14:27 ` Michal Simek
2012-10-17 14:27 ` Michal Simek
2012-10-17 16:07 ` Al Viro
2012-10-17 16:07 ` Al Viro
2012-10-17 16:19 ` Al Viro
2012-10-17 16:19 ` Al Viro
2012-11-15 16:41 ` Michal Simek
2012-11-15 16:41 ` Michal Simek
2012-11-15 21:55 ` Al Viro [this message]
2012-11-15 21:55 ` Al Viro
2012-11-16 7:59 ` Michal Simek
2012-11-18 5:45 ` sigaltstack fun (was Re: new execve/kernel_thread design) Al Viro
2012-11-18 18:45 ` Linus Torvalds
2012-11-18 19:03 ` sigaltstack fun David Miller
2012-11-18 19:59 ` Al Viro
2012-11-18 20:48 ` David Miller
2012-11-19 4:55 ` Greg KH
2012-11-18 21:02 ` Al Viro
2012-11-18 21:18 ` David Miller
2012-11-19 1:10 ` Al Viro
2012-11-19 1:30 ` David Miller
2012-11-19 2:35 ` Al Viro
2012-11-19 3:27 ` David Miller
2012-11-26 5:10 ` Al Viro
2012-11-26 5:15 ` Al Viro
2012-12-04 3:03 ` David Miller
2012-12-04 2:58 ` David Miller
2012-11-21 1:53 ` sigaltstack fun (was Re: new execve/kernel_thread design) Al Viro
2012-10-19 15:49 ` new execve/kernel_thread design Al Viro
2012-10-19 17:16 ` Luck, Tony
2012-10-19 17:30 ` Al Viro
2012-10-19 18:01 ` Tony Luck
2012-10-19 18:33 ` Al Viro
2012-10-19 20:25 ` [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE Chris Metcalf
2012-10-19 20:25 ` Chris Metcalf
2012-10-19 21:35 ` Al Viro
2012-10-20 13:06 ` Chris Metcalf
2012-10-20 13:06 ` Chris Metcalf
2012-10-20 15:34 ` Al Viro
2012-10-20 17:16 ` Al Viro
2012-10-23 17:30 ` Chris Metcalf
2012-10-23 17:30 ` Chris Metcalf
2012-10-23 18:41 ` Al Viro
2012-10-23 19:22 ` Chris Metcalf
2012-10-23 19:22 ` Chris Metcalf
2012-10-23 20:36 ` Al Viro
2012-10-25 13:31 ` Chris Metcalf
2012-10-25 13:31 ` Chris Metcalf
2012-10-25 14:25 ` Al Viro
2012-10-23 20:47 ` Thomas Gleixner
2012-10-23 20:51 ` Jeff King
2012-10-23 21:09 ` Catalin Marinas
2012-10-23 21:22 ` Jeff King
2012-10-24 11:18 ` Catalin Marinas
2012-10-23 21:25 ` Thomas Gleixner
2012-10-23 21:47 ` Jeff King
2012-10-23 22:06 ` Marc Gauthier
2012-10-23 22:23 ` Jeff King
2012-10-24 6:02 ` Johannes Sixt
2012-10-24 1:02 ` Linus Torvalds
2012-10-24 1:56 ` Al Viro
2012-10-24 2:14 ` Linus Torvalds
2012-10-24 6:02 ` Ingo Molnar
2012-10-23 17:30 ` [PATCH] arch/tile: eliminate pt_regs trampolines for syscalls Chris Metcalf
2012-10-23 17:30 ` Chris Metcalf
2012-10-22 14:23 ` [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE Catalin Marinas
2012-10-19 20:25 ` Chris Metcalf
2012-10-25 16:54 ` new execve/kernel_thread design Richard Kuo
2012-10-26 18:31 ` [update] " Al Viro
2012-10-26 18:31 ` Al Viro
2012-10-27 3:32 ` Al Viro
2012-10-27 3:32 ` Al Viro
2012-10-29 7:53 ` Martin Schwidefsky
2012-10-29 7:53 ` Martin Schwidefsky
2012-10-29 13:25 ` Al Viro
2012-10-29 13:25 ` Al Viro
2012-10-29 14:38 ` Martin Schwidefsky
2012-10-29 14:38 ` Martin Schwidefsky
2012-10-29 14:57 ` Al Viro
2012-10-29 14:57 ` Al Viro
2012-12-07 22:23 ` Al Viro
2012-12-07 22:23 ` Al Viro
2012-12-08 2:40 ` Chris Metcalf
2012-12-08 2:40 ` Chris Metcalf
2012-12-08 2:40 ` Chris Metcalf
2012-12-13 1:54 ` Hirokazu Takata
2012-12-13 1:54 ` Hirokazu Takata
2012-10-19 15:55 Al Viro
2012-10-21 10:35 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115215529.GU2616@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=hskinnemoen@gmail.com \
--cc=jejb@parisc-linux.org \
--cc=jesper.nilsson@axis.com \
--cc=jonas@southpole.se \
--cc=lennox.wu@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=rkuo@codeaurora.org \
--cc=schwidefsky@de.ibm.com \
--cc=takata@linux-m32r.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vapier@gentoo.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.