* [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
@ 2012-11-13 10:46 Bastian Hecht
2012-11-14 23:22 ` Simon Horman
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Bastian Hecht @ 2012-11-13 10:46 UTC (permalink / raw)
To: linux-sh
The FLCTL driver now requires the resource of the error IRQ.
Signed-off-by: Bastian Hecht <hechtb@gmail.com>
---
arch/arm/mach-shmobile/board-mackerel.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index 0c27c81..66ec616 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -1018,7 +1018,11 @@ static struct resource nand_flash_resources[] = {
.start = 0xe6a30000,
.end = 0xe6a3009b,
.flags = IORESOURCE_MEM,
- }
+ },
+ [1] = {
+ .start = evt2irq(0x0d80), /* flstei: status error irq */
+ .flags = IORESOURCE_IRQ,
+ },
};
static struct sh_flctl_platform_data nand_flash_data = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
2012-11-13 10:46 [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Bastian Hecht
@ 2012-11-14 23:22 ` Simon Horman
2012-11-15 9:13 ` Bastian Hecht
` (3 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2012-11-14 23:22 UTC (permalink / raw)
To: linux-sh
On Tue, Nov 13, 2012 at 11:46:49AM +0100, Bastian Hecht wrote:
> The FLCTL driver now requires the resource of the error IRQ.
Hi Bastian,
could you provide a little more information on:
* Why this is so. Is it related to a change in another commit?
* What the implications are of this change not being applied:
the driver doesn't work?
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> ---
> arch/arm/mach-shmobile/board-mackerel.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 0c27c81..66ec616 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -1018,7 +1018,11 @@ static struct resource nand_flash_resources[] = {
> .start = 0xe6a30000,
> .end = 0xe6a3009b,
> .flags = IORESOURCE_MEM,
> - }
> + },
> + [1] = {
> + .start = evt2irq(0x0d80), /* flstei: status error irq */
> + .flags = IORESOURCE_IRQ,
> + },
> };
>
> static struct sh_flctl_platform_data nand_flash_data = {
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
2012-11-13 10:46 [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Bastian Hecht
2012-11-14 23:22 ` Simon Horman
@ 2012-11-15 9:13 ` Bastian Hecht
2012-11-16 0:02 ` Simon Horman
` (2 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Bastian Hecht @ 2012-11-15 9:13 UTC (permalink / raw)
To: linux-sh
Hello Simon,
> could you provide a little more information on:
> * Why this is so. Is it related to a change in another commit?
Oh sure. So, the error IRQ was introduced in commit 3c7ea4eccfd2e mtd:
sh_flctl: Add support for error IRQ.
It notifies us when the actual communication from our flash controller
to the NAND chip fails.
> * What the implications are of this change not being applied:
> the driver doesn't work?
Yes the driver refuses to start up if the error IRQ is missing.
Do you think I should include such information into the commit
message, or is it just helpful for the upstream process?
Cheers,
Bastian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
2012-11-13 10:46 [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Bastian Hecht
2012-11-14 23:22 ` Simon Horman
2012-11-15 9:13 ` Bastian Hecht
@ 2012-11-16 0:02 ` Simon Horman
2012-11-20 0:05 ` Bastian Hecht
2012-11-20 0:43 ` Simon Horman
4 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2012-11-16 0:02 UTC (permalink / raw)
To: linux-sh
On Thu, Nov 15, 2012 at 10:13:51AM +0100, Bastian Hecht wrote:
> Hello Simon,
>
> > could you provide a little more information on:
> > * Why this is so. Is it related to a change in another commit?
>
> Oh sure. So, the error IRQ was introduced in commit 3c7ea4eccfd2e mtd:
> sh_flctl: Add support for error IRQ.
> It notifies us when the actual communication from our flash controller
> to the NAND chip fails.
>
> > * What the implications are of this change not being applied:
> > the driver doesn't work?
>
> Yes the driver refuses to start up if the error IRQ is missing.
>
> Do you think I should include such information into the commit
> message, or is it just helpful for the upstream process?
Yes. Please re-post the patch with a revised commit message
that includes the information above.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
2012-11-13 10:46 [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Bastian Hecht
` (2 preceding siblings ...)
2012-11-16 0:02 ` Simon Horman
@ 2012-11-20 0:05 ` Bastian Hecht
2012-11-20 0:43 ` Simon Horman
4 siblings, 0 replies; 14+ messages in thread
From: Bastian Hecht @ 2012-11-20 0:05 UTC (permalink / raw)
To: linux-sh
Since commit 3c7ea4e (mtd: sh_flctl: Add support for error IRQ)
the sh_flctl driver requires the error IRQ line to signal failed
transactions between the flash controller and the NAND chip.
This information is mandatory - else the driver refuses to start
up. We provide it here for the board mackerel.
Signed-off-by: Bastian Hecht <hechtb@gmail.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
v1: extended commit
v2: added commit message of referenced patch
arch/arm/mach-shmobile/board-mackerel.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index 0c27c81..66ec616 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -1018,7 +1018,11 @@ static struct resource nand_flash_resources[] = {
.start = 0xe6a30000,
.end = 0xe6a3009b,
.flags = IORESOURCE_MEM,
- }
+ },
+ [1] = {
+ .start = evt2irq(0x0d80), /* flstei: status error irq */
+ .flags = IORESOURCE_IRQ,
+ },
};
static struct sh_flctl_platform_data nand_flash_data = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
2012-11-13 10:46 [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Bastian Hecht
` (3 preceding siblings ...)
2012-11-20 0:05 ` Bastian Hecht
@ 2012-11-20 0:43 ` Simon Horman
4 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2012-11-20 0:43 UTC (permalink / raw)
To: linux-sh
On Tue, Nov 20, 2012 at 01:05:00AM +0100, Bastian Hecht wrote:
> Since commit 3c7ea4e (mtd: sh_flctl: Add support for error IRQ)
> the sh_flctl driver requires the error IRQ line to signal failed
> transactions between the flash controller and the NAND chip.
> This information is mandatory - else the driver refuses to start
> up. We provide it here for the board mackerel.
>
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
> ---
> v1: extended commit
> v2: added commit message of referenced patch
Thanks, I have updated the boards2 branch and sent an
updated pull-request to arm-soc.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
2012-11-20 0:43 [GIT PULL v2] Renesas ARM-based SoC boards for v3.8 #3 Simon Horman
@ 2012-11-20 0:43 ` Simon Horman
0 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2012-11-20 0:43 UTC (permalink / raw)
To: linux-arm-kernel
From: Bastian Hecht <hechtb@gmail.com>
Since commit 3c7ea4e (mtd: sh_flctl: Add support for error IRQ)
the sh_flctl driver requires the error IRQ line to signal failed
transactions between the flash controller and the NAND chip.
This information is mandatory - else the driver refuses to start
up. We provide it here for the board mackerel.
Signed-off-by: Bastian Hecht <hechtb@gmail.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
arch/arm/mach-shmobile/board-mackerel.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index bf2bcb9..3f56e70 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -950,7 +950,11 @@ static struct resource nand_flash_resources[] = {
.start = 0xe6a30000,
.end = 0xe6a3009b,
.flags = IORESOURCE_MEM,
- }
+ },
+ [1] = {
+ .start = evt2irq(0x0d80), /* flstei: status error irq */
+ .flags = IORESOURCE_IRQ,
+ },
};
static struct sh_flctl_platform_data nand_flash_data = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
@ 2012-11-20 0:43 ` Simon Horman
0 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2012-11-20 0:43 UTC (permalink / raw)
To: linux-arm-kernel
From: Bastian Hecht <hechtb@gmail.com>
Since commit 3c7ea4e (mtd: sh_flctl: Add support for error IRQ)
the sh_flctl driver requires the error IRQ line to signal failed
transactions between the flash controller and the NAND chip.
This information is mandatory - else the driver refuses to start
up. We provide it here for the board mackerel.
Signed-off-by: Bastian Hecht <hechtb@gmail.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
arch/arm/mach-shmobile/board-mackerel.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index bf2bcb9..3f56e70 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -950,7 +950,11 @@ static struct resource nand_flash_resources[] = {
.start = 0xe6a30000,
.end = 0xe6a3009b,
.flags = IORESOURCE_MEM,
- }
+ },
+ [1] = {
+ .start = evt2irq(0x0d80), /* flstei: status error irq */
+ .flags = IORESOURCE_IRQ,
+ },
};
static struct sh_flctl_platform_data nand_flash_data = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
2012-11-19 12:30 ` Sergei Shtylyov
@ 2012-11-20 0:03 ` Simon Horman
-1 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2012-11-20 0:03 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 19, 2012 at 04:30:59PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 19-11-2012 5:24, Simon Horman wrote:
>
> >From: Bastian Hecht <hechtb@gmail.com>
>
> >Since commit 3c7ea4eccfd2e
>
> Please also specify that commit summary in parens.
Thanks, I will fix this and re-post.
> >the sh_flctl driver requires the error IRQ line to
> >signal failed transactions between the flash controller and the NAND chip.
> >This information is mandatory - else the driver refuses to start up. We
> >provide it here for the board mackerel.
>
> >Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> >Signed-off-by: Simon Horman <horms@verge.net.au>
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
@ 2012-11-20 0:03 ` Simon Horman
0 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2012-11-20 0:03 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 19, 2012 at 04:30:59PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 19-11-2012 5:24, Simon Horman wrote:
>
> >From: Bastian Hecht <hechtb@gmail.com>
>
> >Since commit 3c7ea4eccfd2e
>
> Please also specify that commit summary in parens.
Thanks, I will fix this and re-post.
> >the sh_flctl driver requires the error IRQ line to
> >signal failed transactions between the flash controller and the NAND chip.
> >This information is mandatory - else the driver refuses to start up. We
> >provide it here for the board mackerel.
>
> >Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> >Signed-off-by: Simon Horman <horms@verge.net.au>
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
2012-11-19 1:24 ` Simon Horman
@ 2012-11-19 12:30 ` Sergei Shtylyov
-1 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2012-11-19 12:30 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 19-11-2012 5:24, Simon Horman wrote:
> From: Bastian Hecht <hechtb@gmail.com>
> Since commit 3c7ea4eccfd2e
Please also specify that commit summary in parens.
> the sh_flctl driver requires the error IRQ line to
> signal failed transactions between the flash controller and the NAND chip.
> This information is mandatory - else the driver refuses to start up. We
> provide it here for the board mackerel.
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
@ 2012-11-19 12:30 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2012-11-19 12:30 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 19-11-2012 5:24, Simon Horman wrote:
> From: Bastian Hecht <hechtb@gmail.com>
> Since commit 3c7ea4eccfd2e
Please also specify that commit summary in parens.
> the sh_flctl driver requires the error IRQ line to
> signal failed transactions between the flash controller and the NAND chip.
> This information is mandatory - else the driver refuses to start up. We
> provide it here for the board mackerel.
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
2012-11-19 1:24 [GIT PULL] Renesas ARM-based SoC boards for v3.8 #3 Simon Horman
@ 2012-11-19 1:24 ` Simon Horman
0 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2012-11-19 1:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Bastian Hecht <hechtb@gmail.com>
Since commit 3c7ea4eccfd2e the sh_flctl driver requires the error IRQ line to
signal failed transactions between the flash controller and the NAND chip.
This information is mandatory - else the driver refuses to start up. We
provide it here for the board mackerel.
Signed-off-by: Bastian Hecht <hechtb@gmail.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
arch/arm/mach-shmobile/board-mackerel.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index bf2bcb9..3f56e70 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -950,7 +950,11 @@ static struct resource nand_flash_resources[] = {
.start = 0xe6a30000,
.end = 0xe6a3009b,
.flags = IORESOURCE_MEM,
- }
+ },
+ [1] = {
+ .start = evt2irq(0x0d80), /* flstei: status error irq */
+ .flags = IORESOURCE_IRQ,
+ },
};
static struct sh_flctl_platform_data nand_flash_data = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
@ 2012-11-19 1:24 ` Simon Horman
0 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2012-11-19 1:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Bastian Hecht <hechtb@gmail.com>
Since commit 3c7ea4eccfd2e the sh_flctl driver requires the error IRQ line to
signal failed transactions between the flash controller and the NAND chip.
This information is mandatory - else the driver refuses to start up. We
provide it here for the board mackerel.
Signed-off-by: Bastian Hecht <hechtb@gmail.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
arch/arm/mach-shmobile/board-mackerel.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index bf2bcb9..3f56e70 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -950,7 +950,11 @@ static struct resource nand_flash_resources[] = {
.start = 0xe6a30000,
.end = 0xe6a3009b,
.flags = IORESOURCE_MEM,
- }
+ },
+ [1] = {
+ .start = evt2irq(0x0d80), /* flstei: status error irq */
+ .flags = IORESOURCE_IRQ,
+ },
};
static struct sh_flctl_platform_data nand_flash_data = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2012-11-20 0:43 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-13 10:46 [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Bastian Hecht
2012-11-14 23:22 ` Simon Horman
2012-11-15 9:13 ` Bastian Hecht
2012-11-16 0:02 ` Simon Horman
2012-11-20 0:05 ` Bastian Hecht
2012-11-20 0:43 ` Simon Horman
2012-11-19 1:24 [GIT PULL] Renesas ARM-based SoC boards for v3.8 #3 Simon Horman
2012-11-19 1:24 ` [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Simon Horman
2012-11-19 1:24 ` Simon Horman
2012-11-19 12:30 ` Sergei Shtylyov
2012-11-19 12:30 ` Sergei Shtylyov
2012-11-20 0:03 ` Simon Horman
2012-11-20 0:03 ` Simon Horman
2012-11-20 0:43 [GIT PULL v2] Renesas ARM-based SoC boards for v3.8 #3 Simon Horman
2012-11-20 0:43 ` [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Simon Horman
2012-11-20 0:43 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.