From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH]: PVH: specify xen features strings cleany for PVH
Date: Tue, 22 Jan 2013 15:12:41 -0800 [thread overview]
Message-ID: <20130122151241.7ed034f4@mantra.us.oracle.com> (raw)
In-Reply-To: <50FD3D6202000078000B7CE4@nat28.tlf.novell.com>
On Mon, 21 Jan 2013 12:06:42 +0000
"Jan Beulich" <JBeulich@suse.com> wrote:
> >>> On 19.01.13 at 02:35, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
>
> That's not really better. What I'd like you to do is keep the common
> part common (i.e. not redundantly defined) and add the PVH-specific
> bits (with what amounts to an empty string as the non-PVH
> replacement) on top. Meaning you will likely want a mixture of
> .ascii and .asciz.
ELFNOTE(Xen, XEN_ELFNOTE_FEATURES, .asciz "!writable_page_tables|pae_pgdir_above_4gb"PVH_FEATURES_STR);
Will put NULL char before PVH_FEATURES_STR, so we need:
ELFNOTE(Xen, XEN_ELFNOTE_FEATURES, .ascii "!writable_page_tables|pae_pgdir_above_4gb"PVH_FEATURES_STR);
This means PVH_FEATURES_STR has to be defined as:
#define PVH_FEATURES_STR "|writable_descriptor_tables|auto_translated_physmap|supervisor_mode_kernel|hvm_callback_vector\0"
because
#define PVH_FEATURES_STR "|writable_descriptor_tables" \
"|auto_translated_physmap"
.....
will put null char after writable_descriptor_tables. Putting .ascii
above will not work either with concatenation later.
So, I think what I proposed earlier is the cleanest. Alternately:
#ifdef CONFIG_XEN_X86_PVH
#define PVH_FEATURES_STR "|writable_descriptor_tables|auto_translated_physmap|supervisor_mode_kernel|hvm_callback_vector\0"
#else
#define PVH_FEATURES_STR "\0"
#endif
Then:
ELFNOTE(Xen, XEN_ELFNOTE_FEATURES, .ascii "!writable_page_tables|pae_pgdir_above_4gb"PVH_FEATURES_STR);
Let me know what you prefer, whats right above, or what I had originally
last week. I can't figure any other way.
Thanks,
Mukesh
next prev parent reply other threads:[~2013-01-22 23:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 1:35 [PATCH]: PVH: specify xen features strings cleany for PVH Mukesh Rathor
2013-01-21 12:06 ` Jan Beulich
2013-01-22 23:12 ` Mukesh Rathor [this message]
2013-01-23 8:22 ` Jan Beulich
2013-01-23 22:43 ` Mukesh Rathor
2013-01-24 9:16 ` Jan Beulich
2013-01-24 9:27 ` Ian Campbell
2013-01-24 15:10 ` Konrad Rzeszutek Wilk
2013-01-24 23:13 ` Mukesh Rathor
2013-01-25 8:02 ` Jan Beulich
2013-01-25 10:11 ` Ian Campbell
2013-01-25 10:27 ` Jan Beulich
2013-01-25 10:43 ` Ian Campbell
2013-01-28 16:26 ` Is: PVH + ARM new hypercalls. Was: " Konrad Rzeszutek Wilk
2013-01-29 2:57 ` Mukesh Rathor
2013-01-29 10:48 ` Jan Beulich
2013-02-01 2:23 ` Mukesh Rathor
2013-02-01 16:24 ` Jan Beulich
2013-02-01 19:27 ` Mukesh Rathor
2013-02-04 10:31 ` Ian Campbell
2013-02-05 1:04 ` Mukesh Rathor
2013-02-05 7:53 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122151241.7ed034f4@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=JBeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.