All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH]: PVH: specify xen features strings cleany for PVH
Date: Mon, 21 Jan 2013 12:06:42 +0000	[thread overview]
Message-ID: <50FD3D6202000078000B7CE4@nat28.tlf.novell.com> (raw)
In-Reply-To: <20130118173503.71de0603@mantra.us.oracle.com>

>>> On 19.01.13 at 02:35, Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
> On Thu, 17 Jan 2013 22:22:47 -0500
> Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> 
>> Jan had some comments about that patch:
>> 
>> https://patchwork.kernel.org/patch/1745041/ 
>> 
>> Please fix it up so I can put it in the Linux tree.
> 
> Please see below.
> 
> Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
> 
> Thanks,
> Mukesh
> 
> 
> diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
> index 1a6bca1..543877d 100644
> --- a/arch/x86/xen/xen-head.S
> +++ b/arch/x86/xen/xen-head.S
> @@ -14,12 +14,17 @@
>  #include <asm/xen/interface.h>
>  
>  #ifdef CONFIG_XEN_X86_PVH
> -#define FEATURES_PVH "|writable_descriptor_tables" \
> -		     "|auto_translated_physmap" \
> -		     "|supervisor_mode_kernel" \
> -		     "|hvm_callback_vector"
> +#define XEN_FEATURES_STR .ascii  "!writable_page_tables"       \
> +                                 "|pae_pgdir_above_4gb"        \
> +                                 "|writable_descriptor_tables" \
> +                                 "|auto_translated_physmap"    \
> +                                 "|supervisor_mode_kernel"     \
> +                                 "|hvm_callback_vector"        \
> +                                 "\0"
>  #else
> -#define FEATURES_PVH /* Not supported */
> +#define XEN_FEATURES_STR .ascii "!writable_page_tables"        \
> +                                "|pae_pgdir_above_4gb"         \
> +                                 "\0"
>  #endif
>  
>  	__INIT
> @@ -104,7 +109,7 @@ NEXT_HYPERCALL(arch_6)
>  #endif
>  	ELFNOTE(Xen, XEN_ELFNOTE_ENTRY,          _ASM_PTR startup_xen)
>  	ELFNOTE(Xen, XEN_ELFNOTE_HYPERCALL_PAGE, _ASM_PTR hypercall_page)
> -	ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       .asciz 
> "!writable_page_tables|pae_pgdir_above_4gb"FEATURES_PVH)
> +        ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       XEN_FEATURES_STR)
>  	ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE,       .asciz "yes")
>  	ELFNOTE(Xen, XEN_ELFNOTE_LOADER,         .asciz "generic")
>  	ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID,

That's not really better. What I'd like you to do is keep the common
part common (i.e. not redundantly defined) and add the PVH-specific
bits (with what amounts to an empty string as the non-PVH
replacement) on top. Meaning you will likely want a mixture of
.ascii and .asciz.

Jan

  reply	other threads:[~2013-01-21 12:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-19  1:35 [PATCH]: PVH: specify xen features strings cleany for PVH Mukesh Rathor
2013-01-21 12:06 ` Jan Beulich [this message]
2013-01-22 23:12   ` Mukesh Rathor
2013-01-23  8:22     ` Jan Beulich
2013-01-23 22:43       ` Mukesh Rathor
2013-01-24  9:16         ` Jan Beulich
2013-01-24  9:27           ` Ian Campbell
2013-01-24 15:10             ` Konrad Rzeszutek Wilk
2013-01-24 23:13           ` Mukesh Rathor
2013-01-25  8:02             ` Jan Beulich
2013-01-25 10:11               ` Ian Campbell
2013-01-25 10:27                 ` Jan Beulich
2013-01-25 10:43                   ` Ian Campbell
2013-01-28 16:26                     ` Is: PVH + ARM new hypercalls. Was: " Konrad Rzeszutek Wilk
2013-01-29  2:57                       ` Mukesh Rathor
2013-01-29 10:48                         ` Jan Beulich
2013-02-01  2:23                           ` Mukesh Rathor
2013-02-01 16:24                             ` Jan Beulich
2013-02-01 19:27                               ` Mukesh Rathor
2013-02-04 10:31                                 ` Ian Campbell
2013-02-05  1:04                                   ` Mukesh Rathor
2013-02-05  7:53                                     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FD3D6202000078000B7CE4@nat28.tlf.novell.com \
    --to=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=mukesh.rathor@oracle.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.