All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH]: PVH: specify xen features strings cleany for PVH
Date: Fri, 25 Jan 2013 10:27:50 +0000	[thread overview]
Message-ID: <51026C3602000078000B9911@nat28.tlf.novell.com> (raw)
In-Reply-To: <1359108703.10051.5.camel@zakaz.uk.xensource.com>

>>> On 25.01.13 at 11:11, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Fri, 2013-01-25 at 08:02 +0000, Jan Beulich wrote:
>> >>> On 25.01.13 at 00:13, Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
>> > This is on top of what konrad already has in his linux tree so he
>> > can just apply it. Here's the final version of the file, just in case:
>> 
>> Looks okay to me, and I don't mind whether this
>> 
>> >         ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       .ascii 
>> > "!writable_page_tables|pae_pgdir_above_4gb"; .asciz PVH_FEATURES_STR);
>> 
>> is done using the .ascii/.asciz or the simpler string concatenation
>> way, as long as the latter works.
> 
> String concat in gas doesn't work like in C, you get a \0 at the join...

But this is going through the C preprocessor, and that one,
according to all I know, ought to concatenate adjacent strings.
But of course it depends between which translation phases
the preprocessor/compiler boundary is being set, so perhaps
doing it the .ascii/.asciz way is indeed the only universal one.

Jan

  reply	other threads:[~2013-01-25 10:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-19  1:35 [PATCH]: PVH: specify xen features strings cleany for PVH Mukesh Rathor
2013-01-21 12:06 ` Jan Beulich
2013-01-22 23:12   ` Mukesh Rathor
2013-01-23  8:22     ` Jan Beulich
2013-01-23 22:43       ` Mukesh Rathor
2013-01-24  9:16         ` Jan Beulich
2013-01-24  9:27           ` Ian Campbell
2013-01-24 15:10             ` Konrad Rzeszutek Wilk
2013-01-24 23:13           ` Mukesh Rathor
2013-01-25  8:02             ` Jan Beulich
2013-01-25 10:11               ` Ian Campbell
2013-01-25 10:27                 ` Jan Beulich [this message]
2013-01-25 10:43                   ` Ian Campbell
2013-01-28 16:26                     ` Is: PVH + ARM new hypercalls. Was: " Konrad Rzeszutek Wilk
2013-01-29  2:57                       ` Mukesh Rathor
2013-01-29 10:48                         ` Jan Beulich
2013-02-01  2:23                           ` Mukesh Rathor
2013-02-01 16:24                             ` Jan Beulich
2013-02-01 19:27                               ` Mukesh Rathor
2013-02-04 10:31                                 ` Ian Campbell
2013-02-05  1:04                                   ` Mukesh Rathor
2013-02-05  7:53                                     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51026C3602000078000B9911@nat28.tlf.novell.com \
    --to=jbeulich@suse.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.