* Re: ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! [not found] <5114c59c.TwL73aRElKJaIFRT%fengguang.wu@intel.com> @ 2013-02-08 9:51 ` Daniel Vetter 2013-02-08 15:37 ` Jesse Barnes 2013-02-11 22:27 ` Jesse Barnes 0 siblings, 2 replies; 4+ messages in thread From: Daniel Vetter @ 2013-02-08 9:51 UTC (permalink / raw) To: kbuild test robot; +Cc: Rafael J. Wysocki, intel-gfx On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot <fengguang.wu@intel.com> wrote: > tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly > head: 69f0d09dfd2d0579241389aee18ba50aa39d0de2 > commit: d6bc5b0603e5bea1b5a214d21c0aba8518f1a01f fb: add support for drivers not needing VT switch at suspend/resume time > date: 2 days ago > config: i386-randconfig-b031 (attached as .config) > > All error/warnings: > >>> ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! >>> ERROR: "pm_vt_switch_required" [drivers/video/fb.ko] undefined! I guess there's a select CONFIG_VT_CONSOLE_SLEEP missing somewhere ... Or at least a few stubs in headers if that's not selected. The offending config option itself was created itself to fix compile fail: commit 37cce26b32142f09a8967f6d238178af654b20de Author: H Hartley Sweeten <hartleys@visionengravers.com> Date: Wed Sep 21 22:47:55 2011 +0200 PM / VT: Cleanup #if defined uglyness and fix compile error Jesse, Rafael? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! 2013-02-08 9:51 ` ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! Daniel Vetter @ 2013-02-08 15:37 ` Jesse Barnes 2013-02-11 22:27 ` Jesse Barnes 1 sibling, 0 replies; 4+ messages in thread From: Jesse Barnes @ 2013-02-08 15:37 UTC (permalink / raw) To: Daniel Vetter; +Cc: Rafael J. Wysocki, intel-gfx, kbuild test robot On Fri, 8 Feb 2013 10:51:48 +0100 Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot > <fengguang.wu@intel.com> wrote: > > tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly > > head: 69f0d09dfd2d0579241389aee18ba50aa39d0de2 > > commit: d6bc5b0603e5bea1b5a214d21c0aba8518f1a01f fb: add support for drivers not needing VT switch at suspend/resume time > > date: 2 days ago > > config: i386-randconfig-b031 (attached as .config) > > > > All error/warnings: > > > >>> ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! > >>> ERROR: "pm_vt_switch_required" [drivers/video/fb.ko] undefined! > > I guess there's a select CONFIG_VT_CONSOLE_SLEEP missing somewhere ... > Or at least a few stubs in headers if that's not selected. The > offending config option itself was created itself to fix compile fail: > > commit 37cce26b32142f09a8967f6d238178af654b20de > Author: H Hartley Sweeten <hartleys@visionengravers.com> > Date: Wed Sep 21 22:47:55 2011 +0200 > > PM / VT: Cleanup #if defined uglyness and fix compile error > > Jesse, Rafael? Not sure... are there configs where power/console.c might be omitted or the whole file #ifdef'd out? -- Jesse Barnes, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! 2013-02-08 9:51 ` ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! Daniel Vetter 2013-02-08 15:37 ` Jesse Barnes @ 2013-02-11 22:27 ` Jesse Barnes 2013-02-11 22:35 ` Jesse Barnes 1 sibling, 1 reply; 4+ messages in thread From: Jesse Barnes @ 2013-02-11 22:27 UTC (permalink / raw) To: Daniel Vetter; +Cc: Rafael J. Wysocki, intel-gfx, kbuild test robot On Fri, 8 Feb 2013 10:51:48 +0100 Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot > <fengguang.wu@intel.com> wrote: > > tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly > > head: 69f0d09dfd2d0579241389aee18ba50aa39d0de2 > > commit: d6bc5b0603e5bea1b5a214d21c0aba8518f1a01f fb: add support for drivers not needing VT switch at suspend/resume time > > date: 2 days ago > > config: i386-randconfig-b031 (attached as .config) > > > > All error/warnings: > > > >>> ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! > >>> ERROR: "pm_vt_switch_required" [drivers/video/fb.ko] undefined! > > I guess there's a select CONFIG_VT_CONSOLE_SLEEP missing somewhere ... > Or at least a few stubs in headers if that's not selected. The > offending config option itself was created itself to fix compile fail: > > commit 37cce26b32142f09a8967f6d238178af654b20de > Author: H Hartley Sweeten <hartleys@visionengravers.com> > Date: Wed Sep 21 22:47:55 2011 +0200 > > PM / VT: Cleanup #if defined uglyness and fix compile error > > Jesse, Rafael? I think this should work, but I don't build with PM_SLEEP disabled... Jesse >From 0941d71fac64cb208b4cfb89a1698991c3902862 Mon Sep 17 00:00:00 2001 From: Jesse Barnes <jbarnes@virtuousgeek.org> Date: Mon, 11 Feb 2013 14:25:43 -0800 Subject: [PATCH] pm: provide stubs for PM VT console switch routines If PM_SLEEP is disabled, we need stub versions of these functions. Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> --- include/linux/pm.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/linux/pm.h b/include/linux/pm.h index 98310eb..02e404b 100644 --- a/include/linux/pm.h +++ b/include/linux/pm.h @@ -35,9 +35,18 @@ extern void (*pm_idle)(void); extern void (*pm_power_off)(void); extern void (*pm_power_off_prepare)(void); +#ifdef CONFIG_VT_CONSOLE_SLEEP struct device; /* we have a circular dep with device.h */ extern void pm_vt_switch_required(struct device *dev, bool required); extern void pm_vt_switch_unregister(struct device *dev); +#else +static inline void pm_vt_switch_required(struct device *dev, bool required) +{ +} +static inline void pm_vt_switch_unregister(struct device *dev) +{ +} +#endif /* CONFIG_VT_CONSOLE_SLEEP */ /* * Device power management -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! 2013-02-11 22:27 ` Jesse Barnes @ 2013-02-11 22:35 ` Jesse Barnes 0 siblings, 0 replies; 4+ messages in thread From: Jesse Barnes @ 2013-02-11 22:35 UTC (permalink / raw) To: Jesse Barnes Cc: Rafael J. Wysocki, Daniel Vetter, intel-gfx, kbuild test robot On Mon, 11 Feb 2013 14:27:08 -0800 Jesse Barnes <jbarnes@virtuousgeek.org> wrote: > On Fri, 8 Feb 2013 10:51:48 +0100 > Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > > On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot > > <fengguang.wu@intel.com> wrote: > > > tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly > > > head: 69f0d09dfd2d0579241389aee18ba50aa39d0de2 > > > commit: d6bc5b0603e5bea1b5a214d21c0aba8518f1a01f fb: add support for drivers not needing VT switch at suspend/resume time > > > date: 2 days ago > > > config: i386-randconfig-b031 (attached as .config) > > > > > > All error/warnings: > > > > > >>> ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! > > >>> ERROR: "pm_vt_switch_required" [drivers/video/fb.ko] undefined! > > > > I guess there's a select CONFIG_VT_CONSOLE_SLEEP missing somewhere ... > > Or at least a few stubs in headers if that's not selected. The > > offending config option itself was created itself to fix compile fail: > > > > commit 37cce26b32142f09a8967f6d238178af654b20de > > Author: H Hartley Sweeten <hartleys@visionengravers.com> > > Date: Wed Sep 21 22:47:55 2011 +0200 > > > > PM / VT: Cleanup #if defined uglyness and fix compile error > > > > Jesse, Rafael? > > I think this should work, but I don't build with PM_SLEEP disabled... > > Jesse > > From 0941d71fac64cb208b4cfb89a1698991c3902862 Mon Sep 17 00:00:00 2001 > From: Jesse Barnes <jbarnes@virtuousgeek.org> > Date: Mon, 11 Feb 2013 14:25:43 -0800 > Subject: [PATCH] pm: provide stubs for PM VT console switch routines > > If PM_SLEEP is disabled, we need stub versions of these functions. > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > --- > include/linux/pm.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/linux/pm.h b/include/linux/pm.h > index 98310eb..02e404b 100644 > --- a/include/linux/pm.h > +++ b/include/linux/pm.h > @@ -35,9 +35,18 @@ extern void (*pm_idle)(void); > extern void (*pm_power_off)(void); > extern void (*pm_power_off_prepare)(void); > > +#ifdef CONFIG_VT_CONSOLE_SLEEP > struct device; /* we have a circular dep with device.h */ > extern void pm_vt_switch_required(struct device *dev, bool required); > extern void pm_vt_switch_unregister(struct device *dev); > +#else > +static inline void pm_vt_switch_required(struct device *dev, bool required) > +{ > +} > +static inline void pm_vt_switch_unregister(struct device *dev) > +{ > +} > +#endif /* CONFIG_VT_CONSOLE_SLEEP */ > > /* > * Device power management Moving the struct device forward decl above the ifdef would be even better... -- Jesse Barnes, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-11 22:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <5114c59c.TwL73aRElKJaIFRT%fengguang.wu@intel.com>
2013-02-08 9:51 ` ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! Daniel Vetter
2013-02-08 15:37 ` Jesse Barnes
2013-02-11 22:27 ` Jesse Barnes
2013-02-11 22:35 ` Jesse Barnes
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.