Re: ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!

Re: ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!

[Daniel Vetter]

On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> tree:   git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly
> head:   69f0d09dfd2d0579241389aee18ba50aa39d0de2
> commit: d6bc5b0603e5bea1b5a214d21c0aba8518f1a01f fb: add support for drivers not needing VT switch at suspend/resume time
> date:   2 days ago
> config: i386-randconfig-b031 (attached as .config)
>
> All error/warnings:
>
>>> ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!
>>> ERROR: "pm_vt_switch_required" [drivers/video/fb.ko] undefined!

I guess there's a select CONFIG_VT_CONSOLE_SLEEP missing somewhere ...
Or at least a few stubs in headers if that's not selected. The
offending config option itself was created itself to fix compile fail:

commit 37cce26b32142f09a8967f6d238178af654b20de
Author: H Hartley Sweeten <hartleys@visionengravers.com>
Date:   Wed Sep 21 22:47:55 2011 +0200

    PM / VT: Cleanup #if defined uglyness and fix compile error

Jesse, Rafael?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!

[Jesse Barnes]

On Fri, 8 Feb 2013 10:51:48 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

> On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot
> <fengguang.wu@intel.com> wrote:
> > tree:   git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly
> > head:   69f0d09dfd2d0579241389aee18ba50aa39d0de2
> > commit: d6bc5b0603e5bea1b5a214d21c0aba8518f1a01f fb: add support for drivers not needing VT switch at suspend/resume time
> > date:   2 days ago
> > config: i386-randconfig-b031 (attached as .config)
> >
> > All error/warnings:
> >
> >>> ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!
> >>> ERROR: "pm_vt_switch_required" [drivers/video/fb.ko] undefined!
> 
> I guess there's a select CONFIG_VT_CONSOLE_SLEEP missing somewhere ...
> Or at least a few stubs in headers if that's not selected. The
> offending config option itself was created itself to fix compile fail:
> 
> commit 37cce26b32142f09a8967f6d238178af654b20de
> Author: H Hartley Sweeten <hartleys@visionengravers.com>
> Date:   Wed Sep 21 22:47:55 2011 +0200
> 
>     PM / VT: Cleanup #if defined uglyness and fix compile error
> 
> Jesse, Rafael?

Not sure... are there configs where power/console.c might be omitted or
the whole file #ifdef'd out?

-- 
Jesse Barnes, Intel Open Source Technology Center

Re: ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!

[Jesse Barnes]

On Fri, 8 Feb 2013 10:51:48 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

> On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot
> <fengguang.wu@intel.com> wrote:
> > tree:   git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly
> > head:   69f0d09dfd2d0579241389aee18ba50aa39d0de2
> > commit: d6bc5b0603e5bea1b5a214d21c0aba8518f1a01f fb: add support for drivers not needing VT switch at suspend/resume time
> > date:   2 days ago
> > config: i386-randconfig-b031 (attached as .config)
> >
> > All error/warnings:
> >
> >>> ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!
> >>> ERROR: "pm_vt_switch_required" [drivers/video/fb.ko] undefined!
> 
> I guess there's a select CONFIG_VT_CONSOLE_SLEEP missing somewhere ...
> Or at least a few stubs in headers if that's not selected. The
> offending config option itself was created itself to fix compile fail:
> 
> commit 37cce26b32142f09a8967f6d238178af654b20de
> Author: H Hartley Sweeten <hartleys@visionengravers.com>
> Date:   Wed Sep 21 22:47:55 2011 +0200
> 
>     PM / VT: Cleanup #if defined uglyness and fix compile error
> 
> Jesse, Rafael?

I think this should work, but I don't build with PM_SLEEP disabled...

Jesse

>From 0941d71fac64cb208b4cfb89a1698991c3902862 Mon Sep 17 00:00:00 2001
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Date: Mon, 11 Feb 2013 14:25:43 -0800
Subject: [PATCH] pm: provide stubs for PM VT console switch routines

If PM_SLEEP is disabled, we need stub versions of these functions.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 include/linux/pm.h |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/linux/pm.h b/include/linux/pm.h
index 98310eb..02e404b 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -35,9 +35,18 @@ extern void (*pm_idle)(void);
 extern void (*pm_power_off)(void);
 extern void (*pm_power_off_prepare)(void);
 
+#ifdef CONFIG_VT_CONSOLE_SLEEP
 struct device; /* we have a circular dep with device.h */
 extern void pm_vt_switch_required(struct device *dev, bool required);
 extern void pm_vt_switch_unregister(struct device *dev);
+#else
+static inline void pm_vt_switch_required(struct device *dev, bool required)
+{
+}
+static inline void pm_vt_switch_unregister(struct device *dev)
+{
+}
+#endif /* CONFIG_VT_CONSOLE_SLEEP */
 
 /*
  * Device power management
-- 
1.7.9.5

Re: ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!

[Jesse Barnes]

On Mon, 11 Feb 2013 14:27:08 -0800
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> On Fri, 8 Feb 2013 10:51:48 +0100
> Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> 
> > On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot
> > <fengguang.wu@intel.com> wrote:
> > > tree:   git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly
> > > head:   69f0d09dfd2d0579241389aee18ba50aa39d0de2
> > > commit: d6bc5b0603e5bea1b5a214d21c0aba8518f1a01f fb: add support for drivers not needing VT switch at suspend/resume time
> > > date:   2 days ago
> > > config: i386-randconfig-b031 (attached as .config)
> > >
> > > All error/warnings:
> > >
> > >>> ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!
> > >>> ERROR: "pm_vt_switch_required" [drivers/video/fb.ko] undefined!
> > 
> > I guess there's a select CONFIG_VT_CONSOLE_SLEEP missing somewhere ...
> > Or at least a few stubs in headers if that's not selected. The
> > offending config option itself was created itself to fix compile fail:
> > 
> > commit 37cce26b32142f09a8967f6d238178af654b20de
> > Author: H Hartley Sweeten <hartleys@visionengravers.com>
> > Date:   Wed Sep 21 22:47:55 2011 +0200
> > 
> >     PM / VT: Cleanup #if defined uglyness and fix compile error
> > 
> > Jesse, Rafael?
> 
> I think this should work, but I don't build with PM_SLEEP disabled...
> 
> Jesse
> 
> From 0941d71fac64cb208b4cfb89a1698991c3902862 Mon Sep 17 00:00:00 2001
> From: Jesse Barnes <jbarnes@virtuousgeek.org>
> Date: Mon, 11 Feb 2013 14:25:43 -0800
> Subject: [PATCH] pm: provide stubs for PM VT console switch routines
> 
> If PM_SLEEP is disabled, we need stub versions of these functions.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  include/linux/pm.h |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index 98310eb..02e404b 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -35,9 +35,18 @@ extern void (*pm_idle)(void);
>  extern void (*pm_power_off)(void);
>  extern void (*pm_power_off_prepare)(void);
>  
> +#ifdef CONFIG_VT_CONSOLE_SLEEP
>  struct device; /* we have a circular dep with device.h */
>  extern void pm_vt_switch_required(struct device *dev, bool required);
>  extern void pm_vt_switch_unregister(struct device *dev);
> +#else
> +static inline void pm_vt_switch_required(struct device *dev, bool required)
> +{
> +}
> +static inline void pm_vt_switch_unregister(struct device *dev)
> +{
> +}
> +#endif /* CONFIG_VT_CONSOLE_SLEEP */
>  
>  /*
>   * Device power management

Moving the struct device forward decl above the ifdef would be even
better...

-- 
Jesse Barnes, Intel Open Source Technology Center