[PATCH] Make test for gnuplot work with empty strings.

[PATCH] Make test for gnuplot work with empty strings.

[Martin Steigerwald]

When I launch fio_generate_plots on a system where gnuplot is not installed I
get this error :

$ fio_generate_plots test
Making bw logs
/usr/bin/fio_generate_plots: 42: /usr/bin/fio_generate_plots: -: not found

That's because the test checking whether gnuplot is installed is failing
because of an empty variable :
GNUPLOT=$(which gnuplot)
if [ ! -x $GNUPLOT ]; then
        echo You need gnuplot installed to generate graphs
        exit 1
fi

Indeed the command "test -x" is exiting with code 0.

To correct this we should enclose the variable with quotes :
if [ ! -x "$GNUPLOT" ]; then

Then the script is going into the test properly :
$ fio_generate_plots test
You need gnuplot installed to generate graphs

I copied problem description by Hervé from the Debian bug report below.

Fixes:
Bug#700580: /usr/bin/fio_generate_plots: -: not found
http://bugs.debian.org/700580

Reported-By: Hervé Werner <hwerner@score-md.com>
Tested-By: Hervé Werner <hwerner@score-md.com>
Tested-By: Martin Steigerwald <ms@teamix.de>
---
 fio_generate_plots |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fio_generate_plots b/fio_generate_plots
index 4285415..5e2febd 100755
--- a/fio_generate_plots
+++ b/fio_generate_plots
@@ -8,7 +8,7 @@ if [ "$1"x = "x" ]; then
 fi
 
 GNUPLOT=$(which gnuplot)
-if [ ! -x $GNUPLOT ]; then
+if [ ! -x "$GNUPLOT" ]; then
 	echo You need gnuplot installed to generate graphs
 	exit 1
 fi
-- 
1.7.10.4

Re: [PATCH] Make test for gnuplot work with empty strings.

[Jens Axboe]

On Mon, Mar 11 2013, Martin Steigerwald wrote:
> When I launch fio_generate_plots on a system where gnuplot is not installed I
> get this error :
> 
> $ fio_generate_plots test
> Making bw logs
> /usr/bin/fio_generate_plots: 42: /usr/bin/fio_generate_plots: -: not found
> 
> That's because the test checking whether gnuplot is installed is failing
> because of an empty variable :
> GNUPLOT=$(which gnuplot)
> if [ ! -x $GNUPLOT ]; then
>         echo You need gnuplot installed to generate graphs
>         exit 1
> fi
> 
> Indeed the command "test -x" is exiting with code 0.
> 
> To correct this we should enclose the variable with quotes :
> if [ ! -x "$GNUPLOT" ]; then
> 
> Then the script is going into the test properly :
> $ fio_generate_plots test
> You need gnuplot installed to generate graphs
> 
> I copied problem description by Herv� from the Debian bug report below.
> 
> Fixes:
> Bug#700580: /usr/bin/fio_generate_plots: -: not found
> http://bugs.debian.org/700580
> 
> Reported-By: Herv� Werner <hwerner@score-md.com>
> Tested-By: Herv� Werner <hwerner@score-md.com>
> Tested-By: Martin Steigerwald <ms@teamix.de>
> ---
>  fio_generate_plots |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fio_generate_plots b/fio_generate_plots
> index 4285415..5e2febd 100755
> --- a/fio_generate_plots
> +++ b/fio_generate_plots
> @@ -8,7 +8,7 @@ if [ "$1"x = "x" ]; then
>  fi
>  
>  GNUPLOT=$(which gnuplot)
> -if [ ! -x $GNUPLOT ]; then
> +if [ ! -x "$GNUPLOT" ]; then
>  	echo You need gnuplot installed to generate graphs
>  	exit 1
>  fi

Thanks, obviously correct :-)

-- 
Jens Axboe

Re: [PATCH] Make test for gnuplot work with empty strings.

[Martin Steigerwald]

----- Ursprüngliche Mail -----
> On Mon, Mar 11 2013, Martin Steigerwald wrote:
> > When I launch fio_generate_plots on a system where gnuplot is not installed
> > I
> > get this error :
> > 
> > $ fio_generate_plots test
> > Making bw logs
> > /usr/bin/fio_generate_plots: 42: /usr/bin/fio_generate_plots: -: not found
> > 
> > That's because the test checking whether gnuplot is installed is failing
> > because of an empty variable :
> > GNUPLOT=$(which gnuplot)
> > if [ ! -x $GNUPLOT ]; then
> >         echo You need gnuplot installed to generate graphs
> >         exit 1
> > fi
> > 
> > Indeed the command "test -x" is exiting with code 0.
> > 
> > To correct this we should enclose the variable with quotes :
> > if [ ! -x "$GNUPLOT" ]; then
> > 
> > Then the script is going into the test properly :
> > $ fio_generate_plots test
> > You need gnuplot installed to generate graphs
> > 
> > I copied problem description by Hervé from the Debian bug report below.
> > 
> > Fixes:
> > Bug#700580: /usr/bin/fio_generate_plots: -: not found
> > http://bugs.debian.org/700580
> > 
> > Reported-By: Hervé Werner <hwerner@score-md.com>
> > Tested-By: Hervé Werner <hwerner@score-md.com>
> > Tested-By: Martin Steigerwald <ms@teamix.de>
> > ---
> >  fio_generate_plots |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fio_generate_plots b/fio_generate_plots
> > index 4285415..5e2febd 100755
> > --- a/fio_generate_plots
> > +++ b/fio_generate_plots
> > @@ -8,7 +8,7 @@ if [ "$1"x = "x" ]; then
> >  fi
> >  
> >  GNUPLOT=$(which gnuplot)
> > -if [ ! -x $GNUPLOT ]; then
> > +if [ ! -x "$GNUPLOT" ]; then
> >  	echo You need gnuplot installed to generate graphs
> >  	exit 1
> >  fi
> 
> Thanks, obviously correct :-)

Still it doesn't seem you applied it as of

428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC

of git://git.kernel.dk/fio.git

Fixing locally in Debian package now.

Thaqnks,
-- 
Martin Steigerwald - teamix GmbH - http://www.teamix.de
gpg: 19E3 8D42 896F D004 08AC A0CA 1E10 C593 0399 AE90

Re: [PATCH] Make test for gnuplot work with empty strings.

[Erwan Velu]

On 05/08/2013 16:40, Martin Steigerwald wrote:
> Still it doesn't seem you applied it as of 
> 428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC of 
> git://git.kernel.dk/fio.git Fixing locally in Debian package now. 
> Thaqnks, 

Jens,

I've been putting this patch to my erwan/fixes branch I asked about merging.

That's commit 4e074cd1ad6a804ae646d52523e2dda69bbcabba assigned to 
"Author: Martin Steigerwald "<ms@teamix.de>

Cheers,
Erwan,

Re: [PATCH] Make test for gnuplot work with empty strings.

[Martin Steigerwald]

Dropped bug report from Cc.

----- Ursprüngliche Mail -----
> On 05/08/2013 16:40, Martin Steigerwald wrote:
> > Still it doesn't seem you applied it as of
> > 428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC of
> > git://git.kernel.dk/fio.git Fixing locally in Debian package now.
> > Thaqnks,
> 
> Jens,
> 
> I've been putting this patch to my erwan/fixes branch I asked about merging.
> 
> That's commit 4e074cd1ad6a804ae646d52523e2dda69bbcabba assigned to
> "Author: Martin Steigerwald "<ms@teamix.de>

Thanks, Erwan.

Jens, any plans for a fio 2.12 release?

Anyway, I already submitted 2.11 as request for sponsorship with the bug fixed in package.

Ciao,
-- 
Martin Steigerwald - teamix GmbH - http://www.teamix.de
gpg: 19E3 8D42 896F D004 08AC A0CA 1E10 C593 0399 AE90

Re: [PATCH] Make test for gnuplot work with empty strings.

[Erwan Velu]

On 05/08/2013 17:07, Martin Steigerwald wrote:

[...]
> Thanks, Erwan.
>
> Jens, any plans for a fio 2.12 release?
>
> Anyway, I already submitted 2.11 as request for sponsorship with the bug fixed in package.
>
> Ciao,
So I've been removing mine since Jens already did it :p

Cheers,

Re: [PATCH] Make test for gnuplot work with empty strings.

[Jens Axboe]

On Mon, Aug 05 2013, Martin Steigerwald wrote:
> Dropped bug report from Cc.
> 
> ----- Urspr�ngliche Mail -----
> > On 05/08/2013 16:40, Martin Steigerwald wrote:
> > > Still it doesn't seem you applied it as of
> > > 428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC of
> > > git://git.kernel.dk/fio.git Fixing locally in Debian package now.
> > > Thaqnks,
> > 
> > Jens,
> > 
> > I've been putting this patch to my erwan/fixes branch I asked about merging.
> > 
> > That's commit 4e074cd1ad6a804ae646d52523e2dda69bbcabba assigned to
> > "Author: Martin Steigerwald "<ms@teamix.de>
> 
> Thanks, Erwan.
> 
> Jens, any plans for a fio 2.12 release?

Yes, will be there soon. I just need to fully verify some recent
changes, then it can be tagged and "shipped". Sometime this week.

-- 
Jens Axboe

Re: [PATCH] Make test for gnuplot work with empty strings.

[Martin Steigerwald]

----- Ursprüngliche Mail -----
> On Mon, Aug 05 2013, Martin Steigerwald wrote:
> > Dropped bug report from Cc.
> > 
> > ----- Ursprüngliche Mail -----
> > > On 05/08/2013 16:40, Martin Steigerwald wrote:
> > > > Still it doesn't seem you applied it as of
> > > > 428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC of
> > > > git://git.kernel.dk/fio.git Fixing locally in Debian package now.
> > > > Thaqnks,
> > > 
> > > Jens,
> > > 
> > > I've been putting this patch to my erwan/fixes branch I asked about
> > > merging.
> > > 
> > > That's commit 4e074cd1ad6a804ae646d52523e2dda69bbcabba assigned to
> > > "Author: Martin Steigerwald "<ms@teamix.de>
> > 
> > Thanks, Erwan.
> > 
> > Jens, any plans for a fio 2.12 release?
> 
> Yes, will be there soon. I just need to fully verify some recent
> changes, then it can be tagged and "shipped". Sometime this week.

Well if it comes before someone responds to RFS, I just update the RFS once again. :)

Ciao,
-- 
Martin Steigerwald - teamix GmbH - http://www.teamix.de
gpg: 19E3 8D42 896F D004 08AC A0CA 1E10 C593 0399 AE90

Re: [PATCH] Make test for gnuplot work with empty strings.

[Jens Axboe]

On 08/05/2013 08:40 AM, Martin Steigerwald wrote:
> ----- Ursprüngliche Mail -----
>> On Mon, Mar 11 2013, Martin Steigerwald wrote:
>>> When I launch fio_generate_plots on a system where gnuplot is not installed
>>> I
>>> get this error :
>>>
>>> $ fio_generate_plots test
>>> Making bw logs
>>> /usr/bin/fio_generate_plots: 42: /usr/bin/fio_generate_plots: -: not found
>>>
>>> That's because the test checking whether gnuplot is installed is failing
>>> because of an empty variable :
>>> GNUPLOT=$(which gnuplot)
>>> if [ ! -x $GNUPLOT ]; then
>>>         echo You need gnuplot installed to generate graphs
>>>         exit 1
>>> fi
>>>
>>> Indeed the command "test -x" is exiting with code 0.
>>>
>>> To correct this we should enclose the variable with quotes :
>>> if [ ! -x "$GNUPLOT" ]; then
>>>
>>> Then the script is going into the test properly :
>>> $ fio_generate_plots test
>>> You need gnuplot installed to generate graphs
>>>
>>> I copied problem description by Hervé from the Debian bug report below.
>>>
>>> Fixes:
>>> Bug#700580: /usr/bin/fio_generate_plots: -: not found
>>> http://bugs.debian.org/700580
>>>
>>> Reported-By: Hervé Werner <hwerner@score-md.com>
>>> Tested-By: Hervé Werner <hwerner@score-md.com>
>>> Tested-By: Martin Steigerwald <ms@teamix.de>
>>> ---
>>>  fio_generate_plots |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fio_generate_plots b/fio_generate_plots
>>> index 4285415..5e2febd 100755
>>> --- a/fio_generate_plots
>>> +++ b/fio_generate_plots
>>> @@ -8,7 +8,7 @@ if [ "$1"x = "x" ]; then
>>>  fi
>>>  
>>>  GNUPLOT=$(which gnuplot)
>>> -if [ ! -x $GNUPLOT ]; then
>>> +if [ ! -x "$GNUPLOT" ]; then
>>>  	echo You need gnuplot installed to generate graphs
>>>  	exit 1
>>>  fi
>>
>> Thanks, obviously correct :-)
> 
> Still it doesn't seem you applied it as of
> 
> 428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC
> 
> of git://git.kernel.dk/fio.git
> 
> Fixing locally in Debian package now.

Weird, I must have done it on the old workstation (that is still in
transit) and forgot to push it out. Rectified now!

-- 
Jens Axboe