* [PATCH] Make test for gnuplot work with empty strings.
@ 2013-03-11 15:22 Martin Steigerwald
2013-03-12 12:16 ` Jens Axboe
0 siblings, 1 reply; 9+ messages in thread
From: Martin Steigerwald @ 2013-03-11 15:22 UTC (permalink / raw)
To: fio, 700580
When I launch fio_generate_plots on a system where gnuplot is not installed I
get this error :
$ fio_generate_plots test
Making bw logs
/usr/bin/fio_generate_plots: 42: /usr/bin/fio_generate_plots: -: not found
That's because the test checking whether gnuplot is installed is failing
because of an empty variable :
GNUPLOT=$(which gnuplot)
if [ ! -x $GNUPLOT ]; then
echo You need gnuplot installed to generate graphs
exit 1
fi
Indeed the command "test -x" is exiting with code 0.
To correct this we should enclose the variable with quotes :
if [ ! -x "$GNUPLOT" ]; then
Then the script is going into the test properly :
$ fio_generate_plots test
You need gnuplot installed to generate graphs
I copied problem description by Hervé from the Debian bug report below.
Fixes:
Bug#700580: /usr/bin/fio_generate_plots: -: not found
http://bugs.debian.org/700580
Reported-By: Hervé Werner <hwerner@score-md.com>
Tested-By: Hervé Werner <hwerner@score-md.com>
Tested-By: Martin Steigerwald <ms@teamix.de>
---
fio_generate_plots | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fio_generate_plots b/fio_generate_plots
index 4285415..5e2febd 100755
--- a/fio_generate_plots
+++ b/fio_generate_plots
@@ -8,7 +8,7 @@ if [ "$1"x = "x" ]; then
fi
GNUPLOT=$(which gnuplot)
-if [ ! -x $GNUPLOT ]; then
+if [ ! -x "$GNUPLOT" ]; then
echo You need gnuplot installed to generate graphs
exit 1
fi
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] Make test for gnuplot work with empty strings.
2013-03-11 15:22 [PATCH] Make test for gnuplot work with empty strings Martin Steigerwald
@ 2013-03-12 12:16 ` Jens Axboe
2013-08-05 14:40 ` Martin Steigerwald
0 siblings, 1 reply; 9+ messages in thread
From: Jens Axboe @ 2013-03-12 12:16 UTC (permalink / raw)
To: Martin Steigerwald; +Cc: fio, 700580
On Mon, Mar 11 2013, Martin Steigerwald wrote:
> When I launch fio_generate_plots on a system where gnuplot is not installed I
> get this error :
>
> $ fio_generate_plots test
> Making bw logs
> /usr/bin/fio_generate_plots: 42: /usr/bin/fio_generate_plots: -: not found
>
> That's because the test checking whether gnuplot is installed is failing
> because of an empty variable :
> GNUPLOT=$(which gnuplot)
> if [ ! -x $GNUPLOT ]; then
> echo You need gnuplot installed to generate graphs
> exit 1
> fi
>
> Indeed the command "test -x" is exiting with code 0.
>
> To correct this we should enclose the variable with quotes :
> if [ ! -x "$GNUPLOT" ]; then
>
> Then the script is going into the test properly :
> $ fio_generate_plots test
> You need gnuplot installed to generate graphs
>
> I copied problem description by Herv� from the Debian bug report below.
>
> Fixes:
> Bug#700580: /usr/bin/fio_generate_plots: -: not found
> http://bugs.debian.org/700580
>
> Reported-By: Herv� Werner <hwerner@score-md.com>
> Tested-By: Herv� Werner <hwerner@score-md.com>
> Tested-By: Martin Steigerwald <ms@teamix.de>
> ---
> fio_generate_plots | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fio_generate_plots b/fio_generate_plots
> index 4285415..5e2febd 100755
> --- a/fio_generate_plots
> +++ b/fio_generate_plots
> @@ -8,7 +8,7 @@ if [ "$1"x = "x" ]; then
> fi
>
> GNUPLOT=$(which gnuplot)
> -if [ ! -x $GNUPLOT ]; then
> +if [ ! -x "$GNUPLOT" ]; then
> echo You need gnuplot installed to generate graphs
> exit 1
> fi
Thanks, obviously correct :-)
--
Jens Axboe
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Make test for gnuplot work with empty strings.
2013-03-12 12:16 ` Jens Axboe
@ 2013-08-05 14:40 ` Martin Steigerwald
2013-08-05 14:48 ` Erwan Velu
2013-08-05 14:58 ` Jens Axboe
0 siblings, 2 replies; 9+ messages in thread
From: Martin Steigerwald @ 2013-08-05 14:40 UTC (permalink / raw)
To: Jens Axboe; +Cc: fio, 700580
----- Ursprüngliche Mail -----
> On Mon, Mar 11 2013, Martin Steigerwald wrote:
> > When I launch fio_generate_plots on a system where gnuplot is not installed
> > I
> > get this error :
> >
> > $ fio_generate_plots test
> > Making bw logs
> > /usr/bin/fio_generate_plots: 42: /usr/bin/fio_generate_plots: -: not found
> >
> > That's because the test checking whether gnuplot is installed is failing
> > because of an empty variable :
> > GNUPLOT=$(which gnuplot)
> > if [ ! -x $GNUPLOT ]; then
> > echo You need gnuplot installed to generate graphs
> > exit 1
> > fi
> >
> > Indeed the command "test -x" is exiting with code 0.
> >
> > To correct this we should enclose the variable with quotes :
> > if [ ! -x "$GNUPLOT" ]; then
> >
> > Then the script is going into the test properly :
> > $ fio_generate_plots test
> > You need gnuplot installed to generate graphs
> >
> > I copied problem description by Hervé from the Debian bug report below.
> >
> > Fixes:
> > Bug#700580: /usr/bin/fio_generate_plots: -: not found
> > http://bugs.debian.org/700580
> >
> > Reported-By: Hervé Werner <hwerner@score-md.com>
> > Tested-By: Hervé Werner <hwerner@score-md.com>
> > Tested-By: Martin Steigerwald <ms@teamix.de>
> > ---
> > fio_generate_plots | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fio_generate_plots b/fio_generate_plots
> > index 4285415..5e2febd 100755
> > --- a/fio_generate_plots
> > +++ b/fio_generate_plots
> > @@ -8,7 +8,7 @@ if [ "$1"x = "x" ]; then
> > fi
> >
> > GNUPLOT=$(which gnuplot)
> > -if [ ! -x $GNUPLOT ]; then
> > +if [ ! -x "$GNUPLOT" ]; then
> > echo You need gnuplot installed to generate graphs
> > exit 1
> > fi
>
> Thanks, obviously correct :-)
Still it doesn't seem you applied it as of
428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC
of git://git.kernel.dk/fio.git
Fixing locally in Debian package now.
Thaqnks,
--
Martin Steigerwald - teamix GmbH - http://www.teamix.de
gpg: 19E3 8D42 896F D004 08AC A0CA 1E10 C593 0399 AE90
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Make test for gnuplot work with empty strings.
2013-08-05 14:40 ` Martin Steigerwald
@ 2013-08-05 14:48 ` Erwan Velu
2013-08-05 15:07 ` Martin Steigerwald
2013-08-05 14:58 ` Jens Axboe
1 sibling, 1 reply; 9+ messages in thread
From: Erwan Velu @ 2013-08-05 14:48 UTC (permalink / raw)
To: Martin Steigerwald; +Cc: Jens Axboe, fio, 700580
On 05/08/2013 16:40, Martin Steigerwald wrote:
> Still it doesn't seem you applied it as of
> 428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC of
> git://git.kernel.dk/fio.git Fixing locally in Debian package now.
> Thaqnks,
Jens,
I've been putting this patch to my erwan/fixes branch I asked about merging.
That's commit 4e074cd1ad6a804ae646d52523e2dda69bbcabba assigned to
"Author: Martin Steigerwald "<ms@teamix.de>
Cheers,
Erwan,
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Make test for gnuplot work with empty strings.
2013-08-05 14:40 ` Martin Steigerwald
2013-08-05 14:48 ` Erwan Velu
@ 2013-08-05 14:58 ` Jens Axboe
1 sibling, 0 replies; 9+ messages in thread
From: Jens Axboe @ 2013-08-05 14:58 UTC (permalink / raw)
To: Martin Steigerwald; +Cc: fio, 700580
On 08/05/2013 08:40 AM, Martin Steigerwald wrote:
> ----- Ursprüngliche Mail -----
>> On Mon, Mar 11 2013, Martin Steigerwald wrote:
>>> When I launch fio_generate_plots on a system where gnuplot is not installed
>>> I
>>> get this error :
>>>
>>> $ fio_generate_plots test
>>> Making bw logs
>>> /usr/bin/fio_generate_plots: 42: /usr/bin/fio_generate_plots: -: not found
>>>
>>> That's because the test checking whether gnuplot is installed is failing
>>> because of an empty variable :
>>> GNUPLOT=$(which gnuplot)
>>> if [ ! -x $GNUPLOT ]; then
>>> echo You need gnuplot installed to generate graphs
>>> exit 1
>>> fi
>>>
>>> Indeed the command "test -x" is exiting with code 0.
>>>
>>> To correct this we should enclose the variable with quotes :
>>> if [ ! -x "$GNUPLOT" ]; then
>>>
>>> Then the script is going into the test properly :
>>> $ fio_generate_plots test
>>> You need gnuplot installed to generate graphs
>>>
>>> I copied problem description by Hervé from the Debian bug report below.
>>>
>>> Fixes:
>>> Bug#700580: /usr/bin/fio_generate_plots: -: not found
>>> http://bugs.debian.org/700580
>>>
>>> Reported-By: Hervé Werner <hwerner@score-md.com>
>>> Tested-By: Hervé Werner <hwerner@score-md.com>
>>> Tested-By: Martin Steigerwald <ms@teamix.de>
>>> ---
>>> fio_generate_plots | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fio_generate_plots b/fio_generate_plots
>>> index 4285415..5e2febd 100755
>>> --- a/fio_generate_plots
>>> +++ b/fio_generate_plots
>>> @@ -8,7 +8,7 @@ if [ "$1"x = "x" ]; then
>>> fi
>>>
>>> GNUPLOT=$(which gnuplot)
>>> -if [ ! -x $GNUPLOT ]; then
>>> +if [ ! -x "$GNUPLOT" ]; then
>>> echo You need gnuplot installed to generate graphs
>>> exit 1
>>> fi
>>
>> Thanks, obviously correct :-)
>
> Still it doesn't seem you applied it as of
>
> 428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC
>
> of git://git.kernel.dk/fio.git
>
> Fixing locally in Debian package now.
Weird, I must have done it on the old workstation (that is still in
transit) and forgot to push it out. Rectified now!
--
Jens Axboe
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Make test for gnuplot work with empty strings.
2013-08-05 14:48 ` Erwan Velu
@ 2013-08-05 15:07 ` Martin Steigerwald
2013-08-05 15:12 ` Erwan Velu
2013-08-05 15:28 ` Jens Axboe
0 siblings, 2 replies; 9+ messages in thread
From: Martin Steigerwald @ 2013-08-05 15:07 UTC (permalink / raw)
To: Erwan Velu; +Cc: Jens Axboe, fio
Dropped bug report from Cc.
----- Ursprüngliche Mail -----
> On 05/08/2013 16:40, Martin Steigerwald wrote:
> > Still it doesn't seem you applied it as of
> > 428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC of
> > git://git.kernel.dk/fio.git Fixing locally in Debian package now.
> > Thaqnks,
>
> Jens,
>
> I've been putting this patch to my erwan/fixes branch I asked about merging.
>
> That's commit 4e074cd1ad6a804ae646d52523e2dda69bbcabba assigned to
> "Author: Martin Steigerwald "<ms@teamix.de>
Thanks, Erwan.
Jens, any plans for a fio 2.12 release?
Anyway, I already submitted 2.11 as request for sponsorship with the bug fixed in package.
Ciao,
--
Martin Steigerwald - teamix GmbH - http://www.teamix.de
gpg: 19E3 8D42 896F D004 08AC A0CA 1E10 C593 0399 AE90
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Make test for gnuplot work with empty strings.
2013-08-05 15:07 ` Martin Steigerwald
@ 2013-08-05 15:12 ` Erwan Velu
2013-08-05 15:28 ` Jens Axboe
1 sibling, 0 replies; 9+ messages in thread
From: Erwan Velu @ 2013-08-05 15:12 UTC (permalink / raw)
To: Martin Steigerwald; +Cc: Jens Axboe, fio
On 05/08/2013 17:07, Martin Steigerwald wrote:
[...]
> Thanks, Erwan.
>
> Jens, any plans for a fio 2.12 release?
>
> Anyway, I already submitted 2.11 as request for sponsorship with the bug fixed in package.
>
> Ciao,
So I've been removing mine since Jens already did it :p
Cheers,
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Make test for gnuplot work with empty strings.
2013-08-05 15:07 ` Martin Steigerwald
2013-08-05 15:12 ` Erwan Velu
@ 2013-08-05 15:28 ` Jens Axboe
2013-08-05 15:32 ` Martin Steigerwald
1 sibling, 1 reply; 9+ messages in thread
From: Jens Axboe @ 2013-08-05 15:28 UTC (permalink / raw)
To: Martin Steigerwald; +Cc: Erwan Velu, fio
On Mon, Aug 05 2013, Martin Steigerwald wrote:
> Dropped bug report from Cc.
>
> ----- Urspr�ngliche Mail -----
> > On 05/08/2013 16:40, Martin Steigerwald wrote:
> > > Still it doesn't seem you applied it as of
> > > 428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC of
> > > git://git.kernel.dk/fio.git Fixing locally in Debian package now.
> > > Thaqnks,
> >
> > Jens,
> >
> > I've been putting this patch to my erwan/fixes branch I asked about merging.
> >
> > That's commit 4e074cd1ad6a804ae646d52523e2dda69bbcabba assigned to
> > "Author: Martin Steigerwald "<ms@teamix.de>
>
> Thanks, Erwan.
>
> Jens, any plans for a fio 2.12 release?
Yes, will be there soon. I just need to fully verify some recent
changes, then it can be tagged and "shipped". Sometime this week.
--
Jens Axboe
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Make test for gnuplot work with empty strings.
2013-08-05 15:28 ` Jens Axboe
@ 2013-08-05 15:32 ` Martin Steigerwald
0 siblings, 0 replies; 9+ messages in thread
From: Martin Steigerwald @ 2013-08-05 15:32 UTC (permalink / raw)
To: Jens Axboe; +Cc: Erwan Velu, fio
----- Ursprüngliche Mail -----
> On Mon, Aug 05 2013, Martin Steigerwald wrote:
> > Dropped bug report from Cc.
> >
> > ----- Ursprüngliche Mail -----
> > > On 05/08/2013 16:40, Martin Steigerwald wrote:
> > > > Still it doesn't seem you applied it as of
> > > > 428b4f6ba681dbb40c8e2213d0c6ae8f8049dcd5ESC of
> > > > git://git.kernel.dk/fio.git Fixing locally in Debian package now.
> > > > Thaqnks,
> > >
> > > Jens,
> > >
> > > I've been putting this patch to my erwan/fixes branch I asked about
> > > merging.
> > >
> > > That's commit 4e074cd1ad6a804ae646d52523e2dda69bbcabba assigned to
> > > "Author: Martin Steigerwald "<ms@teamix.de>
> >
> > Thanks, Erwan.
> >
> > Jens, any plans for a fio 2.12 release?
>
> Yes, will be there soon. I just need to fully verify some recent
> changes, then it can be tagged and "shipped". Sometime this week.
Well if it comes before someone responds to RFS, I just update the RFS once again. :)
Ciao,
--
Martin Steigerwald - teamix GmbH - http://www.teamix.de
gpg: 19E3 8D42 896F D004 08AC A0CA 1E10 C593 0399 AE90
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-08-05 15:32 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-11 15:22 [PATCH] Make test for gnuplot work with empty strings Martin Steigerwald
2013-03-12 12:16 ` Jens Axboe
2013-08-05 14:40 ` Martin Steigerwald
2013-08-05 14:48 ` Erwan Velu
2013-08-05 15:07 ` Martin Steigerwald
2013-08-05 15:12 ` Erwan Velu
2013-08-05 15:28 ` Jens Axboe
2013-08-05 15:32 ` Martin Steigerwald
2013-08-05 14:58 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.