All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Tony Lindgren <tony@atomide.com>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	Russell King <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 03/10] ARM: smp_twd: Divorce smp_twd from local timer API
Date: Thu, 28 Mar 2013 15:22:55 +0000	[thread overview]
Message-ID: <20130328152255.GD30477@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1363198676-30417-4-git-send-email-sboyd@codeaurora.org>

This works on my A9x4 coretile, bringing CPUs up and down via
/sys/devices/system/cpu/*/online, so:

Tested-by: Mark Rutland <mark.rutland@arm.com>

Otherwise, is there any reason we couldn't now use the twd driver on a UP
system? Or would the overhead of handling frequency change make this pointless?

On Wed, Mar 13, 2013 at 06:17:49PM +0000, Stephen Boyd wrote:
> Separate the smp_twd timers from the local timer API. This will
> allow us to remove ARM local timer support in the near future and
> gets us closer to moving this driver to drivers/clocksource.
> 
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> Changes since v2:
>  * Fix booting on qemu and omap
> 
>  arch/arm/Kconfig          |  2 +-
>  arch/arm/kernel/smp_twd.c | 64 +++++++++++++++++++++++++++++++----------------
>  2 files changed, 44 insertions(+), 22 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 5b71469..5ad2ccf 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1527,6 +1527,7 @@ config SMP
>  	depends on HAVE_SMP
>  	depends on MMU
>  	select HAVE_ARM_SCU if !ARCH_MSM_SCORPIONMP
> +	select HAVE_ARM_TWD if (!ARCH_MSM_SCORPIONMP && !EXYNOS4_MCT)

Could you not depend on your "Push selects for TWD/SCU into machine entries"
for this?

Mark.

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 03/10] ARM: smp_twd: Divorce smp_twd from local timer API
Date: Thu, 28 Mar 2013 15:22:55 +0000	[thread overview]
Message-ID: <20130328152255.GD30477@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1363198676-30417-4-git-send-email-sboyd@codeaurora.org>

This works on my A9x4 coretile, bringing CPUs up and down via
/sys/devices/system/cpu/*/online, so:

Tested-by: Mark Rutland <mark.rutland@arm.com>

Otherwise, is there any reason we couldn't now use the twd driver on a UP
system? Or would the overhead of handling frequency change make this pointless?

On Wed, Mar 13, 2013 at 06:17:49PM +0000, Stephen Boyd wrote:
> Separate the smp_twd timers from the local timer API. This will
> allow us to remove ARM local timer support in the near future and
> gets us closer to moving this driver to drivers/clocksource.
> 
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> Changes since v2:
>  * Fix booting on qemu and omap
> 
>  arch/arm/Kconfig          |  2 +-
>  arch/arm/kernel/smp_twd.c | 64 +++++++++++++++++++++++++++++++----------------
>  2 files changed, 44 insertions(+), 22 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 5b71469..5ad2ccf 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1527,6 +1527,7 @@ config SMP
>  	depends on HAVE_SMP
>  	depends on MMU
>  	select HAVE_ARM_SCU if !ARCH_MSM_SCORPIONMP
> +	select HAVE_ARM_TWD if (!ARCH_MSM_SCORPIONMP && !EXYNOS4_MCT)

Could you not depend on your "Push selects for TWD/SCU into machine entries"
for this?

Mark.

  reply	other threads:[~2013-03-28 15:22 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 18:17 [PATCHv3 00/10] Remove ARM local timer API Stephen Boyd
2013-03-13 18:17 ` Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 01/10] clocksource: add generic dummy timer driver Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-21 18:09   ` Mark Rutland
2013-03-21 18:09     ` Mark Rutland
2013-03-21 18:09     ` Mark Rutland
2013-03-21 18:13     ` Stephen Boyd
2013-03-21 18:13       ` Stephen Boyd
2013-03-21 18:13       ` Stephen Boyd
2013-03-22 18:03       ` Mark Rutland
2013-03-22 18:03         ` Mark Rutland
2013-03-22 18:03         ` Mark Rutland
2013-03-25 16:49         ` Stephen Boyd
2013-03-25 16:49           ` Stephen Boyd
2013-03-25 16:49           ` Stephen Boyd
2013-03-25 18:00           ` Mark Rutland
2013-03-25 18:00             ` Mark Rutland
2013-03-25 18:00             ` Mark Rutland
2013-03-25 20:47             ` Thomas Gleixner
2013-03-25 20:47               ` Thomas Gleixner
2013-03-25 20:47               ` Thomas Gleixner
2013-03-26 15:26               ` Mark Rutland
2013-03-26 15:26                 ` Mark Rutland
2013-03-26 15:26                 ` Mark Rutland
2013-03-26  2:14             ` Stephen Boyd
2013-03-26  2:14               ` Stephen Boyd
2013-03-26  2:14               ` Stephen Boyd
2013-03-26 11:28               ` Mark Rutland
2013-03-26 11:28                 ` Mark Rutland
2013-03-26 11:28                 ` Mark Rutland
2013-04-05  1:46                 ` Stephen Boyd
2013-04-05  1:46                   ` Stephen Boyd
2013-04-05  1:46                   ` Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 02/10] ARM: smp: Remove duplicate dummy timer implementation Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 03/10] ARM: smp_twd: Divorce smp_twd from local timer API Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-28 15:22   ` Mark Rutland [this message]
2013-03-28 15:22     ` Mark Rutland
2013-03-28 15:22     ` Mark Rutland
2013-03-28 20:09     ` Stephen Boyd
2013-03-28 20:09       ` Stephen Boyd
2013-03-28 20:09       ` Stephen Boyd
2013-04-02  8:41       ` Mark Rutland
2013-04-02  8:41         ` Mark Rutland
2013-04-02  8:41         ` Mark Rutland
2013-03-13 18:17 ` [PATCHv3 04/10] ARM: OMAP2+: Divorce " Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 05/10] ARM: EXYNOS4: Divorce mct " Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 06/10] ARM: PRIMA2: Divorce timer-marco " Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 07/10] ARM: msm: Divorce msm_timer " Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 08/10] clocksource: time-armada-370-xp: Fix sparse warning Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-20 17:06   ` Gregory CLEMENT
2013-03-20 17:06     ` Gregory CLEMENT
2013-03-13 18:17 ` [PATCHv3 09/10] clocksource: time-armada-370-xp: Divorce from local timer API Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd
2013-03-20 17:09   ` Gregory CLEMENT
2013-03-20 17:09     ` Gregory CLEMENT
2013-03-20 17:20     ` Stephen Boyd
2013-03-20 17:20       ` Stephen Boyd
2013-03-20 17:26       ` Gregory CLEMENT
2013-03-20 17:26         ` Gregory CLEMENT
2013-03-20 17:44         ` Gregory CLEMENT
2013-03-20 17:44           ` Gregory CLEMENT
2013-03-20 18:00           ` Stephen Boyd
2013-03-20 18:00             ` Stephen Boyd
2013-03-20 17:21     ` Gregory CLEMENT
2013-03-20 17:21       ` Gregory CLEMENT
2013-03-13 18:17 ` [PATCHv3 10/10] ARM: smp: Remove " Stephen Boyd
2013-03-13 18:17   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130328152255.GD30477@e106331-lin.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sboyd@codeaurora.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.