* [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails
@ 2013-03-31 15:07 Axel Lin
2013-04-02 7:14 ` Peter Ujfalusi
2013-04-02 9:40 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-03-31 15:07 UTC (permalink / raw)
To: Thierry Reding; +Cc: Peter Ujfalusi, linux-kernel
Return proper error instead of 0 if twl6030_pwm_enable() fails.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pwm/pwm-twl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
index ee7fa5d..2782001 100644
--- a/drivers/pwm/pwm-twl.c
+++ b/drivers/pwm/pwm-twl.c
@@ -248,7 +248,7 @@ static int twl6030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
twl->twl6030_toggle3 = val;
out:
mutex_unlock(&twl->mutex);
- return 0;
+ return ret;
}
static void twl6030_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails
2013-03-31 15:07 [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails Axel Lin
@ 2013-04-02 7:14 ` Peter Ujfalusi
2013-04-02 9:40 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2013-04-02 7:14 UTC (permalink / raw)
To: Axel Lin; +Cc: Thierry Reding, linux-kernel
On 03/31/2013 05:07 PM, Axel Lin wrote:
> Return proper error instead of 0 if twl6030_pwm_enable() fails.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/pwm/pwm-twl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
> index ee7fa5d..2782001 100644
> --- a/drivers/pwm/pwm-twl.c
> +++ b/drivers/pwm/pwm-twl.c
> @@ -248,7 +248,7 @@ static int twl6030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
> twl->twl6030_toggle3 = val;
> out:
> mutex_unlock(&twl->mutex);
> - return 0;
> + return ret;
> }
>
> static void twl6030_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
>
--
Péter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails
2013-03-31 15:07 [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails Axel Lin
2013-04-02 7:14 ` Peter Ujfalusi
@ 2013-04-02 9:40 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2013-04-02 9:40 UTC (permalink / raw)
To: Axel Lin; +Cc: Peter Ujfalusi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
On Sun, Mar 31, 2013 at 11:07:30PM +0800, Axel Lin wrote:
> Return proper error instead of 0 if twl6030_pwm_enable() fails.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-twl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-02 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-31 15:07 [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails Axel Lin
2013-04-02 7:14 ` Peter Ujfalusi
2013-04-02 9:40 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.