All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Peter De Schrijver
	<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Thierry Reding
	<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] clk: tegra: Export peripheral reset functions
Date: Tue, 02 Apr 2013 10:35:29 -0700	[thread overview]
Message-ID: <20130402173529.8177.49420@quantum> (raw)
In-Reply-To: <20130402093426.GZ18519-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>

Quoting Peter De Schrijver (2013-04-02 02:34:26)
> On Thu, Mar 28, 2013 at 09:31:27PM +0100, Thierry Reding wrote:
> > The tegra_periph_reset_assert() and tegra_periph_reset_deassert()
> > functions can be used by drivers to reset peripherals. In order to allow
> > such drivers to be built as modules, export the functions.
> > 
> > Note that this restores the status quo as the functions were exported
> > before the move to the drivers/clk tree.
> > 
> 
> I guess we should move to the 'reset framework' at some point in the future?
> 

Yes please do.  Peripheral reset stuff should not lurk in the clock
code.  I kind of brought this point up back in June of 2012:
http://article.gmane.org/gmane.linux.ports.tegra/5346/

Back then the discussion was around removing this export from your clock
driver and putting common reset code in clk.h (which is a bad idea).
Now that the reset framework exists this stuff really should be migrated
out of the clock framework entirely.

But as long as this patch is considered an incremental change then it's
OK by me.

Regards,
Mike

> Otherwise:
> 
> Acked-By: Peter De Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> 
> Cheers,
> 
> Peter.

      parent reply	other threads:[~2013-04-02 17:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28 20:31 [PATCH 1/2] clk: tegra: Export peripheral reset functions Thierry Reding
     [not found] ` <1364502688-5135-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2013-03-28 20:31   ` [PATCH 2/2] clk: tegra: Make gr2d and gr3d clocks children of pll_c Thierry Reding
     [not found]     ` <1364502688-5135-2-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2013-03-29 21:46       ` Stephen Warren
     [not found]         ` <51560BC4.8020400-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-01  6:03           ` Mark Zhang
2013-04-02  5:28           ` Terje Bergström
     [not found]             ` <515A6C95.4060900-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-02  5:47               ` Thierry Reding
     [not found]                 ` <20130402054722.GA21277-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2013-04-02  5:50                   ` Terje Bergström
2013-04-02  9:33       ` Peter De Schrijver
2013-03-28 23:23   ` [PATCH 1/2] clk: tegra: Export peripheral reset functions Stephen Warren
2013-03-29 15:34   ` Stephen Warren
2013-03-29 21:45   ` Stephen Warren
2013-04-02  9:34   ` Peter De Schrijver
     [not found]     ` <20130402093426.GZ18519-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-04-02 17:35       ` Mike Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130402173529.8177.49420@quantum \
    --to=mturquette-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.