* [PATCH v3] xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G
@ 2013-05-06 9:42 Eryu Guan
2013-05-10 7:07 ` Eryu Guan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eryu Guan @ 2013-05-06 9:42 UTC (permalink / raw)
To: xfs; +Cc: Eryu Guan
ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
Regression test for commit
29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
v3: rebase on top of master
v2: Check for $SCRATCH_DEV size, _notrun if it's smaller than 5G
tests/generic/312 | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++
tests/generic/312.out | 2 ++
tests/generic/group | 1 +
3 files changed, 75 insertions(+)
create mode 100644 tests/generic/312
create mode 100644 tests/generic/312.out
diff --git a/tests/generic/312 b/tests/generic/312
new file mode 100644
index 0000000..eaec43c
--- /dev/null
+++ b/tests/generic/312
@@ -0,0 +1,72 @@
+#! /bin/bash
+# FS QA Test No. 312
+#
+# ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
+#
+# Regression test for commit
+# 29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 Red Hat, Inc. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+_require_xfs_io_falloc
+_require_scratch
+
+# 5G in byte
+fssize=$((2**30 * 5))
+required_blocks=$(($fssize / 1024))
+dev_blocks=$(grep $(basename $(readlink -f $SCRATCH_DEV)) /proc/partitions | $AWK_PROG '{print $3}')
+if [ $required_blocks -gt $dev_blocks ];then
+ _notrun "this test requires \$SCRATCH_DEV has ${fssize}B space"
+fi
+
+rm -f $seqres.full
+_scratch_mkfs_sized $fssize >>$seqres.full 2>&1
+_scratch_mount >>$seqres.full 2>&1
+
+echo "Silence is golden"
+
+# fallocate(2) a 6G(> 4G) file on a 5G fs
+$XFS_IO_PROG -f -c "falloc 0 6g" $SCRATCH_MNT/testfile.$seq >>$seqres.full 2>&1
+
+_scratch_unmount
+_check_scratch_fs
+status=0
+exit
diff --git a/tests/generic/312.out b/tests/generic/312.out
new file mode 100644
index 0000000..6e72aa9
--- /dev/null
+++ b/tests/generic/312.out
@@ -0,0 +1,2 @@
+QA output created by 312
+Silence is golden
diff --git a/tests/generic/group b/tests/generic/group
index eb52833..cb15afe 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -114,3 +114,4 @@
309 auto quick
310 auto
311 auto metadata log
+312 auto quick prealloc enospc
--
1.8.2.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G
2013-05-06 9:42 [PATCH v3] xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G Eryu Guan
@ 2013-05-10 7:07 ` Eryu Guan
2013-05-15 13:14 ` Rich Johnston
2013-05-15 13:16 ` Rich Johnston
2 siblings, 0 replies; 4+ messages in thread
From: Eryu Guan @ 2013-05-10 7:07 UTC (permalink / raw)
To: xfs
On Mon, May 06, 2013 at 05:42:35PM +0800, Eryu Guan wrote:
> ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
>
> Regression test for commit
> 29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> v3: rebase on top of master
> v2: Check for $SCRATCH_DEV size, _notrun if it's smaller than 5G
Any comments on this test case?
Thanks!
Eryu Guan
>
> tests/generic/312 | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++
> tests/generic/312.out | 2 ++
> tests/generic/group | 1 +
> 3 files changed, 75 insertions(+)
> create mode 100644 tests/generic/312
> create mode 100644 tests/generic/312.out
>
> diff --git a/tests/generic/312 b/tests/generic/312
> new file mode 100644
> index 0000000..eaec43c
> --- /dev/null
> +++ b/tests/generic/312
> @@ -0,0 +1,72 @@
> +#! /bin/bash
> +# FS QA Test No. 312
> +#
> +# ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
> +#
> +# Regression test for commit
> +# 29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2013 Red Hat, Inc. All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +#-----------------------------------------------------------------------
> +#
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# real QA test starts here
> +_supported_fs generic
> +_supported_os Linux
> +_require_xfs_io_falloc
> +_require_scratch
> +
> +# 5G in byte
> +fssize=$((2**30 * 5))
> +required_blocks=$(($fssize / 1024))
> +dev_blocks=$(grep $(basename $(readlink -f $SCRATCH_DEV)) /proc/partitions | $AWK_PROG '{print $3}')
> +if [ $required_blocks -gt $dev_blocks ];then
> + _notrun "this test requires \$SCRATCH_DEV has ${fssize}B space"
> +fi
> +
> +rm -f $seqres.full
> +_scratch_mkfs_sized $fssize >>$seqres.full 2>&1
> +_scratch_mount >>$seqres.full 2>&1
> +
> +echo "Silence is golden"
> +
> +# fallocate(2) a 6G(> 4G) file on a 5G fs
> +$XFS_IO_PROG -f -c "falloc 0 6g" $SCRATCH_MNT/testfile.$seq >>$seqres.full 2>&1
> +
> +_scratch_unmount
> +_check_scratch_fs
> +status=0
> +exit
> diff --git a/tests/generic/312.out b/tests/generic/312.out
> new file mode 100644
> index 0000000..6e72aa9
> --- /dev/null
> +++ b/tests/generic/312.out
> @@ -0,0 +1,2 @@
> +QA output created by 312
> +Silence is golden
> diff --git a/tests/generic/group b/tests/generic/group
> index eb52833..cb15afe 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -114,3 +114,4 @@
> 309 auto quick
> 310 auto
> 311 auto metadata log
> +312 auto quick prealloc enospc
> --
> 1.8.2.1
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G
2013-05-06 9:42 [PATCH v3] xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G Eryu Guan
2013-05-10 7:07 ` Eryu Guan
@ 2013-05-15 13:14 ` Rich Johnston
2013-05-15 13:16 ` Rich Johnston
2 siblings, 0 replies; 4+ messages in thread
From: Rich Johnston @ 2013-05-15 13:14 UTC (permalink / raw)
To: Eryu Guan; +Cc: xfs
On 05/06/2013 04:42 AM, Eryu Guan wrote:
> ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
>
> Regression test for commit
> 29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Tested fine for xfs and ext4, Looks good.
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G
2013-05-06 9:42 [PATCH v3] xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G Eryu Guan
2013-05-10 7:07 ` Eryu Guan
2013-05-15 13:14 ` Rich Johnston
@ 2013-05-15 13:16 ` Rich Johnston
2 siblings, 0 replies; 4+ messages in thread
From: Rich Johnston @ 2013-05-15 13:16 UTC (permalink / raw)
To: Eryu Guan; +Cc: xfs
On 05/06/2013 04:42 AM, Eryu Guan wrote:
> ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
>
> Regression test for commit
> 29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
>
This patch has been committed:
commit 355beacfaf705294b119a3da372512589ff893e9
Author: Eryu Guan <eguan@redhat.com>
Date: Wed May 15 07:48:41 2013 -0500
ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
Regression test for commit
29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()
Signed-off-by: Eryu Guan <eguan@redhat.com>
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
Thanks
--Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-15 13:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-06 9:42 [PATCH v3] xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G Eryu Guan
2013-05-10 7:07 ` Eryu Guan
2013-05-15 13:14 ` Rich Johnston
2013-05-15 13:16 ` Rich Johnston
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.