All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
	"djbw @ fb . com" <djbw@fb.com>,
	"linux-kernel @ vger . kernel . org"
	<linux-kernel@vger.kernel.org>,
	"linux-arm-kernel @ lists . infradead . org" 
	<linux-arm-kernel@lists.infradead.org>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>
Subject: Re: [PATCH] dmatest: abort transfers immediately when asked for
Date: Tue, 21 May 2013 16:11:43 +0100	[thread overview]
Message-ID: <20130521151143.GH10453@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1369139597-24446-1-git-send-email-andriy.shevchenko@linux.intel.com>

Hi Andy,

On Tue, May 21, 2013 at 01:33:17PM +0100, Andy Shevchenko wrote:
> When thread is going to be stopped we have to unconditionally terminate all
> ongoing transfers. Otherwise it would be possible that callback function will
> be called on the next interrupt and will try to access to already freed
> structures.
> 
> The patch introduces specific error message for this, though it doesn't
> increase the counter of the failed tests.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reported-by: Will Deacon <will.deacon@arm.com>

Thanks for persevering with this! Although this patch definitely fixes the
panic I was seeing, I now observe buffer verification failures in subsequent
test runs after an aborted run:

[   43.888424] dma0chan0-copy0: #1: transfer aborted with src_off=0x81f0 dst_off=0x9f4 len=0xdf29 (0)
[   43.888526] dma0chan0-copy0: terminating after 1 tests, 0 failures (status 0)
[   43.888635] dmatest: thread dma0chan0-copy0 exited with status 0

<reload module and start new tests>

[   77.341405] dma0chan0-copy0: #1: errors with src_off=0x8e29 dst_off=0x11dc8 len=0x2b93 (370)
[   77.341505] dma0chan0-copy0: terminating after 1 tests, 1 failures (status 0)

Note that the non-aborted transfers (I have 4 dma controllers) seem fine.

Looking at the results file doesn't show anything obvious, although I do
see some strange entries:

	[...]
	dstbuf not copied! [0xffffffff] Expected ff, got ff
	dstbuf not copied! [0xffffffff] Expected ff, got ff
	dstbuf not copied! [0xffffffff] Expected 00, got 00
	dstbuf not copied! [0xffffffff] Expected 00, got 00
	dstbuf not copied! [0xffffffff] Expected ff, got ff
	[...]

The more alarming ones look like:

	[...]
	dstbuf not copied! [0x147e9] Expected d5, got 36
	dstbuf not copied! [0x147ea] Expected d4, got 35
	dstbuf not copied! [0x147eb] Expected d3, got 34
	dstbuf not copied! [0x147ec] Expected d2, got 33
	dstbuf not copied! [0x147ed] Expected d1, got 32
	dstbuf not copied! [0x147ee] Expected d0, got 31
	[...]

Of course, this could be a driver bug with the PL330 that is being exposed
by this aborting code.

Will

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmatest: abort transfers immediately when asked for
Date: Tue, 21 May 2013 16:11:43 +0100	[thread overview]
Message-ID: <20130521151143.GH10453@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1369139597-24446-1-git-send-email-andriy.shevchenko@linux.intel.com>

Hi Andy,

On Tue, May 21, 2013 at 01:33:17PM +0100, Andy Shevchenko wrote:
> When thread is going to be stopped we have to unconditionally terminate all
> ongoing transfers. Otherwise it would be possible that callback function will
> be called on the next interrupt and will try to access to already freed
> structures.
> 
> The patch introduces specific error message for this, though it doesn't
> increase the counter of the failed tests.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reported-by: Will Deacon <will.deacon@arm.com>

Thanks for persevering with this! Although this patch definitely fixes the
panic I was seeing, I now observe buffer verification failures in subsequent
test runs after an aborted run:

[   43.888424] dma0chan0-copy0: #1: transfer aborted with src_off=0x81f0 dst_off=0x9f4 len=0xdf29 (0)
[   43.888526] dma0chan0-copy0: terminating after 1 tests, 0 failures (status 0)
[   43.888635] dmatest: thread dma0chan0-copy0 exited with status 0

<reload module and start new tests>

[   77.341405] dma0chan0-copy0: #1: errors with src_off=0x8e29 dst_off=0x11dc8 len=0x2b93 (370)
[   77.341505] dma0chan0-copy0: terminating after 1 tests, 1 failures (status 0)

Note that the non-aborted transfers (I have 4 dma controllers) seem fine.

Looking at the results file doesn't show anything obvious, although I do
see some strange entries:

	[...]
	dstbuf not copied! [0xffffffff] Expected ff, got ff
	dstbuf not copied! [0xffffffff] Expected ff, got ff
	dstbuf not copied! [0xffffffff] Expected 00, got 00
	dstbuf not copied! [0xffffffff] Expected 00, got 00
	dstbuf not copied! [0xffffffff] Expected ff, got ff
	[...]

The more alarming ones look like:

	[...]
	dstbuf not copied! [0x147e9] Expected d5, got 36
	dstbuf not copied! [0x147ea] Expected d4, got 35
	dstbuf not copied! [0x147eb] Expected d3, got 34
	dstbuf not copied! [0x147ec] Expected d2, got 33
	dstbuf not copied! [0x147ed] Expected d1, got 32
	dstbuf not copied! [0x147ee] Expected d0, got 31
	[...]

Of course, this could be a driver bug with the PL330 that is being exposed
by this aborting code.

Will

  reply	other threads:[~2013-05-21 15:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 15:28 dmatest regression in 3.10-rc1 Will Deacon
2013-05-15 15:28 ` Will Deacon
2013-05-16 15:35 ` Will Deacon
2013-05-16 15:35   ` Will Deacon
2013-05-17 12:34   ` Vinod Koul
2013-05-17 12:34     ` Vinod Koul
2013-05-17 14:18     ` Will Deacon
2013-05-17 14:18       ` Will Deacon
2013-05-20  7:52       ` Andy Shevchenko
2013-05-20  7:52         ` Andy Shevchenko
2013-05-20  9:58         ` Will Deacon
2013-05-20  9:58           ` Will Deacon
2013-05-21 12:31           ` Andy Shevchenko
2013-05-21 12:31             ` Andy Shevchenko
2013-05-21 12:33   ` [PATCH] dmatest: abort transfers immediately when asked for Andy Shevchenko
2013-05-21 12:33     ` Andy Shevchenko
2013-05-21 15:11     ` Will Deacon [this message]
2013-05-21 15:11       ` Will Deacon
2013-05-21 17:24       ` Andy Shevchenko
2013-05-21 17:24         ` Andy Shevchenko
2013-05-22 12:41         ` Will Deacon
2013-05-22 12:41           ` Will Deacon
2013-05-22 13:26           ` Andy Shevchenko
2013-05-22 13:26             ` Andy Shevchenko
2013-05-23 10:09         ` Vinod Koul
2013-05-23 10:09           ` Vinod Koul
2013-05-23 10:51           ` Andy Shevchenko
2013-05-23 10:51             ` Andy Shevchenko
2013-05-23 10:22             ` Vinod Koul
2013-05-23 10:22               ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130521151143.GH10453@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=djbw@fb.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.