All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Florian Fainelli <florian@openwrt.org>
Cc: David Miller <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Stefan Roese <sr@denx.de>,
	Emilio Lopez <emilio@elopez.com.ar>,
	kevin@allwinnertech.com, sunny@allwinnertech.com,
	shuge@allwinnertech.com
Subject: Re: [PATCHv3 2/6] net: Add MDIO bus driver for the Allwinner EMAC
Date: Fri, 24 May 2013 12:14:19 +0200	[thread overview]
Message-ID: <20130524101419.GC8785@lukather> (raw)
In-Reply-To: <CAGVrzcbyXiKCKxtOAj0gnG8eCQag8_xvmd9dUKACCbfW-2HN9Q@mail.gmail.com>

Hi Florian,

On Fri, May 24, 2013 at 10:42:30AM +0100, Florian Fainelli wrote:
> Hello Maxime,
> 
> 2013/5/24 Maxime Ripard <maxime.ripard@free-electrons.com>
> >
> > This patch adds a separate driver for the MDIO interface of the
> > Allwinner ethernet controllers.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  .../bindings/net/allwinner,sun4i-mdio.txt          |  26 +++
> >  drivers/net/ethernet/allwinner/Kconfig             |   8 +
> >  drivers/net/ethernet/allwinner/Makefile            |   1 +
> >  drivers/net/ethernet/allwinner/sun4i-mdio.c        | 191 +++++++++++++++++++++
> 
> Ok, so you probably followed Thomas's example here with mvneta/mvmdio,
> but all other MDIO bus drivers live in drivers/net/phy.

Indeed I shamelessly followed Thomas here.

> Unfortunately, mvmdio lives in drivers/net/ethernet/marvell/mvmdio.c
> which I should have noticed before. Whatever is good for you guys, but
> we should probably start normalizing this now before more mdio drivers
> get merged alongside their corresponding ethernet MAC users.

I'm fine with either way, just tell me where to put it and I'll happily
do so.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 2/6] net: Add MDIO bus driver for the Allwinner EMAC
Date: Fri, 24 May 2013 12:14:19 +0200	[thread overview]
Message-ID: <20130524101419.GC8785@lukather> (raw)
In-Reply-To: <CAGVrzcbyXiKCKxtOAj0gnG8eCQag8_xvmd9dUKACCbfW-2HN9Q@mail.gmail.com>

Hi Florian,

On Fri, May 24, 2013 at 10:42:30AM +0100, Florian Fainelli wrote:
> Hello Maxime,
> 
> 2013/5/24 Maxime Ripard <maxime.ripard@free-electrons.com>
> >
> > This patch adds a separate driver for the MDIO interface of the
> > Allwinner ethernet controllers.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  .../bindings/net/allwinner,sun4i-mdio.txt          |  26 +++
> >  drivers/net/ethernet/allwinner/Kconfig             |   8 +
> >  drivers/net/ethernet/allwinner/Makefile            |   1 +
> >  drivers/net/ethernet/allwinner/sun4i-mdio.c        | 191 +++++++++++++++++++++
> 
> Ok, so you probably followed Thomas's example here with mvneta/mvmdio,
> but all other MDIO bus drivers live in drivers/net/phy.

Indeed I shamelessly followed Thomas here.

> Unfortunately, mvmdio lives in drivers/net/ethernet/marvell/mvmdio.c
> which I should have noticed before. Whatever is good for you guys, but
> we should probably start normalizing this now before more mdio drivers
> get merged alongside their corresponding ethernet MAC users.

I'm fine with either way, just tell me where to put it and I'll happily
do so.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-05-24 10:14 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  9:23 [PATCHv3 RESEND 0/6] ARM: sunxi: Add support for A10 Ethernet controller Maxime Ripard
2013-05-24  9:23 ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 1/6] net: Add EMAC ethernet driver found on Allwinner A10 SoC's Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24 12:46   ` Emilio López
2013-05-24 12:46     ` Emilio López
2013-05-24 20:10     ` Maxime Ripard
2013-05-24 20:10       ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 2/6] net: Add MDIO bus driver for the Allwinner EMAC Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24  9:42   ` Florian Fainelli
2013-05-24  9:42     ` Florian Fainelli
2013-05-24 10:14     ` Maxime Ripard [this message]
2013-05-24 10:14       ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 3/6] ARM: sun4i: Add muxing options for the ethernet controller Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 4/6] ARM: sunxi: Add EMAC controller node to sun4i DTSI Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 5/6] ARM: cubieboard: Enable ethernet (EMAC) support in dts Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24 12:53   ` Emilio López
2013-05-24 12:53     ` Emilio López
2013-05-24 20:15     ` Maxime Ripard
2013-05-24 20:15       ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 6/6] ARM: sunxi: Add EMAC Controller to Hackberry dt Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-29 18:15 ` [PATCHv3 RESEND 0/6] ARM: sunxi: Add support for A10 Ethernet controller Richard Genoud
2013-05-29 18:15   ` Richard Genoud
2013-05-30  8:11   ` Maxime Ripard
2013-05-30  8:11     ` Maxime Ripard
2013-05-30 17:50     ` Richard Genoud
2013-05-30 17:50       ` Richard Genoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130524101419.GC8785@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=davem@davemloft.net \
    --cc=emilio@elopez.com.ar \
    --cc=florian@openwrt.org \
    --cc=kevin@allwinnertech.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuge@allwinnertech.com \
    --cc=sr@denx.de \
    --cc=sunny@allwinnertech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.