All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Emilio López" <emilio@elopez.com.ar>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stefan Roese <sr@denx.de>, Florian Fainelli <florian@openwrt.org>,
	kevin@allwinnertech.com, sunny@allwinnertech.com,
	shuge@allwinnertech.com
Subject: Re: [PATCHv3 5/6] ARM: cubieboard: Enable ethernet (EMAC) support in dts
Date: Fri, 24 May 2013 09:53:07 -0300	[thread overview]
Message-ID: <519F62B3.8090302@elopez.com.ar> (raw)
In-Reply-To: <1369387394-9453-6-git-send-email-maxime.ripard@free-electrons.com>

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

Hi,

El 24/05/13 06:23, Maxime Ripard escribió:
> From: Stefan Roese <sr@denx.de>
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> index b70fe0d..32d9b18 100644
> --- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> +++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> @@ -27,6 +27,21 @@
>  	};
>  
>  	soc@01c20000 {
> +		emac: ethernet@01c0b000 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&emac_pins_a>;
> +			phy = <&phy0>;
> +			status = "okay";
> +		};
> +
> +		mdio@01c0b080 {
> +			status = "okay";
> +
> +			phy0: ethernet-phy@0 {
> +				reg = <0>;
> +			};

During my testing I found out that I needed to use 1 as reg for the
driver to work. You can find a fixup patch enclosed that changes this;
it's possible that some extra changes may also be needed (s/phy0/phy1/
on the node?)

Cheers,

Emilio

[-- Attachment #2: fixup-reg.patch --]
[-- Type: text/x-diff, Size: 711 bytes --]

>From f8a76c66fff0700e3c87f89b8b250effc0f2b37f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Emilio=20L=C3=B3pez?= <emilio@elopez.com.ar>
Date: Fri, 17 May 2013 10:11:48 -0300
Subject: [PATCH] fixup! ARM: cubieboard: Enable ethernet (EMAC) support in dts

---
 arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
index cd69799..21f0197 100644
--- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
+++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
@@ -38,7 +38,7 @@
 			status = "okay";
 
 			phy0: ethernet-phy@0 {
-				reg = <0>;
+				reg = <1>;
 			};
 		};
 
-- 
1.8.1.6


WARNING: multiple messages have this Message-ID (diff)
From: emilio@elopez.com.ar (Emilio López)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 5/6] ARM: cubieboard: Enable ethernet (EMAC) support in dts
Date: Fri, 24 May 2013 09:53:07 -0300	[thread overview]
Message-ID: <519F62B3.8090302@elopez.com.ar> (raw)
In-Reply-To: <1369387394-9453-6-git-send-email-maxime.ripard@free-electrons.com>

Hi,

El 24/05/13 06:23, Maxime Ripard escribi?:
> From: Stefan Roese <sr@denx.de>
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> index b70fe0d..32d9b18 100644
> --- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> +++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> @@ -27,6 +27,21 @@
>  	};
>  
>  	soc at 01c20000 {
> +		emac: ethernet at 01c0b000 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&emac_pins_a>;
> +			phy = <&phy0>;
> +			status = "okay";
> +		};
> +
> +		mdio at 01c0b080 {
> +			status = "okay";
> +
> +			phy0: ethernet-phy at 0 {
> +				reg = <0>;
> +			};

During my testing I found out that I needed to use 1 as reg for the
driver to work. You can find a fixup patch enclosed that changes this;
it's possible that some extra changes may also be needed (s/phy0/phy1/
on the node?)

Cheers,

Emilio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixup-reg.patch
Type: text/x-diff
Size: 711 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130524/8a9338c8/attachment-0001.bin>

  reply	other threads:[~2013-05-24 12:53 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  9:23 [PATCHv3 RESEND 0/6] ARM: sunxi: Add support for A10 Ethernet controller Maxime Ripard
2013-05-24  9:23 ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 1/6] net: Add EMAC ethernet driver found on Allwinner A10 SoC's Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24 12:46   ` Emilio López
2013-05-24 12:46     ` Emilio López
2013-05-24 20:10     ` Maxime Ripard
2013-05-24 20:10       ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 2/6] net: Add MDIO bus driver for the Allwinner EMAC Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24  9:42   ` Florian Fainelli
2013-05-24  9:42     ` Florian Fainelli
2013-05-24 10:14     ` Maxime Ripard
2013-05-24 10:14       ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 3/6] ARM: sun4i: Add muxing options for the ethernet controller Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 4/6] ARM: sunxi: Add EMAC controller node to sun4i DTSI Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 5/6] ARM: cubieboard: Enable ethernet (EMAC) support in dts Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24 12:53   ` Emilio López [this message]
2013-05-24 12:53     ` Emilio López
2013-05-24 20:15     ` Maxime Ripard
2013-05-24 20:15       ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 6/6] ARM: sunxi: Add EMAC Controller to Hackberry dt Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-29 18:15 ` [PATCHv3 RESEND 0/6] ARM: sunxi: Add support for A10 Ethernet controller Richard Genoud
2013-05-29 18:15   ` Richard Genoud
2013-05-30  8:11   ` Maxime Ripard
2013-05-30  8:11     ` Maxime Ripard
2013-05-30 17:50     ` Richard Genoud
2013-05-30 17:50       ` Richard Genoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519F62B3.8090302@elopez.com.ar \
    --to=emilio@elopez.com.ar \
    --cc=davem@davemloft.net \
    --cc=florian@openwrt.org \
    --cc=kevin@allwinnertech.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=netdev@vger.kernel.org \
    --cc=shuge@allwinnertech.com \
    --cc=sr@denx.de \
    --cc=sunny@allwinnertech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.