All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Stuge <peter@stuge.se>
To: KVM devel mailing list <kvm@vger.kernel.org>,
	seabios@seabios.org,
	qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [SeaBIOS] KVM call agenda for 2013-05-28
Date: Fri, 31 May 2013 10:13:34 +0200	[thread overview]
Message-ID: <20130531081334.16432.qmail@stuge.se> (raw)
In-Reply-To: <CAFe8ug--stQH7KW7Bzy7+eSsZ5W-9T4PtU7xpOfsozAd9kt5vA@mail.gmail.com> <20130531023426.GB18156@morn.localdomain>

Kevin O'Connor wrote:
> one possible way forward would be to split the current SeaBIOS rom
> into two roms: "qvmloader" and "seabios".  The "qvmloader" would do
> the qemu specific platform init (pci init, smm init, mtrr init, bios
> tables) and then load and run the regular seabios rom.

qvmloader sounds a lot like coreboot.


> qvmloader could be committed into the QEMU repo and maintained there.

If QEMU really doesn't want anything besides quacking like a PC with
BIOS or UEFI (such as quacking like a PC *without* a particular
firmware) it makes perfect sense to me to put the complete firmware
code into the QEMU repo and never reuse anything else. After all,
that's how the proprietary firmware products are managed.


Jordan Justen wrote:
> Why is updating the ACPI tables in seabios viewed as such a burden?

I don't know about burden but to me it just doesn't make any sense
to generate ACPI in one component (SeaBIOS) based on configuration
for another component (QEMU).

ACPI bytes are obviously a function of QEMU configuration. QEMU
configuration can be changed through a great many channels, so it
makes sense to me that QEMU itself would take care of generating
correct ACPI, rather than exporting it's own data structures and
pushing the ACPI problem onto the firmware, especially considering
the desire for multiple independent firmware implementations.

There's some code for dynamic ACPI generation in coreboot already,
maybe that can be reused in QEMU to save some effort..


> On the flip side, why is moving the ACPI tables to QEMU such an issue?

Maybe because it is such a steaming pile that even the place where it
belongs doesn't really want it..


> I think overall I prefer the tables being built in the firmware,
> despite the extra thrash.

That doesn't make sense to me. :\

Keep in mind: there is firmware and there is firmware..


> Some things, such as the addresses where devices are configured at
> are re-programmable in QEMU, so a firmware can decide to use a
> different address, and thus invalidate the address qvmloader had
> set in the tables.

..there is now talk about a first-stage firmware (qvmloader) which
does only hardware init, and then jumps into a second-stage firmware
(SeaBIOS) which starts the operating system.

I don't expect that anyone would argue for the second-stage firmware
to generate ACPI tables if the first-stage firmware would be shared
across different second-stage implementations.

The above is by the way *exactly* the model coreboot uses since 14 years.

Please make an ernest effort to *look into and try to reuse* what *is
already there* ..

The fear of coreboot is truly amazing.


//Peter

WARNING: multiple messages have this Message-ID (diff)
From: Peter Stuge <peter@stuge.se>
To: KVM devel mailing list <kvm@vger.kernel.org>,
	seabios@seabios.org,
	qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28
Date: Fri, 31 May 2013 10:13:34 +0200	[thread overview]
Message-ID: <20130531081334.16432.qmail@stuge.se> (raw)
In-Reply-To: <CAFe8ug--stQH7KW7Bzy7+eSsZ5W-9T4PtU7xpOfsozAd9kt5vA@mail.gmail.com> <20130531023426.GB18156@morn.localdomain>

Kevin O'Connor wrote:
> one possible way forward would be to split the current SeaBIOS rom
> into two roms: "qvmloader" and "seabios".  The "qvmloader" would do
> the qemu specific platform init (pci init, smm init, mtrr init, bios
> tables) and then load and run the regular seabios rom.

qvmloader sounds a lot like coreboot.


> qvmloader could be committed into the QEMU repo and maintained there.

If QEMU really doesn't want anything besides quacking like a PC with
BIOS or UEFI (such as quacking like a PC *without* a particular
firmware) it makes perfect sense to me to put the complete firmware
code into the QEMU repo and never reuse anything else. After all,
that's how the proprietary firmware products are managed.


Jordan Justen wrote:
> Why is updating the ACPI tables in seabios viewed as such a burden?

I don't know about burden but to me it just doesn't make any sense
to generate ACPI in one component (SeaBIOS) based on configuration
for another component (QEMU).

ACPI bytes are obviously a function of QEMU configuration. QEMU
configuration can be changed through a great many channels, so it
makes sense to me that QEMU itself would take care of generating
correct ACPI, rather than exporting it's own data structures and
pushing the ACPI problem onto the firmware, especially considering
the desire for multiple independent firmware implementations.

There's some code for dynamic ACPI generation in coreboot already,
maybe that can be reused in QEMU to save some effort..


> On the flip side, why is moving the ACPI tables to QEMU such an issue?

Maybe because it is such a steaming pile that even the place where it
belongs doesn't really want it..


> I think overall I prefer the tables being built in the firmware,
> despite the extra thrash.

That doesn't make sense to me. :\

Keep in mind: there is firmware and there is firmware..


> Some things, such as the addresses where devices are configured at
> are re-programmable in QEMU, so a firmware can decide to use a
> different address, and thus invalidate the address qvmloader had
> set in the tables.

..there is now talk about a first-stage firmware (qvmloader) which
does only hardware init, and then jumps into a second-stage firmware
(SeaBIOS) which starts the operating system.

I don't expect that anyone would argue for the second-stage firmware
to generate ACPI tables if the first-stage firmware would be shared
across different second-stage implementations.

The above is by the way *exactly* the model coreboot uses since 14 years.

Please make an ernest effort to *look into and try to reuse* what *is
already there* ..

The fear of coreboot is truly amazing.


//Peter

  reply	other threads:[~2013-05-31  8:13 UTC|newest]

Thread overview: 149+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-23 12:41 KVM call agenda for 2013-05-28 Michael S. Tsirkin
2013-05-23 12:41 ` [Qemu-devel] " Michael S. Tsirkin
2013-05-24  3:02 ` [SeaBIOS] " li guang
2013-05-24  3:02   ` [Qemu-devel] " li guang
2013-05-28 23:53 ` Kevin O'Connor
2013-05-28 23:53   ` [Qemu-devel] " Kevin O'Connor
2013-05-29  8:45   ` Michael S. Tsirkin
2013-05-29  8:45     ` [Qemu-devel] " Michael S. Tsirkin
2013-05-29 16:12     ` Anthony Liguori
2013-05-29 16:12       ` [Qemu-devel] " Anthony Liguori
2013-05-29 16:19       ` Michael S. Tsirkin
2013-05-29 16:19         ` [Qemu-devel] " Michael S. Tsirkin
2013-05-30  6:37       ` Gerd Hoffmann
2013-05-30  6:37         ` Gerd Hoffmann
2013-06-02 15:05     ` [SeaBIOS] " Gleb Natapov
2013-06-02 15:05       ` [Qemu-devel] " Gleb Natapov
2013-06-02 15:09       ` Michael S. Tsirkin
2013-06-02 15:09         ` [Qemu-devel] " Michael S. Tsirkin
2013-06-02 15:40         ` Gleb Natapov
2013-06-02 15:40           ` [Qemu-devel] [SeaBIOS] " Gleb Natapov
2013-06-02 15:53           ` Michael S. Tsirkin
2013-06-02 15:53             ` [Qemu-devel] " Michael S. Tsirkin
2013-06-03  6:25       ` Paolo Bonzini
2013-06-03  6:25         ` [Qemu-devel] " Paolo Bonzini
2013-05-29  8:49   ` Gerd Hoffmann
2013-05-29  8:49     ` [Qemu-devel] " Gerd Hoffmann
2013-05-29  9:17     ` Michael S. Tsirkin
2013-05-29  9:17       ` [Qemu-devel] [SeaBIOS] " Michael S. Tsirkin
2013-05-29  9:42       ` Gerd Hoffmann
2013-05-29  9:42         ` [Qemu-devel] [SeaBIOS] " Gerd Hoffmann
2013-05-29  9:46         ` Michael S. Tsirkin
2013-05-29  9:46           ` [Qemu-devel] [SeaBIOS] " Michael S. Tsirkin
2013-05-29 16:18     ` Anthony Liguori
2013-05-29 16:18       ` [Qemu-devel] " Anthony Liguori
2013-05-29 16:28       ` Michael S. Tsirkin
2013-05-29 16:28         ` [Qemu-devel] " Michael S. Tsirkin
2013-05-29 18:17         ` Michael S. Tsirkin
2013-05-29 18:17           ` [Qemu-devel] [SeaBIOS] " Michael S. Tsirkin
2013-05-29 16:35       ` Markus Armbruster
2013-05-29 16:35         ` [Qemu-devel] " Markus Armbruster
2013-05-30  1:12       ` Kevin O'Connor
2013-05-30  1:12         ` [Qemu-devel] " Kevin O'Connor
2013-05-31 12:16         ` David Woodhouse
2013-05-31 12:16           ` [Qemu-devel] " David Woodhouse
2013-05-30  6:12       ` Gerd Hoffmann
2013-05-30  6:12         ` [Qemu-devel] " Gerd Hoffmann
2013-05-30  9:23       ` David Woodhouse
2013-05-30  9:23         ` [Qemu-devel] " David Woodhouse
2013-05-30 11:13         ` [Qemu-devel] " Laszlo Ersek
2013-05-30 11:13           ` [Qemu-devel] [SeaBIOS] " Laszlo Ersek
2013-05-30 12:19           ` David Woodhouse
2013-05-30 12:19             ` David Woodhouse
2013-05-30 12:27             ` [Qemu-devel] " Michael S. Tsirkin
2013-05-30 12:27               ` [Qemu-devel] [SeaBIOS] " Michael S. Tsirkin
2013-05-30 12:43             ` [Qemu-devel] " Laszlo Ersek
2013-05-30 12:43               ` [Qemu-devel] [SeaBIOS] " Laszlo Ersek
2013-05-30 16:20             ` Jordan Justen
2013-05-30 16:20               ` Jordan Justen
2013-05-30 16:41               ` Laszlo Ersek
2013-05-30 16:41                 ` [Qemu-devel] " Laszlo Ersek
2013-05-30 16:57                 ` Jordan Justen
2013-05-30 16:57                   ` Jordan Justen
2013-05-30 17:37                   ` Laszlo Ersek
2013-05-30 17:37                     ` Laszlo Ersek
2013-05-30 17:45                   ` [Qemu-devel] " Michael S. Tsirkin
2013-05-30 17:45                     ` [Qemu-devel] [SeaBIOS] " Michael S. Tsirkin
2013-05-31  9:32                 ` Gerd Hoffmann
2013-05-31  9:32                   ` [Qemu-devel] " Gerd Hoffmann
2013-05-31  9:55                   ` [SeaBIOS] [Qemu-devel] " Peter Stuge
2013-05-31  9:55                     ` [Qemu-devel] [SeaBIOS] " Peter Stuge
2013-05-31 23:01                   ` Jordan Justen
2013-05-31 23:01                     ` Jordan Justen
2013-06-03  5:28                     ` Gerd Hoffmann
2013-06-03  5:28                       ` [Qemu-devel] " Gerd Hoffmann
2013-05-30 17:44               ` [Qemu-devel] " Michael S. Tsirkin
2013-05-30 17:44                 ` [Qemu-devel] [SeaBIOS] " Michael S. Tsirkin
2013-05-31 12:09               ` David Woodhouse
2013-05-31 12:09                 ` David Woodhouse
2013-05-31 19:48                 ` Patrick Georgi
2013-05-31 19:48                   ` [Qemu-devel] " Patrick Georgi
2013-05-29  9:54   ` Michael S. Tsirkin
2013-05-29  9:54     ` [Qemu-devel] " Michael S. Tsirkin
2013-05-31  2:34   ` Kevin O'Connor
2013-05-31  2:34     ` [Qemu-devel] " Kevin O'Connor
2013-05-31  7:09     ` Jordan Justen
2013-05-31  7:09       ` [Qemu-devel] " Jordan Justen
2013-05-31  8:13       ` Peter Stuge [this message]
2013-05-31  8:13         ` [Qemu-devel] [SeaBIOS] " Peter Stuge
2013-05-31 10:05         ` Gerd Hoffmann
2013-05-31 10:05           ` [Qemu-devel] " Gerd Hoffmann
2013-05-31 13:03         ` Laszlo Ersek
2013-05-31 13:03           ` [Qemu-devel] " Laszlo Ersek
2013-06-01  3:41         ` Kevin O'Connor
2013-06-01  3:41           ` [Qemu-devel] " Kevin O'Connor
2013-05-31 11:45       ` Laszlo Ersek
2013-05-31 11:45         ` [Qemu-devel] " Laszlo Ersek
2013-05-31 13:04         ` Anthony Liguori
2013-05-31 13:04           ` [Qemu-devel] " Anthony Liguori
2013-05-31 14:01           ` Laszlo Ersek
2013-05-31 14:38             ` Anthony Liguori
2013-05-31 14:38               ` [Qemu-devel] " Anthony Liguori
2013-05-31 16:36               ` Laszlo Ersek
2013-05-31 16:36                 ` [Qemu-devel] " Laszlo Ersek
2013-05-31 17:10                 ` Anthony Liguori
2013-05-31 17:10                   ` [Qemu-devel] " Anthony Liguori
2013-05-31 19:02               ` Jordan Justen
2013-05-31 19:02                 ` [Qemu-devel] " Jordan Justen
2013-05-31 20:27                 ` Anthony Liguori
2013-05-31 20:27                   ` [Qemu-devel] " Anthony Liguori
2013-05-31 21:03                   ` Jordan Justen
2013-05-31 21:03                     ` [Qemu-devel] " Jordan Justen
2013-06-01  0:01                     ` Laszlo Ersek
2013-06-01  0:01                       ` [Qemu-devel] " Laszlo Ersek
2013-06-01  3:16                       ` Jordan Justen
2013-06-01  3:16                         ` [Qemu-devel] " Jordan Justen
2013-05-31 14:08           ` David Woodhouse
2013-05-31 14:08             ` [Qemu-devel] " David Woodhouse
2013-05-31 14:28             ` Laszlo Ersek
2013-05-31 14:28               ` [Qemu-devel] " Laszlo Ersek
2013-05-31 15:43             ` Anthony Liguori
2013-05-31 15:43               ` [Qemu-devel] " Anthony Liguori
2013-05-31 16:33               ` David Woodhouse
2013-05-31 16:33                 ` [Qemu-devel] " David Woodhouse
2013-05-31 16:54                 ` Laszlo Ersek
2013-05-31 16:54                   ` [Qemu-devel] " Laszlo Ersek
2013-05-31 17:06                 ` Anthony Liguori
2013-05-31 17:06                   ` [Qemu-devel] " Anthony Liguori
2013-05-31 18:09                   ` Paolo Bonzini
2013-05-31 18:09                     ` [Qemu-devel] " Paolo Bonzini
2013-05-31 18:35                     ` Anthony Liguori
2013-05-31 18:35                       ` [Qemu-devel] " Anthony Liguori
2013-05-31 19:28                       ` Jordan Justen
2013-05-31 19:28                         ` [Qemu-devel] " Jordan Justen
2013-05-31 20:44                         ` Anthony Liguori
2013-05-31 20:44                           ` [Qemu-devel] " Anthony Liguori
2013-05-31 16:45               ` Laszlo Ersek
2013-05-31 16:45                 ` [Qemu-devel] " Laszlo Ersek
2013-06-02  9:43         ` Michael S. Tsirkin
2013-06-02  9:43           ` [Qemu-devel] " Michael S. Tsirkin
2013-06-03  7:24           ` Jordan Justen
2013-06-03  7:24             ` [Qemu-devel] " Jordan Justen
2013-05-31 12:58     ` Anthony Liguori
2013-05-31 12:58       ` [Qemu-devel] " Anthony Liguori
2013-05-31 13:02       ` David Woodhouse
2013-05-31 13:02         ` [Qemu-devel] " David Woodhouse
2013-06-01  3:11       ` Kevin O'Connor
2013-06-01  3:11         ` [Qemu-devel] " Kevin O'Connor
2013-06-02  9:54     ` Michael S. Tsirkin
2013-06-02  9:54       ` [Qemu-devel] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130531081334.16432.qmail@stuge.se \
    --to=peter@stuge.se \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.