From: Felipe Balbi <balbi@ti.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
'Kishon Vijay Abraham I' <kishon@ti.com>,
linux-media@vger.kernel.org, 'Kukjin Kim' <kgene.kim@samsung.com>,
'Sylwester Nawrocki' <s.nawrocki@samsung.com>,
'Felipe Balbi' <balbi@ti.com>, 'Tomasz Figa' <t.figa@samsung.com>,
devicetree-discuss@lists.ozlabs.org,
'Inki Dae' <inki.dae@samsung.com>,
'Donghwa Lee' <dh09.lee@samsung.com>,
'Kyungmin Park' <kyungmin.park@samsung.com>,
'Jean-Christophe PLAGNIOL-VILLARD' <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH V2 2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi
Date: Fri, 28 Jun 2013 12:34:06 +0300 [thread overview]
Message-ID: <20130628093406.GC11297@arwen.pp.htv.fi> (raw)
In-Reply-To: <002001ce73cf$721b9d80$5652d880$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]
On Fri, Jun 28, 2013 at 04:16:44PM +0900, Jingoo Han wrote:
> Add PHY provider node for the DP PHY.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 41cd625..f7bac75 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -614,6 +614,12 @@
> interrupts = <0 94 0>;
> };
>
> + dp_phy: video-phy@10040720 {
> + compatible = "samsung,exynos5250-dp-video-phy";
> + reg = <0x10040720 4>;
> + #phy-cells = <0>;
> + };
> +
> dp-controller {
> compatible = "samsung,exynos5-dp";
> reg = <0x145b0000 0x1000>;
> @@ -623,11 +629,8 @@
> clock-names = "dp";
> #address-cells = <1>;
> #size-cells = <0>;
> -
> - dptx-phy {
> - reg = <0x10040720>;
> - samsung,enable-mask = <1>;
> - };
> + phys = <&dp_phy 0>;
phy-cells being 0, means that this would become:
phys = <&dp_phy>;
> + phy-names = "dp";
for the label, I would use something more descriptive such as
'display-port'.
other than that:
Acked-by: Felipe Balbi <balbi@ti.com>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
<linux-media@vger.kernel.org>,
"'Kukjin Kim'" <kgene.kim@samsung.com>,
"'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
"'Felipe Balbi'" <balbi@ti.com>,
"'Tomasz Figa'" <t.figa@samsung.com>,
<devicetree-discuss@lists.ozlabs.org>,
"'Inki Dae'" <inki.dae@samsung.com>,
"'Donghwa Lee'" <dh09.lee@samsung.com>,
"'Kyungmin Park'" <kyungmin.park@samsung.com>,
"'Jean-Christophe PLAGNIOL-VILLARD'" <plagnioj@jcrosoft.com>,
<linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH V2 2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi
Date: Fri, 28 Jun 2013 12:34:06 +0300 [thread overview]
Message-ID: <20130628093406.GC11297@arwen.pp.htv.fi> (raw)
In-Reply-To: <002001ce73cf$721b9d80$5652d880$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]
On Fri, Jun 28, 2013 at 04:16:44PM +0900, Jingoo Han wrote:
> Add PHY provider node for the DP PHY.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 41cd625..f7bac75 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -614,6 +614,12 @@
> interrupts = <0 94 0>;
> };
>
> + dp_phy: video-phy@10040720 {
> + compatible = "samsung,exynos5250-dp-video-phy";
> + reg = <0x10040720 4>;
> + #phy-cells = <0>;
> + };
> +
> dp-controller {
> compatible = "samsung,exynos5-dp";
> reg = <0x145b0000 0x1000>;
> @@ -623,11 +629,8 @@
> clock-names = "dp";
> #address-cells = <1>;
> #size-cells = <0>;
> -
> - dptx-phy {
> - reg = <0x10040720>;
> - samsung,enable-mask = <1>;
> - };
> + phys = <&dp_phy 0>;
phy-cells being 0, means that this would become:
phys = <&dp_phy>;
> + phy-names = "dp";
for the label, I would use something more descriptive such as
'display-port'.
other than that:
Acked-by: Felipe Balbi <balbi@ti.com>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi
Date: Fri, 28 Jun 2013 09:34:06 +0000 [thread overview]
Message-ID: <20130628093406.GC11297@arwen.pp.htv.fi> (raw)
In-Reply-To: <002001ce73cf$721b9d80$5652d880$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]
On Fri, Jun 28, 2013 at 04:16:44PM +0900, Jingoo Han wrote:
> Add PHY provider node for the DP PHY.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 41cd625..f7bac75 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -614,6 +614,12 @@
> interrupts = <0 94 0>;
> };
>
> + dp_phy: video-phy@10040720 {
> + compatible = "samsung,exynos5250-dp-video-phy";
> + reg = <0x10040720 4>;
> + #phy-cells = <0>;
> + };
> +
> dp-controller {
> compatible = "samsung,exynos5-dp";
> reg = <0x145b0000 0x1000>;
> @@ -623,11 +629,8 @@
> clock-names = "dp";
> #address-cells = <1>;
> #size-cells = <0>;
> -
> - dptx-phy {
> - reg = <0x10040720>;
> - samsung,enable-mask = <1>;
> - };
> + phys = <&dp_phy 0>;
phy-cells being 0, means that this would become:
phys = <&dp_phy>;
> + phy-names = "dp";
for the label, I would use something more descriptive such as
'display-port'.
other than that:
Acked-by: Felipe Balbi <balbi@ti.com>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi
Date: Fri, 28 Jun 2013 12:34:06 +0300 [thread overview]
Message-ID: <20130628093406.GC11297@arwen.pp.htv.fi> (raw)
In-Reply-To: <002001ce73cf$721b9d80$5652d880$@samsung.com>
On Fri, Jun 28, 2013 at 04:16:44PM +0900, Jingoo Han wrote:
> Add PHY provider node for the DP PHY.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 41cd625..f7bac75 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -614,6 +614,12 @@
> interrupts = <0 94 0>;
> };
>
> + dp_phy: video-phy at 10040720 {
> + compatible = "samsung,exynos5250-dp-video-phy";
> + reg = <0x10040720 4>;
> + #phy-cells = <0>;
> + };
> +
> dp-controller {
> compatible = "samsung,exynos5-dp";
> reg = <0x145b0000 0x1000>;
> @@ -623,11 +629,8 @@
> clock-names = "dp";
> #address-cells = <1>;
> #size-cells = <0>;
> -
> - dptx-phy {
> - reg = <0x10040720>;
> - samsung,enable-mask = <1>;
> - };
> + phys = <&dp_phy 0>;
phy-cells being 0, means that this would become:
phys = <&dp_phy>;
> + phy-names = "dp";
for the label, I would use something more descriptive such as
'display-port'.
other than that:
Acked-by: Felipe Balbi <balbi@ti.com>
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130628/fbda190c/attachment.sig>
next prev parent reply other threads:[~2013-06-28 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 7:16 [PATCH V2 2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi Jingoo Han
2013-06-28 7:16 ` Jingoo Han
2013-06-28 7:16 ` Jingoo Han
2013-06-28 9:34 ` Felipe Balbi [this message]
2013-06-28 9:34 ` Felipe Balbi
2013-06-28 9:34 ` Felipe Balbi
2013-06-28 9:34 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130628093406.GC11297@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dh09.lee@samsung.com \
--cc=inki.dae@samsung.com \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=s.nawrocki@samsung.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.