From: Andrew Morton <akpm@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Cody P Schafer <cody@linux.vnet.ibm.com>
Subject: Re: [PATCH v4 2/2] mm: make lru_add_drain_all() selective
Date: Tue, 13 Aug 2013 14:16:21 -0700 [thread overview]
Message-ID: <20130813141621.3f1c3415901d4236942ee736@linux-foundation.org> (raw)
In-Reply-To: <20130813210719.GB28996@mtj.dyndns.org>
On Tue, 13 Aug 2013 17:07:19 -0400 Tejun Heo <tj@kernel.org> wrote:
> > I don't recall seeing such abuse. It's a very common and powerful
> > tool, and not implementing it because some dummy may abuse it weakens
> > the API for all non-dummies. That allocation is simply unneeded.
>
> More powerful and flexible doesn't always equal better and I think
> being simple and less prone to abuses are important characteristics
> that APIs should have.
I've yet to see any evidence that callback APIs have been abused and
I've yet to see any reasoning which makes me believe that this one will
be abused.
> It feels a bit silly to me to push the API
> that way when doing so doesn't even solve the allocation problem.
It removes the need to perform a cpumask allocation in
lru_add_drain_all().
> It doesn't really buy us much while making the interface more complex.
It's a superior interface.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Cody P Schafer <cody@linux.vnet.ibm.com>
Subject: Re: [PATCH v4 2/2] mm: make lru_add_drain_all() selective
Date: Tue, 13 Aug 2013 14:16:21 -0700 [thread overview]
Message-ID: <20130813141621.3f1c3415901d4236942ee736@linux-foundation.org> (raw)
In-Reply-To: <20130813210719.GB28996@mtj.dyndns.org>
On Tue, 13 Aug 2013 17:07:19 -0400 Tejun Heo <tj@kernel.org> wrote:
> > I don't recall seeing such abuse. It's a very common and powerful
> > tool, and not implementing it because some dummy may abuse it weakens
> > the API for all non-dummies. That allocation is simply unneeded.
>
> More powerful and flexible doesn't always equal better and I think
> being simple and less prone to abuses are important characteristics
> that APIs should have.
I've yet to see any evidence that callback APIs have been abused and
I've yet to see any reasoning which makes me believe that this one will
be abused.
> It feels a bit silly to me to push the API
> that way when doing so doesn't even solve the allocation problem.
It removes the need to perform a cpumask allocation in
lru_add_drain_all().
> It doesn't really buy us much while making the interface more complex.
It's a superior interface.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-13 21:16 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 20:22 [PATCH] mm: make lru_add_drain_all() selective Chris Metcalf
2013-08-06 20:22 ` Chris Metcalf
2013-08-06 20:22 ` [PATCH v2] " Chris Metcalf
2013-08-06 20:22 ` Chris Metcalf
2013-08-07 20:45 ` Tejun Heo
2013-08-07 20:45 ` Tejun Heo
2013-08-07 20:49 ` [PATCH v3 1/2] workqueue: add new schedule_on_cpu_mask() API Chris Metcalf
2013-08-07 20:49 ` Chris Metcalf
2013-08-07 20:52 ` [PATCH v3 2/2] mm: make lru_add_drain_all() selective Chris Metcalf
2013-08-07 20:52 ` Chris Metcalf
2013-08-07 22:48 ` [PATCH v2] " Cody P Schafer
2013-08-07 22:48 ` Cody P Schafer
2013-08-07 20:49 ` [PATCH v4 1/2] workqueue: add new schedule_on_cpu_mask() API Chris Metcalf
2013-08-07 20:49 ` Chris Metcalf
2013-08-09 15:02 ` Tejun Heo
2013-08-09 15:02 ` Tejun Heo
2013-08-09 16:12 ` Chris Metcalf
2013-08-09 16:12 ` Chris Metcalf
2013-08-09 16:30 ` Tejun Heo
2013-08-09 16:30 ` Tejun Heo
2013-08-07 20:49 ` [PATCH v5 " Chris Metcalf
2013-08-07 20:49 ` Chris Metcalf
2013-08-09 17:40 ` Tejun Heo
2013-08-09 17:40 ` Tejun Heo
2013-08-09 17:49 ` [PATCH v6 " Chris Metcalf
2013-08-09 17:49 ` Chris Metcalf
2013-08-09 17:52 ` [PATCH v6 2/2] mm: make lru_add_drain_all() selective Chris Metcalf
2013-08-09 17:52 ` Chris Metcalf
2013-08-07 20:52 ` [PATCH v5 " Chris Metcalf
2013-08-07 20:52 ` Chris Metcalf
2013-08-07 20:52 ` [PATCH v4 " Chris Metcalf
2013-08-07 20:52 ` Chris Metcalf
2013-08-12 21:05 ` Andrew Morton
2013-08-12 21:05 ` Andrew Morton
2013-08-13 1:53 ` Chris Metcalf
2013-08-13 1:53 ` Chris Metcalf
2013-08-13 19:35 ` Andrew Morton
2013-08-13 19:35 ` Andrew Morton
2013-08-13 20:19 ` Tejun Heo
2013-08-13 20:19 ` Tejun Heo
2013-08-13 20:31 ` Andrew Morton
2013-08-13 20:31 ` Andrew Morton
2013-08-13 20:59 ` Chris Metcalf
2013-08-13 20:59 ` Chris Metcalf
2013-08-13 21:13 ` Andrew Morton
2013-08-13 21:13 ` Andrew Morton
2013-08-13 22:13 ` Chris Metcalf
2013-08-13 22:13 ` Chris Metcalf
2013-08-13 22:26 ` Andrew Morton
2013-08-13 22:26 ` Andrew Morton
2013-08-13 23:04 ` Chris Metcalf
2013-08-13 23:04 ` Chris Metcalf
2013-08-13 22:51 ` [PATCH v7 1/2] workqueue: add schedule_on_each_cpu_cond Chris Metcalf
2013-08-13 22:51 ` Chris Metcalf
2013-08-13 22:53 ` [PATCH v7 2/2] mm: make lru_add_drain_all() selective Chris Metcalf
2013-08-13 22:53 ` Chris Metcalf
2013-08-13 23:29 ` Tejun Heo
2013-08-13 23:29 ` Tejun Heo
2013-08-13 23:32 ` Chris Metcalf
2013-08-13 23:32 ` Chris Metcalf
2013-08-14 6:46 ` Andrew Morton
2013-08-14 6:46 ` Andrew Morton
2013-08-14 13:05 ` Tejun Heo
2013-08-14 13:05 ` Tejun Heo
2013-08-14 16:03 ` Chris Metcalf
2013-08-14 16:03 ` Chris Metcalf
2013-08-14 16:57 ` Tejun Heo
2013-08-14 16:57 ` Tejun Heo
2013-08-14 17:18 ` Chris Metcalf
2013-08-14 17:18 ` Chris Metcalf
2013-08-14 20:07 ` Tejun Heo
2013-08-14 20:07 ` Tejun Heo
2013-08-14 20:22 ` [PATCH v8] " Chris Metcalf
2013-08-14 20:22 ` Chris Metcalf
2013-08-14 20:44 ` Andrew Morton
2013-08-14 20:44 ` Andrew Morton
2013-08-14 20:50 ` Tejun Heo
2013-08-14 20:50 ` Tejun Heo
2013-08-14 21:03 ` Andrew Morton
2013-08-14 21:03 ` Andrew Morton
2013-08-14 21:07 ` Andrew Morton
2013-08-14 21:07 ` Andrew Morton
2013-08-14 21:12 ` Andrew Morton
2013-08-14 21:12 ` Andrew Morton
2013-08-14 21:23 ` Chris Metcalf
2013-08-14 21:23 ` Chris Metcalf
2013-08-13 23:44 ` [PATCH v7 2/2] " Chris Metcalf
2013-08-13 23:44 ` Chris Metcalf
2013-08-13 23:51 ` Tejun Heo
2013-08-13 23:51 ` Tejun Heo
2013-08-13 21:07 ` [PATCH v4 " Tejun Heo
2013-08-13 21:07 ` Tejun Heo
2013-08-13 21:16 ` Andrew Morton [this message]
2013-08-13 21:16 ` Andrew Morton
2013-08-13 22:07 ` Tejun Heo
2013-08-13 22:07 ` Tejun Heo
2013-08-13 22:18 ` Andrew Morton
2013-08-13 22:18 ` Andrew Morton
2013-08-13 22:33 ` Tejun Heo
2013-08-13 22:33 ` Tejun Heo
2013-08-13 22:47 ` Andrew Morton
2013-08-13 22:47 ` Andrew Morton
2013-08-13 23:03 ` Tejun Heo
2013-08-13 23:03 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813141621.3f1c3415901d4236942ee736@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=cody@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.