All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: ohad@wizery.com, Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Grant Likely <grant.likely@linaro.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Jeffrey Hugo <jhugo@codeaurora.org>,
	Eric Holmberg <eholmber@codeaurora.org>
Subject: Re: [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block
Date: Wed, 14 Aug 2013 13:49:58 -0700	[thread overview]
Message-ID: <20130814204958.GA27999@codeaurora.org> (raw)
In-Reply-To: <1376507361-26907-1-git-send-email-galak@codeaurora.org>

On 08/14, Kumar Gala wrote:
> Add driver for Qualcomm MSM Hardware Mutex block that exists on newer MSM
> SoC (MSM8974, etc).
> 
> CC: Jeffrey Hugo <jhugo@codeaurora.org>
> CC: Eric Holmberg <eholmber@codeaurora.org>
> Signed-off-by: Kumar Gala <galak@codeaurora.org>

Looks good.

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

> ---
> v3:
> * moved dt binding into hwlock/
> * removed smp_mb() as they were not needed
> * cleanup warning
> 
> v2:
> * Fixed init of stride
> * Dealt with a number of comments from Stephen Boyd:
>  - use of <linux/io.h> instead of <asm/io.h>
>  - declaring msm_hwspinlock_of_match once & as const
>  - drop unneccessary () in an if statement
>  - style cleanup to have devm_kzalloc on one line
> 
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2013-08-14 20:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14 19:09 [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block Kumar Gala
2013-08-14 20:49 ` Stephen Boyd [this message]
2013-08-15 13:35 ` Pawel Moll
2013-08-16 22:54   ` Stephen Warren
2013-08-19 11:12     ` Pawel Moll
2013-08-20 14:51       ` Kumar Gala
2013-08-20 14:49   ` Kumar Gala
2013-08-16 22:55 ` Stephen Warren
2013-08-20 14:50   ` Kumar Gala
2014-02-28  5:52 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130814204958.GA27999@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eholmber@codeaurora.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ohad@wizery.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.