From: Kumar Gala <galak@codeaurora.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: ohad@wizery.com, Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ian.campbell@citrix.com>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Jeffrey Hugo <jhugo@codeaurora.org>,
Eric Holmberg <eholmber@codeaurora.org>
Subject: Re: [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block
Date: Tue, 20 Aug 2013 09:50:09 -0500 [thread overview]
Message-ID: <8E7F7103-3EE0-41B2-9408-C6C3D33B69B2@codeaurora.org> (raw)
In-Reply-To: <520EADFC.5000607@wwwdotorg.org>
On Aug 16, 2013, at 5:55 PM, Stephen Warren wrote:
> On 08/14/2013 01:09 PM, Kumar Gala wrote:
>> Add driver for Qualcomm MSM Hardware Mutex block that exists on newer MSM
>> SoC (MSM8974, etc).
>
>> diff --git a/Documentation/devicetree/bindings/hwlock/msm-tcsr-mutex.txt b/Documentation/devicetree/bindings/hwlock/msm-tcsr-mutex.txt
>
>> +Required properties:
>> +- compatible: should be "qcom,tcsr-mutex"
>> +- reg: Should contain registers location and length of mutex registers
>> +- reg-names:
>> + "mutex-base" - string to identify mutex registers
>> +- qcom,num-locks: the number of locks/mutexes supported
>
> Doesn't the block support any interrupts? I suppose the interrupts
> property can be optional though even if it does.
No interrupts on the block.
> Aside from the comments re: reg-names, this binding seems fine.
> --
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2013-08-20 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 19:09 [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block Kumar Gala
2013-08-14 20:49 ` Stephen Boyd
2013-08-15 13:35 ` Pawel Moll
2013-08-16 22:54 ` Stephen Warren
2013-08-19 11:12 ` Pawel Moll
2013-08-20 14:51 ` Kumar Gala
2013-08-20 14:49 ` Kumar Gala
2013-08-16 22:55 ` Stephen Warren
2013-08-20 14:50 ` Kumar Gala [this message]
2014-02-28 5:52 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8E7F7103-3EE0-41B2-9408-C6C3D33B69B2@codeaurora.org \
--to=galak@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=eholmber@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.