All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kumar Gala <galak@codeaurora.org>
To: Pawel Moll <pawel.moll@arm.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	"ohad@wizery.com" <ohad@wizery.com>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	Mark Rutland <Mark.Rutland@arm.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	Jeffrey Hugo <jhugo@codeaurora.org>,
	Eric Holmberg <eholmber@codeaurora.org>
Subject: Re: [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block
Date: Tue, 20 Aug 2013 09:51:55 -0500	[thread overview]
Message-ID: <E7A4BEAB-CBFD-41BF-A6DE-981F74FDB2CF@codeaurora.org> (raw)
In-Reply-To: <1376910775.3157.1.camel@hornet>


On Aug 19, 2013, at 6:12 AM, Pawel Moll wrote:

> On Fri, 2013-08-16 at 23:54 +0100, Stephen Warren wrote:
>> Indeed, I tend to think that reg-names is a bad idea.
>> 
>> IIRC, the rule for "reg" is that entries must always have a defined
>> order, so that it can always be accessed by integer index. 
> 
> First time I hear about that rule, really...
> 
>> And given
>> that's true, allowing for reg-names just creates confusion since it
>> implies you can look up the index in reg-names and then read reg at that
>> index.
> 
> I actually believe that named resources leave less are for error than
> indexed ones. And this is the message I remember being "spread" in the
> times of static platform devices.
> 
> Pawel

I can understand that reg-names being optional for older bindings to ensure backwards compat, but for newer ones agree that it is less error prone.  This is something we should try to come to some agreement on.

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

  reply	other threads:[~2013-08-20 14:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14 19:09 [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block Kumar Gala
2013-08-14 20:49 ` Stephen Boyd
2013-08-15 13:35 ` Pawel Moll
2013-08-16 22:54   ` Stephen Warren
2013-08-19 11:12     ` Pawel Moll
2013-08-20 14:51       ` Kumar Gala [this message]
2013-08-20 14:49   ` Kumar Gala
2013-08-16 22:55 ` Stephen Warren
2013-08-20 14:50   ` Kumar Gala
2014-02-28  5:52 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E7A4BEAB-CBFD-41BF-A6DE-981F74FDB2CF@codeaurora.org \
    --to=galak@codeaurora.org \
    --cc=Mark.Rutland@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eholmber@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.