* [PATCH meta-networking] quagga: two fixes
@ 2013-08-16 2:23 rongqing.li
2013-08-16 7:19 ` Martin Jansa
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: rongqing.li @ 2013-08-16 2:23 UTC (permalink / raw)
To: openembedded-devel, joe.macdonald
From: "Roy.Li" <rongqing.li@windriver.com>
1. quagga should depend on iproute2, since ip from busybox is not sufficient
2. fix a typOS(should chmod, not chown)
Signed-off-by: Roy.Li <rongqing.li@windriver.com>
---
meta-networking/recipes-protocols/quagga/quagga.inc | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/meta-networking/recipes-protocols/quagga/quagga.inc b/meta-networking/recipes-protocols/quagga/quagga.inc
index f5489c6..89b9f7a 100644
--- a/meta-networking/recipes-protocols/quagga/quagga.inc
+++ b/meta-networking/recipes-protocols/quagga/quagga.inc
@@ -5,7 +5,7 @@ Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD. \
Quagga is a fork of GNU Zebra which was developed by Kunihiro \
Ishiguro. The Quagga tree aims to build a more involved community \
around Quagga than the current centralised model of GNU Zebra."
-HOMEPAGE = "http://www.quagga.net/"
+HOMEPAGE = "http://www.nongnu.org/quagga/"
SECTION = "network"
LICENSE = "GPL-2.0 & LGPL-2.0"
DEPENDS = "readline ncurses perl-native"
@@ -17,6 +17,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
INC_PR = "r2"
+# the "ip" command from busybox is not sufficient (flush by protocol flushes all routes)
+RDEPENDS_${PN} += "iproute2"
+
QUAGGASUBDIR = ""
# ${QUAGGASUBDIR} is deal with old versions. Set to "/attic" for old
# versions and leave it empty for recent versions.
@@ -128,11 +131,11 @@ pkg_postinst_${PN} () {
if [ "x$D" != "x" ] ; then
exit 1
fi
- for f in bgpd babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
+ for f in bgpd vtysh babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
chown quagga:quaggavty ${sysconfdir}/quagga
chown quagga:quagga ${sysconfdir}/quagga/*.conf
chmod 750 ${sysconfdir}/quagga
- chown 640 ${sysconfdir}/quagga/*.conf
+ chmod 640 ${sysconfdir}/quagga/*.conf
if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
${sysconfdir}/init.d/populate-volatile.sh update
fi
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH meta-networking] quagga: two fixes
2013-08-16 2:23 [PATCH meta-networking] quagga: two fixes rongqing.li
@ 2013-08-16 7:19 ` Martin Jansa
2013-08-16 8:44 ` Rongqing Li
2013-08-16 17:17 ` Joe MacDonald
2013-09-05 13:28 ` Joe MacDonald
2 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2013-08-16 7:19 UTC (permalink / raw)
To: openembedded-devel; +Cc: joe.macdonald
[-- Attachment #1: Type: text/plain, Size: 2785 bytes --]
On Fri, Aug 16, 2013 at 10:23:59AM +0800, rongqing.li@windriver.com wrote:
> From: "Roy.Li" <rongqing.li@windriver.com>
>
> 1. quagga should depend on iproute2, since ip from busybox is not sufficient
> 2. fix a typOS(should chmod, not chown)
As you care about quagga, can you please fix:
quagga-0.99.21: The /usr/share/info/dir file is not meant to be shipped
in a particular package.
?
Thanks
>
> Signed-off-by: Roy.Li <rongqing.li@windriver.com>
> ---
> meta-networking/recipes-protocols/quagga/quagga.inc | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta-networking/recipes-protocols/quagga/quagga.inc b/meta-networking/recipes-protocols/quagga/quagga.inc
> index f5489c6..89b9f7a 100644
> --- a/meta-networking/recipes-protocols/quagga/quagga.inc
> +++ b/meta-networking/recipes-protocols/quagga/quagga.inc
> @@ -5,7 +5,7 @@ Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD. \
> Quagga is a fork of GNU Zebra which was developed by Kunihiro \
> Ishiguro. The Quagga tree aims to build a more involved community \
> around Quagga than the current centralised model of GNU Zebra."
> -HOMEPAGE = "http://www.quagga.net/"
> +HOMEPAGE = "http://www.nongnu.org/quagga/"
> SECTION = "network"
> LICENSE = "GPL-2.0 & LGPL-2.0"
> DEPENDS = "readline ncurses perl-native"
> @@ -17,6 +17,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
>
> INC_PR = "r2"
>
> +# the "ip" command from busybox is not sufficient (flush by protocol flushes all routes)
> +RDEPENDS_${PN} += "iproute2"
> +
> QUAGGASUBDIR = ""
> # ${QUAGGASUBDIR} is deal with old versions. Set to "/attic" for old
> # versions and leave it empty for recent versions.
> @@ -128,11 +131,11 @@ pkg_postinst_${PN} () {
> if [ "x$D" != "x" ] ; then
> exit 1
> fi
> - for f in bgpd babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
> + for f in bgpd vtysh babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
> chown quagga:quaggavty ${sysconfdir}/quagga
> chown quagga:quagga ${sysconfdir}/quagga/*.conf
> chmod 750 ${sysconfdir}/quagga
> - chown 640 ${sysconfdir}/quagga/*.conf
> + chmod 640 ${sysconfdir}/quagga/*.conf
> if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
> ${sysconfdir}/init.d/populate-volatile.sh update
> fi
> --
> 1.7.10.4
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH meta-networking] quagga: two fixes
2013-08-16 7:19 ` Martin Jansa
@ 2013-08-16 8:44 ` Rongqing Li
2013-08-16 19:50 ` Martin Jansa
0 siblings, 1 reply; 6+ messages in thread
From: Rongqing Li @ 2013-08-16 8:44 UTC (permalink / raw)
To: openembedded-devel; +Cc: joe.macdonald
On 08/16/2013 03:19 PM, Martin Jansa wrote:
> On Fri, Aug 16, 2013 at 10:23:59AM +0800, rongqing.li@windriver.com wrote:
>> From: "Roy.Li" <rongqing.li@windriver.com>
>>
>> 1. quagga should depend on iproute2, since ip from busybox is not sufficient
>> 2. fix a typOS(should chmod, not chown)
>
> As you care about quagga, can you please fix:
> quagga-0.99.21: The /usr/share/info/dir file is not meant to be shipped
> in a particular package.
>
> ?
I did not see this warning, and this file is shipped to quagga-doc.
If there is difference, it is in oe-core, not quagga
-Roy
>
> Thanks
>
>>
>> Signed-off-by: Roy.Li <rongqing.li@windriver.com>
>> ---
>> meta-networking/recipes-protocols/quagga/quagga.inc | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta-networking/recipes-protocols/quagga/quagga.inc b/meta-networking/recipes-protocols/quagga/quagga.inc
>> index f5489c6..89b9f7a 100644
>> --- a/meta-networking/recipes-protocols/quagga/quagga.inc
>> +++ b/meta-networking/recipes-protocols/quagga/quagga.inc
>> @@ -5,7 +5,7 @@ Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD. \
>> Quagga is a fork of GNU Zebra which was developed by Kunihiro \
>> Ishiguro. The Quagga tree aims to build a more involved community \
>> around Quagga than the current centralised model of GNU Zebra."
>> -HOMEPAGE = "http://www.quagga.net/"
>> +HOMEPAGE = "http://www.nongnu.org/quagga/"
>> SECTION = "network"
>> LICENSE = "GPL-2.0 & LGPL-2.0"
>> DEPENDS = "readline ncurses perl-native"
>> @@ -17,6 +17,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
>>
>> INC_PR = "r2"
>>
>> +# the "ip" command from busybox is not sufficient (flush by protocol flushes all routes)
>> +RDEPENDS_${PN} += "iproute2"
>> +
>> QUAGGASUBDIR = ""
>> # ${QUAGGASUBDIR} is deal with old versions. Set to "/attic" for old
>> # versions and leave it empty for recent versions.
>> @@ -128,11 +131,11 @@ pkg_postinst_${PN} () {
>> if [ "x$D" != "x" ] ; then
>> exit 1
>> fi
>> - for f in bgpd babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
>> + for f in bgpd vtysh babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
>> chown quagga:quaggavty ${sysconfdir}/quagga
>> chown quagga:quagga ${sysconfdir}/quagga/*.conf
>> chmod 750 ${sysconfdir}/quagga
>> - chown 640 ${sysconfdir}/quagga/*.conf
>> + chmod 640 ${sysconfdir}/quagga/*.conf
>> if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
>> ${sysconfdir}/init.d/populate-volatile.sh update
>> fi
>> --
>> 1.7.10.4
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH meta-networking] quagga: two fixes
2013-08-16 2:23 [PATCH meta-networking] quagga: two fixes rongqing.li
2013-08-16 7:19 ` Martin Jansa
@ 2013-08-16 17:17 ` Joe MacDonald
2013-09-05 13:28 ` Joe MacDonald
2 siblings, 0 replies; 6+ messages in thread
From: Joe MacDonald @ 2013-08-16 17:17 UTC (permalink / raw)
To: rongqing.li; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2413 bytes --]
Merged, thanks.
-J.
[[PATCH meta-networking] quagga: two fixes] On 13.08.16 (Fri 10:23) rongqing.li@windriver.com wrote:
> From: "Roy.Li" <rongqing.li@windriver.com>
>
> 1. quagga should depend on iproute2, since ip from busybox is not sufficient
> 2. fix a typOS(should chmod, not chown)
>
> Signed-off-by: Roy.Li <rongqing.li@windriver.com>
> ---
> meta-networking/recipes-protocols/quagga/quagga.inc | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta-networking/recipes-protocols/quagga/quagga.inc b/meta-networking/recipes-protocols/quagga/quagga.inc
> index f5489c6..89b9f7a 100644
> --- a/meta-networking/recipes-protocols/quagga/quagga.inc
> +++ b/meta-networking/recipes-protocols/quagga/quagga.inc
> @@ -5,7 +5,7 @@ Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD. \
> Quagga is a fork of GNU Zebra which was developed by Kunihiro \
> Ishiguro. The Quagga tree aims to build a more involved community \
> around Quagga than the current centralised model of GNU Zebra."
> -HOMEPAGE = "http://www.quagga.net/"
> +HOMEPAGE = "http://www.nongnu.org/quagga/"
> SECTION = "network"
> LICENSE = "GPL-2.0 & LGPL-2.0"
> DEPENDS = "readline ncurses perl-native"
> @@ -17,6 +17,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
>
> INC_PR = "r2"
>
> +# the "ip" command from busybox is not sufficient (flush by protocol flushes all routes)
> +RDEPENDS_${PN} += "iproute2"
> +
> QUAGGASUBDIR = ""
> # ${QUAGGASUBDIR} is deal with old versions. Set to "/attic" for old
> # versions and leave it empty for recent versions.
> @@ -128,11 +131,11 @@ pkg_postinst_${PN} () {
> if [ "x$D" != "x" ] ; then
> exit 1
> fi
> - for f in bgpd babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
> + for f in bgpd vtysh babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
> chown quagga:quaggavty ${sysconfdir}/quagga
> chown quagga:quagga ${sysconfdir}/quagga/*.conf
> chmod 750 ${sysconfdir}/quagga
> - chown 640 ${sysconfdir}/quagga/*.conf
> + chmod 640 ${sysconfdir}/quagga/*.conf
> if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
> ${sysconfdir}/init.d/populate-volatile.sh update
> fi
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH meta-networking] quagga: two fixes
2013-08-16 8:44 ` Rongqing Li
@ 2013-08-16 19:50 ` Martin Jansa
0 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2013-08-16 19:50 UTC (permalink / raw)
To: Rongqing Li; +Cc: openembedded-devel, joe.macdonald
[-- Attachment #1: Type: text/plain, Size: 3798 bytes --]
On Fri, Aug 16, 2013 at 04:44:12PM +0800, Rongqing Li wrote:
>
>
> On 08/16/2013 03:19 PM, Martin Jansa wrote:
> > On Fri, Aug 16, 2013 at 10:23:59AM +0800, rongqing.li@windriver.com wrote:
> >> From: "Roy.Li" <rongqing.li@windriver.com>
> >>
> >> 1. quagga should depend on iproute2, since ip from busybox is not sufficient
> >> 2. fix a typOS(should chmod, not chown)
> >
> > As you care about quagga, can you please fix:
> > quagga-0.99.21: The /usr/share/info/dir file is not meant to be shipped
> > in a particular package.
> >
> > ?
>
> I did not see this warning, and this file is shipped to quagga-doc.
>
> If there is difference, it is in oe-core, not quagga
Sorry I don't understand what you mean, the infodir QA test is
relatively new and quagga + 4 more recipes suffer from this issue and
should be fixed, see the check and list of recipes with warning in:
http://patches.openembedded.org/patch/52725/
>
> -Roy
>
>
> >
> > Thanks
> >
> >>
> >> Signed-off-by: Roy.Li <rongqing.li@windriver.com>
> >> ---
> >> meta-networking/recipes-protocols/quagga/quagga.inc | 9 ++++++---
> >> 1 file changed, 6 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/meta-networking/recipes-protocols/quagga/quagga.inc b/meta-networking/recipes-protocols/quagga/quagga.inc
> >> index f5489c6..89b9f7a 100644
> >> --- a/meta-networking/recipes-protocols/quagga/quagga.inc
> >> +++ b/meta-networking/recipes-protocols/quagga/quagga.inc
> >> @@ -5,7 +5,7 @@ Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD. \
> >> Quagga is a fork of GNU Zebra which was developed by Kunihiro \
> >> Ishiguro. The Quagga tree aims to build a more involved community \
> >> around Quagga than the current centralised model of GNU Zebra."
> >> -HOMEPAGE = "http://www.quagga.net/"
> >> +HOMEPAGE = "http://www.nongnu.org/quagga/"
> >> SECTION = "network"
> >> LICENSE = "GPL-2.0 & LGPL-2.0"
> >> DEPENDS = "readline ncurses perl-native"
> >> @@ -17,6 +17,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
> >>
> >> INC_PR = "r2"
> >>
> >> +# the "ip" command from busybox is not sufficient (flush by protocol flushes all routes)
> >> +RDEPENDS_${PN} += "iproute2"
> >> +
> >> QUAGGASUBDIR = ""
> >> # ${QUAGGASUBDIR} is deal with old versions. Set to "/attic" for old
> >> # versions and leave it empty for recent versions.
> >> @@ -128,11 +131,11 @@ pkg_postinst_${PN} () {
> >> if [ "x$D" != "x" ] ; then
> >> exit 1
> >> fi
> >> - for f in bgpd babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
> >> + for f in bgpd vtysh babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
> >> chown quagga:quaggavty ${sysconfdir}/quagga
> >> chown quagga:quagga ${sysconfdir}/quagga/*.conf
> >> chmod 750 ${sysconfdir}/quagga
> >> - chown 640 ${sysconfdir}/quagga/*.conf
> >> + chmod 640 ${sysconfdir}/quagga/*.conf
> >> if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
> >> ${sysconfdir}/init.d/populate-volatile.sh update
> >> fi
> >> --
> >> 1.7.10.4
> >>
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> >
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
>
> --
> Best Reagrds,
> Roy | RongQing Li
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH meta-networking] quagga: two fixes
2013-08-16 2:23 [PATCH meta-networking] quagga: two fixes rongqing.li
2013-08-16 7:19 ` Martin Jansa
2013-08-16 17:17 ` Joe MacDonald
@ 2013-09-05 13:28 ` Joe MacDonald
2 siblings, 0 replies; 6+ messages in thread
From: Joe MacDonald @ 2013-09-05 13:28 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2420 bytes --]
Merged, thanks.
-J.
[[oe] [PATCH meta-networking] quagga: two fixes] On 13.08.16 (Fri 10:23) rongqing.li@windriver.com wrote:
> From: "Roy.Li" <rongqing.li@windriver.com>
>
> 1. quagga should depend on iproute2, since ip from busybox is not sufficient
> 2. fix a typOS(should chmod, not chown)
>
> Signed-off-by: Roy.Li <rongqing.li@windriver.com>
> ---
> meta-networking/recipes-protocols/quagga/quagga.inc | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta-networking/recipes-protocols/quagga/quagga.inc b/meta-networking/recipes-protocols/quagga/quagga.inc
> index f5489c6..89b9f7a 100644
> --- a/meta-networking/recipes-protocols/quagga/quagga.inc
> +++ b/meta-networking/recipes-protocols/quagga/quagga.inc
> @@ -5,7 +5,7 @@ Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD. \
> Quagga is a fork of GNU Zebra which was developed by Kunihiro \
> Ishiguro. The Quagga tree aims to build a more involved community \
> around Quagga than the current centralised model of GNU Zebra."
> -HOMEPAGE = "http://www.quagga.net/"
> +HOMEPAGE = "http://www.nongnu.org/quagga/"
> SECTION = "network"
> LICENSE = "GPL-2.0 & LGPL-2.0"
> DEPENDS = "readline ncurses perl-native"
> @@ -17,6 +17,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
>
> INC_PR = "r2"
>
> +# the "ip" command from busybox is not sufficient (flush by protocol flushes all routes)
> +RDEPENDS_${PN} += "iproute2"
> +
> QUAGGASUBDIR = ""
> # ${QUAGGASUBDIR} is deal with old versions. Set to "/attic" for old
> # versions and leave it empty for recent versions.
> @@ -128,11 +131,11 @@ pkg_postinst_${PN} () {
> if [ "x$D" != "x" ] ; then
> exit 1
> fi
> - for f in bgpd babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
> + for f in bgpd vtysh babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
> chown quagga:quaggavty ${sysconfdir}/quagga
> chown quagga:quagga ${sysconfdir}/quagga/*.conf
> chmod 750 ${sysconfdir}/quagga
> - chown 640 ${sysconfdir}/quagga/*.conf
> + chmod 640 ${sysconfdir}/quagga/*.conf
> if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
> ${sysconfdir}/init.d/populate-volatile.sh update
> fi
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-05 13:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-16 2:23 [PATCH meta-networking] quagga: two fixes rongqing.li
2013-08-16 7:19 ` Martin Jansa
2013-08-16 8:44 ` Rongqing Li
2013-08-16 19:50 ` Martin Jansa
2013-08-16 17:17 ` Joe MacDonald
2013-09-05 13:28 ` Joe MacDonald
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.