All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@euromail.se>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Chris Murphy <bugzilla@colorremedies.com>,
	Josh Boyer <jwboyer@fedoraproject.org>,
	khali@linux-fr.org, lm-sensors@lm-sensors.org,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: applesmc oops in 3.10/3.11
Date: Wed, 2 Oct 2013 18:34:18 +0200	[thread overview]
Message-ID: <20131002163418.GA4557@polaris.bitmath.org> (raw)
In-Reply-To: <524C1FE1.4050207@roeck-us.net>

> >>One thing I have seen in all logs is the earlier "send_byte fail" message, so
> >>I think that is a pre-requisite.
> >
> >Not necessarily - it could be that the patch actually fixes the root
> >cause. One possible scenario is that on recent SMCs, some of the
> >commands produce more data than we actually read. This would
> >eventually lead to both data corruption and overflow somwhere in the
> >SMC internals.  If the original SMC error is interpreted as a read
> >buffer overflow, then that problem should be fixed with this patch.
> >
> 
> Good point.
> 
> But shouldn't we at least get the "flushed %d bytes" warning message in this case ?

The explanation I have there is that the (newer) SMC needs the
application to read the 'no more bytes' or it will get confused. It
makes sense, if the number of bytes to read is no longer specified.

Thanks,
Henrik

WARNING: multiple messages have this Message-ID (diff)
From: Henrik Rydberg <rydberg@euromail.se>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Chris Murphy <bugzilla@colorremedies.com>,
	Josh Boyer <jwboyer@fedoraproject.org>,
	khali@linux-fr.org, lm-sensors@lm-sensors.org,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] applesmc oops in 3.10/3.11
Date: Wed, 02 Oct 2013 16:34:18 +0000	[thread overview]
Message-ID: <20131002163418.GA4557@polaris.bitmath.org> (raw)
In-Reply-To: <524C1FE1.4050207@roeck-us.net>

> >>One thing I have seen in all logs is the earlier "send_byte fail" message, so
> >>I think that is a pre-requisite.
> >
> >Not necessarily - it could be that the patch actually fixes the root
> >cause. One possible scenario is that on recent SMCs, some of the
> >commands produce more data than we actually read. This would
> >eventually lead to both data corruption and overflow somwhere in the
> >SMC internals.  If the original SMC error is interpreted as a read
> >buffer overflow, then that problem should be fixed with this patch.
> >
> 
> Good point.
> 
> But shouldn't we at least get the "flushed %d bytes" warning message in this case ?

The explanation I have there is that the (newer) SMC needs the
application to read the 'no more bytes' or it will get confused. It
makes sense, if the number of bytes to read is no longer specified.

Thanks,
Henrik

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2013-10-02 16:33 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25 19:06 applesmc oops in 3.10/3.11 Josh Boyer
2013-09-25 19:06 ` [lm-sensors] " Josh Boyer
2013-09-25 19:56 ` Guenter Roeck
2013-09-25 19:56   ` [lm-sensors] " Guenter Roeck
2013-09-25 21:48   ` Henrik Rydberg
2013-09-25 21:48     ` [lm-sensors] " Henrik Rydberg
2013-09-25 22:08     ` Guenter Roeck
2013-09-25 22:08       ` [lm-sensors] " Guenter Roeck
2013-09-26  6:34       ` Henrik Rydberg
2013-09-26  6:34         ` [lm-sensors] " Henrik Rydberg
2013-09-26 10:36         ` Guenter Roeck
2013-09-26 10:36           ` [lm-sensors] " Guenter Roeck
2013-09-26 11:13           ` Henrik Rydberg
2013-09-26 11:13             ` [lm-sensors] " Henrik Rydberg
2013-09-26 10:53         ` Guenter Roeck
2013-09-26 10:53           ` [lm-sensors] " Guenter Roeck
2013-09-26 11:11           ` Henrik Rydberg
2013-09-26 11:11             ` [lm-sensors] " Henrik Rydberg
2013-09-27 16:21         ` Josh Boyer
2013-09-27 16:21           ` [lm-sensors] " Josh Boyer
2013-09-27 17:12           ` Guenter Roeck
2013-09-27 17:12             ` [lm-sensors] " Guenter Roeck
2013-09-27 17:41             ` Chris Murphy
2013-09-27 17:41               ` [lm-sensors] " Chris Murphy
2013-09-27 17:59               ` Guenter Roeck
2013-09-27 17:59                 ` [lm-sensors] " Guenter Roeck
2013-09-27 18:03                 ` Chris Murphy
2013-09-27 18:03                   ` [lm-sensors] " Chris Murphy
2013-09-27 23:33                   ` Guenter Roeck
2013-09-27 23:33                     ` [lm-sensors] " Guenter Roeck
2013-10-01  1:57                     ` Chris Murphy
2013-10-01  1:57                       ` [lm-sensors] " Chris Murphy
2013-10-01  3:37                       ` Guenter Roeck
2013-10-01  3:37                         ` [lm-sensors] " Guenter Roeck
2013-10-01 10:55                         ` Henrik Rydberg
2013-10-01 10:55                           ` [lm-sensors] " Henrik Rydberg
2013-10-01 15:19                           ` Guenter Roeck
2013-10-01 15:19                             ` [lm-sensors] " Guenter Roeck
2013-10-01 15:33                             ` Chris Murphy
2013-10-01 15:33                               ` [lm-sensors] " Chris Murphy
2013-10-01 16:24                               ` Guenter Roeck
2013-10-01 16:24                                 ` [lm-sensors] " Guenter Roeck
2013-10-02  1:09                                 ` Chris Murphy
2013-10-02  1:09                                   ` [lm-sensors] " Chris Murphy
2013-10-02  3:51                                   ` Guenter Roeck
2013-10-02  3:51                                     ` [lm-sensors] " Guenter Roeck
2013-10-02  3:55                                     ` Chris Murphy
2013-10-02  3:55                                       ` [lm-sensors] " Chris Murphy
2013-10-02  4:02                                       ` Guenter Roeck
2013-10-02  4:02                                         ` [lm-sensors] " Guenter Roeck
2013-10-02  9:53                                     ` Henrik Rydberg
2013-10-02  9:53                                       ` [lm-sensors] " Henrik Rydberg
2013-10-02 13:30                                       ` Guenter Roeck
2013-10-02 13:30                                         ` [lm-sensors] " Guenter Roeck
2013-10-02 16:34                                         ` Henrik Rydberg [this message]
2013-10-02 16:34                                           ` Henrik Rydberg
2013-10-02 16:47                                           ` Guenter Roeck
2013-10-02 16:47                                             ` [lm-sensors] " Guenter Roeck
2013-10-02 17:24                                             ` Henrik Rydberg
2013-10-02 17:24                                               ` [lm-sensors] " Henrik Rydberg
2013-10-02 18:02                                               ` Guenter Roeck
2013-10-02 18:02                                                 ` [lm-sensors] " Guenter Roeck
2013-10-02 18:33                                                 ` Chris Murphy
2013-10-02 18:33                                                   ` [lm-sensors] " Chris Murphy
2013-10-02 20:59                                                   ` Guenter Roeck
2013-10-02 20:59                                                     ` [lm-sensors] " Guenter Roeck
2013-10-02 21:34                                                     ` Chris Murphy
2013-10-02 21:34                                                       ` [lm-sensors] " Chris Murphy
2013-10-02 23:32                                                       ` Guenter Roeck
2013-10-02 23:32                                                         ` [lm-sensors] " Guenter Roeck
2013-10-07 23:42                                               ` Guenter Roeck
2013-10-07 23:42                                                 ` [lm-sensors] " Guenter Roeck
2013-10-07 23:46                                                 ` Chris Murphy
2013-10-07 23:46                                                   ` [lm-sensors] " Chris Murphy
2013-10-08 15:48                                                   ` Guenter Roeck
2013-10-08 15:48                                                     ` [lm-sensors] " Guenter Roeck
2013-10-08 16:29                                                     ` Henrik Rydberg
2013-10-08 16:29                                                       ` [lm-sensors] " Henrik Rydberg
2013-10-08 16:29                                                       ` Guenter Roeck
2013-10-08 16:29                                                         ` [lm-sensors] " Guenter Roeck
2013-10-09  8:29                                                         ` Henrik Rydberg
2013-10-09  8:29                                                           ` [lm-sensors] " Henrik Rydberg
2013-10-09 16:52                                                           ` Guenter Roeck
2013-10-09 16:52                                                             ` [lm-sensors] " Guenter Roeck
2013-09-27 18:01           ` Guenter Roeck
2013-09-27 18:01             ` [lm-sensors] " Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131002163418.GA4557@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=bugzilla@colorremedies.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.