From: Guenter Roeck <linux@roeck-us.net>
To: Chris Murphy <bugzilla@colorremedies.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Josh Boyer <jwboyer@fedoraproject.org>,
khali@linux-fr.org, lm-sensors@lm-sensors.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: applesmc oops in 3.10/3.11
Date: Tue, 8 Oct 2013 08:48:09 -0700 [thread overview]
Message-ID: <20131008154809.GB18402@roeck-us.net> (raw)
In-Reply-To: <6918F624-B267-4DB5-95A2-7E09448CA3E4@colorremedies.com>
On Mon, Oct 07, 2013 at 05:46:55PM -0600, Chris Murphy wrote:
>
> On Oct 7, 2013, at 5:42 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>
> > On 10/02/2013 10:24 AM, Henrik Rydberg wrote:
> >
> >>> From 4451da32414080bd0563ee9e061f19bf90463cc5 Mon Sep 17 00:00:00 2001
> >> From: Henrik Rydberg <rydberg@euromail.se>
> >> Date: Wed, 2 Oct 2013 19:15:03 +0200
> >> Subject: [PATCH] applesmc remedy take 2
> >>
> >> Conjectured problem: there are remnant bytes ready on the data line
> >> which corrupts the read after a failure.
> >>
> >> Remedy: assuming bit0 is the read valid line, try to flush it before
> >> starting a new command.
> >>
> >> Tests by Chris suggests reading the status is enough for the problem
> >> to go away, which is consistent with a change in the SMC interface,
> >> where the number of bytes to read is no longer specified, but found
> >> out by reading until end of data.
> >>
> >> Tested on a MacBookAir3,1, but the original problem has not been
> >> reproduced.
> >
> > So, what should we do with this patch ? Apply it ?
>
> So far I'm getting nothing on the original machine. As of today it's applied as the last patch on 3.12.0-0.rc4.git0.1.fc20.x86_64. Unfortunately at the moment I'm a bit too dense to figure out how to get a new kernel applied to an existing live package so I can try this on a USB stick. While maybe unrelated, the oops was occurring at least 4x as often booted from USB stick media than HDD.
>
Seems to me we should apply it.
Henrik,
what do you think ? Did you have time for additional testing ?
If you think we should apply it, please send me a signed patch.
Thanks,
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Chris Murphy <bugzilla@colorremedies.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Josh Boyer <jwboyer@fedoraproject.org>,
khali@linux-fr.org, lm-sensors@lm-sensors.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] applesmc oops in 3.10/3.11
Date: Tue, 08 Oct 2013 15:48:09 +0000 [thread overview]
Message-ID: <20131008154809.GB18402@roeck-us.net> (raw)
In-Reply-To: <6918F624-B267-4DB5-95A2-7E09448CA3E4@colorremedies.com>
On Mon, Oct 07, 2013 at 05:46:55PM -0600, Chris Murphy wrote:
>
> On Oct 7, 2013, at 5:42 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>
> > On 10/02/2013 10:24 AM, Henrik Rydberg wrote:
> >
> >>> From 4451da32414080bd0563ee9e061f19bf90463cc5 Mon Sep 17 00:00:00 2001
> >> From: Henrik Rydberg <rydberg@euromail.se>
> >> Date: Wed, 2 Oct 2013 19:15:03 +0200
> >> Subject: [PATCH] applesmc remedy take 2
> >>
> >> Conjectured problem: there are remnant bytes ready on the data line
> >> which corrupts the read after a failure.
> >>
> >> Remedy: assuming bit0 is the read valid line, try to flush it before
> >> starting a new command.
> >>
> >> Tests by Chris suggests reading the status is enough for the problem
> >> to go away, which is consistent with a change in the SMC interface,
> >> where the number of bytes to read is no longer specified, but found
> >> out by reading until end of data.
> >>
> >> Tested on a MacBookAir3,1, but the original problem has not been
> >> reproduced.
> >
> > So, what should we do with this patch ? Apply it ?
>
> So far I'm getting nothing on the original machine. As of today it's applied as the last patch on 3.12.0-0.rc4.git0.1.fc20.x86_64. Unfortunately at the moment I'm a bit too dense to figure out how to get a new kernel applied to an existing live package so I can try this on a USB stick. While maybe unrelated, the oops was occurring at least 4x as often booted from USB stick media than HDD.
>
Seems to me we should apply it.
Henrik,
what do you think ? Did you have time for additional testing ?
If you think we should apply it, please send me a signed patch.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2013-10-08 15:48 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 19:06 applesmc oops in 3.10/3.11 Josh Boyer
2013-09-25 19:06 ` [lm-sensors] " Josh Boyer
2013-09-25 19:56 ` Guenter Roeck
2013-09-25 19:56 ` [lm-sensors] " Guenter Roeck
2013-09-25 21:48 ` Henrik Rydberg
2013-09-25 21:48 ` [lm-sensors] " Henrik Rydberg
2013-09-25 22:08 ` Guenter Roeck
2013-09-25 22:08 ` [lm-sensors] " Guenter Roeck
2013-09-26 6:34 ` Henrik Rydberg
2013-09-26 6:34 ` [lm-sensors] " Henrik Rydberg
2013-09-26 10:36 ` Guenter Roeck
2013-09-26 10:36 ` [lm-sensors] " Guenter Roeck
2013-09-26 11:13 ` Henrik Rydberg
2013-09-26 11:13 ` [lm-sensors] " Henrik Rydberg
2013-09-26 10:53 ` Guenter Roeck
2013-09-26 10:53 ` [lm-sensors] " Guenter Roeck
2013-09-26 11:11 ` Henrik Rydberg
2013-09-26 11:11 ` [lm-sensors] " Henrik Rydberg
2013-09-27 16:21 ` Josh Boyer
2013-09-27 16:21 ` [lm-sensors] " Josh Boyer
2013-09-27 17:12 ` Guenter Roeck
2013-09-27 17:12 ` [lm-sensors] " Guenter Roeck
2013-09-27 17:41 ` Chris Murphy
2013-09-27 17:41 ` [lm-sensors] " Chris Murphy
2013-09-27 17:59 ` Guenter Roeck
2013-09-27 17:59 ` [lm-sensors] " Guenter Roeck
2013-09-27 18:03 ` Chris Murphy
2013-09-27 18:03 ` [lm-sensors] " Chris Murphy
2013-09-27 23:33 ` Guenter Roeck
2013-09-27 23:33 ` [lm-sensors] " Guenter Roeck
2013-10-01 1:57 ` Chris Murphy
2013-10-01 1:57 ` [lm-sensors] " Chris Murphy
2013-10-01 3:37 ` Guenter Roeck
2013-10-01 3:37 ` [lm-sensors] " Guenter Roeck
2013-10-01 10:55 ` Henrik Rydberg
2013-10-01 10:55 ` [lm-sensors] " Henrik Rydberg
2013-10-01 15:19 ` Guenter Roeck
2013-10-01 15:19 ` [lm-sensors] " Guenter Roeck
2013-10-01 15:33 ` Chris Murphy
2013-10-01 15:33 ` [lm-sensors] " Chris Murphy
2013-10-01 16:24 ` Guenter Roeck
2013-10-01 16:24 ` [lm-sensors] " Guenter Roeck
2013-10-02 1:09 ` Chris Murphy
2013-10-02 1:09 ` [lm-sensors] " Chris Murphy
2013-10-02 3:51 ` Guenter Roeck
2013-10-02 3:51 ` [lm-sensors] " Guenter Roeck
2013-10-02 3:55 ` Chris Murphy
2013-10-02 3:55 ` [lm-sensors] " Chris Murphy
2013-10-02 4:02 ` Guenter Roeck
2013-10-02 4:02 ` [lm-sensors] " Guenter Roeck
2013-10-02 9:53 ` Henrik Rydberg
2013-10-02 9:53 ` [lm-sensors] " Henrik Rydberg
2013-10-02 13:30 ` Guenter Roeck
2013-10-02 13:30 ` [lm-sensors] " Guenter Roeck
2013-10-02 16:34 ` Henrik Rydberg
2013-10-02 16:34 ` [lm-sensors] " Henrik Rydberg
2013-10-02 16:47 ` Guenter Roeck
2013-10-02 16:47 ` [lm-sensors] " Guenter Roeck
2013-10-02 17:24 ` Henrik Rydberg
2013-10-02 17:24 ` [lm-sensors] " Henrik Rydberg
2013-10-02 18:02 ` Guenter Roeck
2013-10-02 18:02 ` [lm-sensors] " Guenter Roeck
2013-10-02 18:33 ` Chris Murphy
2013-10-02 18:33 ` [lm-sensors] " Chris Murphy
2013-10-02 20:59 ` Guenter Roeck
2013-10-02 20:59 ` [lm-sensors] " Guenter Roeck
2013-10-02 21:34 ` Chris Murphy
2013-10-02 21:34 ` [lm-sensors] " Chris Murphy
2013-10-02 23:32 ` Guenter Roeck
2013-10-02 23:32 ` [lm-sensors] " Guenter Roeck
2013-10-07 23:42 ` Guenter Roeck
2013-10-07 23:42 ` [lm-sensors] " Guenter Roeck
2013-10-07 23:46 ` Chris Murphy
2013-10-07 23:46 ` [lm-sensors] " Chris Murphy
2013-10-08 15:48 ` Guenter Roeck [this message]
2013-10-08 15:48 ` Guenter Roeck
2013-10-08 16:29 ` Henrik Rydberg
2013-10-08 16:29 ` [lm-sensors] " Henrik Rydberg
2013-10-08 16:29 ` Guenter Roeck
2013-10-08 16:29 ` [lm-sensors] " Guenter Roeck
2013-10-09 8:29 ` Henrik Rydberg
2013-10-09 8:29 ` [lm-sensors] " Henrik Rydberg
2013-10-09 16:52 ` Guenter Roeck
2013-10-09 16:52 ` [lm-sensors] " Guenter Roeck
2013-09-27 18:01 ` Guenter Roeck
2013-09-27 18:01 ` [lm-sensors] " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008154809.GB18402@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bugzilla@colorremedies.com \
--cc=jwboyer@fedoraproject.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.