From: Fengguang Wu <fengguang.wu@intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Peter Zijlstra <peterz@infradead.org>,
Oleg Nesterov <oleg@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug
Date: Fri, 11 Oct 2013 12:35:53 +0800 [thread overview]
Message-ID: <20131011043553.GA9015@localhost> (raw)
In-Reply-To: <20131010151219.GC5167@gmail.com>
On Thu, Oct 10, 2013 at 05:12:19PM +0200, Ingo Molnar wrote:
>
> * Jakub Jelinek <jakub@redhat.com> wrote:
>
> > On Thu, Oct 10, 2013 at 07:04:18AM -0700, Richard Henderson wrote:
> > > On 10/10/2013 01:31 AM, Jakub Jelinek wrote:
> > > > Also, for the bitops patch, you probably want an asm_volatile_goto variant.
> > >
> > > Why? Asm without output (which asm goto must be) are automatically volatile.
> >
> > You're right.
>
> Indeed. Something like the updated version below?
>
> [ I kept the asm_volatile_goto() naming to make sure the implicit volatile
> is visible. ]
Ingo, I applied this patch (as commit c015a7f0b746) on top of
tip/sched/core
3354781a2184 "sched/numa: Reflow task_numa_group() to avoid a compiler warning"
The below results show that it does fixed the many oops:
/kernel/i386-randconfig-i005-1008/c015a7f0b746d0a7e18b82876bd2b693722479d2
+--------------------------------------------------------------+--------------+--------------+
| | 3354781a2184 | c015a7f0b746 |
+--------------------------------------------------------------+--------------+--------------+
| WARNING:CPU:PID:at_fs/sysfs/dir.c:sysfs_add_one() | 9 | |
| WARNING:CPU:PID:at_lib/kobject.c:kobject_add_internal() | 9 | |
| WARNING:CPU:PID:at_drivers/base/driver.c:driver_unregister() | 9 | |
| WARNING:CPU:PID:at_lib/list_debug.c:__list_add() | 9 | |
| kernel_BUG_at_kernel/timer.c | 9 | |
| invalid_opcode:PREEMPT_SMP | 9 | |
| Kernel_panic-not_syncing:Fatal_exception_in_interrupt | 9 | |
| good_boots | 0 | 9 |
+--------------------------------------------------------------+--------------+--------------+
/kernel/i386-randconfig-r4-1009/c015a7f0b746d0a7e18b82876bd2b693722479d2
+--------------------------------------------------------------+--------------+--------------+
| | 3354781a2184 | c015a7f0b746 |
+--------------------------------------------------------------+--------------+--------------+
| BUG:kernel_early_hang_without_any_printk_output | 2 | 3 |
| WARNING:CPU:PID:at_fs/sysfs/dir.c:sysfs_add_one() | 7 | |
| WARNING:CPU:PID:at_lib/kobject.c:kobject_add_internal() | 7 | |
| WARNING:CPU:PID:at_drivers/base/driver.c:driver_unregister() | 7 | |
| WARNING:CPU:PID:at_lib/debugobjects.c:debug_print_object() | 7 | |
| INFO:trying_to_register_non-static_key | 7 | |
| kernel_BUG_at_kernel/timer.c | 7 | |
| invalid_opcode:SMP | 7 | |
| Kernel_panic-not_syncing:Fatal_exception_in_interrupt | 7 | |
| good_boots | 0 | 6 |
+--------------------------------------------------------------+--------------+--------------+
/kernel/i386-randconfig-r8-1005/c015a7f0b746d0a7e18b82876bd2b693722479d2
+---------------------------------------------------------------+--------------+--------------+
| | 3354781a2184 | c015a7f0b746 |
+---------------------------------------------------------------+--------------+--------------+
| BUG:unable_to_handle_kernel_NULL_pointer_dereference_at | 1 | |
| Oops:DEBUG_PAGEALLOC | 9 | |
| kernel_BUG_at_kernel/cred.c | 1 | |
| invalid_opcode:DEBUG_PAGEALLOC | 1 | |
| Kernel_panic-not_syncing:CRED:put_cred_rcu()sees_with_usage | 4 | |
| BUG:unable_to_handle_kernel_paging_request_at | 3 | |
| BUG:unable_to_handle_kernel_NULL_pointer_dereference_at(null) | 5 | |
| good_boots | 0 | 9 |
+---------------------------------------------------------------+--------------+--------------+
However it seems that it leads to or increases the chances of early
boot hang:
/kernel/x86_64-randconfig-a1-1009/c015a7f0b746d0a7e18b82876bd2b693722479d2
+-------------------------------------------------+--------------+--------------+
| | 3354781a2184 | c015a7f0b746 |
+-------------------------------------------------+--------------+--------------+
| good_boots | 9 | 8 |
| BUG:kernel_early_hang_without_any_printk_output | 0 | 1 |
+-------------------------------------------------+--------------+--------------+
/kernel/x86_64-randconfig-a5-1009/c015a7f0b746d0a7e18b82876bd2b693722479d2
+-------------------------------------------------+--------------+--------------+
| | 3354781a2184 | c015a7f0b746 |
+-------------------------------------------------+--------------+--------------+
| good_boots | 9 | 8 |
| BUG:kernel_early_hang_without_any_printk_output | 0 | 1 |
+-------------------------------------------------+--------------+--------------+
/kernel/i386-randconfig-r1-1009/c015a7f0b746d0a7e18b82876bd2b693722479d2
+-------------------------------------------------+--------------+--------------+
| | 3354781a2184 | c015a7f0b746 |
+-------------------------------------------------+--------------+--------------+
| BUG:kernel_early_hang_without_any_printk_output | 9 | 9 |
+-------------------------------------------------+--------------+--------------+
/kernel/i386-randconfig-r7-1009/c015a7f0b746d0a7e18b82876bd2b693722479d2
+--------------------------------------------------+--------------+--------------+
| | 3354781a2184 | c015a7f0b746 |
+--------------------------------------------------+--------------+--------------+
| BUG:soft_lockup-CPU_stuck_for_s | 1 | |
| INFO:task_blocked_for_more_than_seconds | 8 | 8 |
| Kernel_panic-not_syncing:hung_task:blocked_tasks | 8 | 8 |
| BUG:kernel_early_hang_without_any_printk_output | 0 | 1 |
+--------------------------------------------------+--------------+--------------+
/kernel/i386-randconfig-r5-1009/c015a7f0b746d0a7e18b82876bd2b693722479d2
+-------------------------------------------------+--------------+--------------+
| | 3354781a2184 | c015a7f0b746 |
+-------------------------------------------------+--------------+--------------+
| BUG:kernel_early_hang_without_any_printk_output | 9 | 9 |
+-------------------------------------------------+--------------+--------------+
/kernel/i386-randconfig-i008-1008/c015a7f0b746d0a7e18b82876bd2b693722479d2
+-------------------------------------------------+--------------+--------------+
| | 3354781a2184 | c015a7f0b746 |
+-------------------------------------------------+--------------+--------------+
| BUG:kernel_early_hang_without_any_printk_output | 9 | 9 |
+-------------------------------------------------+--------------+--------------+
/kernel/i386-randconfig-i006-1008/c015a7f0b746d0a7e18b82876bd2b693722479d2
+-------------------------------------------------+--------------+--------------+
| | 3354781a2184 | c015a7f0b746 |
+-------------------------------------------------+--------------+--------------+
| good_boots | 9 | 7 |
| BUG:kernel_early_hang_without_any_printk_output | 0 | 2 |
+-------------------------------------------------+--------------+--------------+
Thanks,
Fengguang
next prev parent reply other threads:[~2013-10-11 4:36 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 23:44 [x86] BUG: unable to handle kernel paging request at 00740060 Fengguang Wu
2013-10-05 23:47 ` [x86] BUG: unable to handle kernel paging request at 08000060 Fengguang Wu
2013-10-06 7:27 ` Mike Galbraith
2013-10-06 7:36 ` Fengguang Wu
2013-10-07 8:49 ` Peter Zijlstra
2013-10-07 9:17 ` Fengguang Wu
2013-10-07 9:36 ` Peter Zijlstra
2013-10-07 9:46 ` Fengguang Wu
2013-10-07 8:55 ` [x86] BUG: unable to handle kernel paging request at 00740060 Peter Zijlstra
2013-10-07 9:08 ` Peter Zijlstra
2013-10-07 11:32 ` Fengguang Wu
2013-10-07 9:27 ` Fengguang Wu
2013-10-07 18:47 ` Linus Torvalds
2013-10-08 7:51 ` Fengguang Wu
2013-10-08 16:21 ` Linus Torvalds
2013-10-08 17:15 ` [x86] BUG: unable to handle kernel NULL pointer dereference at (null) Fengguang Wu
2013-10-08 17:31 ` Linus Torvalds
2013-10-09 1:09 ` Fengguang Wu
2013-10-09 1:33 ` Linus Torvalds
2013-10-08 18:51 ` [x86] BUG: unable to handle kernel paging request at 00740060 Oleg Nesterov
2013-10-08 19:05 ` Jakub Jelinek
2013-10-08 19:20 ` Linus Torvalds
2013-10-08 19:34 ` Linus Torvalds
2013-10-08 19:35 ` Oleg Nesterov
2013-10-08 19:49 ` Linus Torvalds
2013-10-09 1:43 ` Mike Galbraith
2013-10-08 19:05 ` Linus Torvalds
2013-10-08 16:46 ` Oleg Nesterov
2013-10-08 14:34 ` Oleg Nesterov
2013-10-09 8:04 ` Fengguang Wu
2013-10-09 12:19 ` Fengguang Wu
2013-10-09 12:21 ` Fengguang Wu
2013-10-09 12:27 ` Peter Zijlstra
2013-10-09 12:52 ` Ingo Molnar
2013-10-09 17:18 ` Ingo Molnar
2013-10-10 2:15 ` Mike Galbraith
2013-10-09 12:56 ` Fengguang Wu
2013-10-09 12:43 ` Oleg Nesterov
2013-10-09 14:07 ` Peter Zijlstra
2013-10-09 14:17 ` Oleg Nesterov
2013-10-09 14:32 ` Ingo Molnar
2013-10-09 14:33 ` Peter Zijlstra
2013-10-09 14:46 ` Peter Zijlstra
2013-10-09 18:16 ` Jakub Jelinek
2013-10-09 18:54 ` Linus Torvalds
2013-10-09 19:02 ` Peter Zijlstra
2013-10-09 19:08 ` Jakub Jelinek
2013-10-10 6:22 ` Ingo Molnar
2013-10-10 6:51 ` Jakub Jelinek
2013-10-10 8:04 ` Jakub Jelinek
2013-10-10 8:24 ` [PATCH] gcc4: Add 'asm goto' miscompilation quirk Ingo Molnar
2013-10-10 8:31 ` Jakub Jelinek
2013-10-10 8:45 ` Ingo Molnar
2013-10-10 8:55 ` [PATCH, -v2] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug Ingo Molnar
2013-10-10 11:56 ` Peter Zijlstra
2013-10-10 12:32 ` Jakub Jelinek
2013-10-10 13:10 ` Peter Zijlstra
2013-10-10 15:04 ` Ingo Molnar
2013-10-10 14:04 ` [PATCH] gcc4: Add 'asm goto' miscompilation quirk Richard Henderson
2013-10-10 14:27 ` Jakub Jelinek
2013-10-10 15:12 ` [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug Ingo Molnar
2013-10-10 16:15 ` Richard Henderson
2013-10-10 16:49 ` Ingo Molnar
2013-10-11 4:35 ` Fengguang Wu [this message]
2013-10-11 5:46 ` Ingo Molnar
2013-10-11 6:51 ` Fengguang Wu
2013-10-11 9:30 ` Fengguang Wu
2013-10-12 17:03 ` Ingo Molnar
2013-10-10 8:34 ` [PATCH] gcc4: Add 'asm goto' miscompilation quirk Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011043553.GA9015@localhost \
--to=fengguang.wu@intel.com \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rth@twiddle.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.