From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 14/16] drm/i915: Add watermark tracepoints
Date: Tue, 15 Oct 2013 10:43:31 +0200 [thread overview]
Message-ID: <20131015084331.GB4830@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGTVa8MiGUvoup4n11p4=9zZZREekOgAGOB0aqAZyzBgdw@mail.gmail.com>
On Fri, Oct 11, 2013 at 04:40:24PM -0300, Paulo Zanoni wrote:
> 2013/10/9 <ville.syrjala@linux.intel.com>:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > We may want to know what kind of watermarks got computed and programmed
> > into the hardware. Using tracepoints is much leaner than debug prints.
> >
> > Also add trace call for the watermark state we read out of the
> > hardware during init, though I;m not sure there's any way to see that
> > trace as the events aren't available until the module is loaded.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I never worked with these things before, but on a quick look it all sounds sane.
>
> Acked-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
I'm not sold on tracepoints being the right tool here. DRM_DEBUG_KMS
probably isn't it, since that would needlessly spam dmesg since it's way
too coarse. But the kernel has this neat dynamic debug subsystem, which
has the upshot that it's all nicely inline with the other modeset debug
noise in dmesg.
I'll punt on this for now.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-10-15 8:43 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 16:17 [PATCH 00/16] drm/i915: More HSW watermark prep work v2 ville.syrjala
2013-10-09 16:17 ` [PATCH v2 01/16] drm/i915: Add intel_pipe_wm and prepare for watermark pre-compute ville.syrjala
2013-10-10 21:43 ` Paulo Zanoni
2013-10-11 8:07 ` Ville Syrjälä
2013-10-11 13:51 ` Paulo Zanoni
2013-10-09 16:17 ` [PATCH 02/16] drm/i915: Don't re-compute pipe watermarks except for the affected pipe ville.syrjala
2013-10-10 21:57 ` Paulo Zanoni
2013-10-09 16:17 ` [PATCH 03/16] drm/i915: Move LP1+ watermark merging out from hsw_compute_wm_results() ville.syrjala
2013-10-10 22:04 ` Paulo Zanoni
2013-10-09 16:17 ` [PATCH 04/16] drm/i915: Use intel_pipe_wm in hsw_find_best_results ville.syrjala
2013-10-10 22:20 ` Paulo Zanoni
2013-10-09 16:17 ` [PATCH 05/16] drm/i915: Move some computations out from hsw_compute_wm_parameters() ville.syrjala
2013-10-10 22:34 ` Paulo Zanoni
2013-10-11 8:26 ` Ville Syrjälä
2013-10-11 12:26 ` [PATCH 17/16] drm/i915: Check 5/6 DDB split only when sprites are enabled ville.syrjala
2013-10-11 17:21 ` Paulo Zanoni
2013-10-11 13:53 ` [PATCH 05/16] drm/i915: Move some computations out from hsw_compute_wm_parameters() Paulo Zanoni
2013-10-09 16:18 ` [PATCH 06/16] drm/i915: Don't compute 5/6 DDB split w/ zero active pipes ville.syrjala
2013-10-10 22:38 ` Paulo Zanoni
2013-10-09 16:18 ` [PATCH 07/16] drm/i915: Refactor wm_lp to level calculation ville.syrjala
2013-10-10 22:42 ` Paulo Zanoni
2013-10-11 8:10 ` Ville Syrjälä
2013-10-09 16:18 ` [PATCH 08/16] drm/i915: Kill fbc_wm_enabled from intel_wm_config ville.syrjala
2013-10-10 22:45 ` Paulo Zanoni
2013-10-09 16:18 ` [PATCH 09/16] drm/i915: Store current watermark state in dev_priv->wm ville.syrjala
2013-10-11 14:21 ` Paulo Zanoni
2013-10-15 8:24 ` Daniel Vetter
2013-10-15 16:49 ` Paulo Zanoni
2013-10-09 16:18 ` [PATCH 10/16] drm/i915: Improve watermark dirtyness checks ville.syrjala
2013-10-11 15:02 ` Paulo Zanoni
2013-10-11 15:48 ` Ville Syrjälä
2013-10-11 16:12 ` Paulo Zanoni
2013-10-11 16:39 ` [PATCH v2 " ville.syrjala
2013-10-11 17:57 ` Paulo Zanoni
2013-10-09 16:18 ` [PATCH 11/16] drm/i915: Init HSW watermark tracking in intel_modeset_setup_hw_state() ville.syrjala
2013-10-11 16:45 ` Paulo Zanoni
2013-10-11 17:15 ` Ville Syrjälä
2013-10-11 18:15 ` Paulo Zanoni
2013-10-11 19:12 ` Ville Syrjälä
2013-10-11 19:46 ` Paulo Zanoni
2013-10-14 11:21 ` Ville Syrjälä
2013-10-14 11:55 ` [PATCH v2 " ville.syrjala
2013-10-14 13:56 ` Paulo Zanoni
2013-10-09 16:18 ` [PATCH 12/16] drm/i915: Remove a somewhat silly debug print from watermark code ville.syrjala
2013-10-11 16:48 ` Paulo Zanoni
2013-10-09 16:18 ` [PATCH v2 13/16] drm/i915: Adjust watermark register masks ville.syrjala
2013-10-11 17:02 ` Paulo Zanoni
2013-10-09 16:18 ` [PATCH 14/16] drm/i915: Add watermark tracepoints ville.syrjala
2013-10-11 19:40 ` Paulo Zanoni
2013-10-15 8:43 ` Daniel Vetter [this message]
2013-10-15 10:11 ` Ville Syrjälä
2013-10-15 10:59 ` Daniel Vetter
2013-10-09 16:18 ` [PATCH 15/16] drm/i915: Rename ilk_wm_max to ilk_compute_wm_maximums ville.syrjala
2013-10-11 17:07 ` Paulo Zanoni
2013-10-09 16:18 ` [PATCH 16/16] drm/i915: Rename ilk_check_wm to ilk_validate_wm_level ville.syrjala
2013-10-11 17:08 ` Paulo Zanoni
2013-10-15 9:16 ` Daniel Vetter
2013-10-15 17:01 ` Paulo Zanoni
2013-10-15 17:46 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015084331.GB4830@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.