From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Vasily Isaenko <vasily.isaenko@oracle.com>,
linux-nfs@vger.kernel.org, xfs@oss.sgi.com,
"Sachin S. Prabhu" <sprabhu@redhat.com>,
Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Subject: Re: nfs vs xfstests 193
Date: Fri, 6 Dec 2013 15:47:47 -0500 [thread overview]
Message-ID: <20131206204747.GB12613@fieldses.org> (raw)
In-Reply-To: <20131206204404.GA12613@fieldses.org>
On Fri, Dec 06, 2013 at 03:44:04PM -0500, bfields wrote:
> On Fri, Dec 06, 2013 at 10:08:58AM -0800, Christoph Hellwig wrote:
> > On Fri, Dec 06, 2013 at 05:20:34PM +0400, Stanislav Kholmanskikh wrote:
> > > Just to make the behaviour more consistent between NFS and other
> > > "local" file systems as It was done by
> > > commit https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=0953e620de0538cbd081f1b45126f6098112a598
> >
> > Seems like we got others in line with XFS behavior.
>
> But, not having tested the behavior, it looks like fs/open.c has a
> simlar !S_ISDIR() check. Where's that behavior implemented?
>
> > I'd prefer to have NFS follow this as well.
>
> Huh. Sachin, do you remember if there was any other motivation behind
> that patch?
Never mind, I see, the complaint is about the case where the id's don't
change, not about the directory case. So Sachin's
0953e620de0538cbd081f1b45126f6098112a598 doesn't actually have anything
to do with this.
I'm fine with removing the id comparisons and changing the nfsd behavior
to match local filesystems.
--b.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>,
xfs@oss.sgi.com, linux-nfs@vger.kernel.org,
Vasily Isaenko <vasily.isaenko@oracle.com>,
"Sachin S. Prabhu" <sprabhu@redhat.com>
Subject: Re: nfs vs xfstests 193
Date: Fri, 6 Dec 2013 15:47:47 -0500 [thread overview]
Message-ID: <20131206204747.GB12613@fieldses.org> (raw)
In-Reply-To: <20131206204404.GA12613@fieldses.org>
On Fri, Dec 06, 2013 at 03:44:04PM -0500, bfields wrote:
> On Fri, Dec 06, 2013 at 10:08:58AM -0800, Christoph Hellwig wrote:
> > On Fri, Dec 06, 2013 at 05:20:34PM +0400, Stanislav Kholmanskikh wrote:
> > > Just to make the behaviour more consistent between NFS and other
> > > "local" file systems as It was done by
> > > commit https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=0953e620de0538cbd081f1b45126f6098112a598
> >
> > Seems like we got others in line with XFS behavior.
>
> But, not having tested the behavior, it looks like fs/open.c has a
> simlar !S_ISDIR() check. Where's that behavior implemented?
>
> > I'd prefer to have NFS follow this as well.
>
> Huh. Sachin, do you remember if there was any other motivation behind
> that patch?
Never mind, I see, the complaint is about the case where the id's don't
change, not about the directory case. So Sachin's
0953e620de0538cbd081f1b45126f6098112a598 doesn't actually have anything
to do with this.
I'm fine with removing the id comparisons and changing the nfsd behavior
to match local filesystems.
--b.
next prev parent reply other threads:[~2013-12-06 20:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 11:56 nfs vs xfstests 193 Christoph Hellwig
2013-11-06 11:56 ` Christoph Hellwig
2013-12-06 13:20 ` Stanislav Kholmanskikh
2013-12-06 13:20 ` Stanislav Kholmanskikh
2013-12-06 18:08 ` Christoph Hellwig
2013-12-06 18:08 ` Christoph Hellwig
2013-12-06 20:44 ` J. Bruce Fields
2013-12-06 20:44 ` J. Bruce Fields
2013-12-06 20:47 ` J. Bruce Fields [this message]
2013-12-06 20:47 ` J. Bruce Fields
2013-12-10 14:43 ` Stanislav Kholmanskikh
2013-12-10 14:43 ` Stanislav Kholmanskikh
2013-12-11 10:16 ` [PATCH] nfsd: revoking of suid/sgid bits after chown() in a consistent way Stanislav Kholmanskikh
2013-12-11 10:16 ` Stanislav Kholmanskikh
2013-12-11 11:00 ` Stanislav Kholmanskikh
2013-12-11 11:00 ` Stanislav Kholmanskikh
2013-12-12 3:38 ` J. Bruce Fields
2013-12-12 3:38 ` J. Bruce Fields
2013-12-12 8:13 ` Christoph Hellwig
2013-12-12 8:13 ` Christoph Hellwig
2013-12-12 11:44 ` Stanislav Kholmanskikh
2013-12-12 11:44 ` Stanislav Kholmanskikh
2013-12-12 16:01 ` J. Bruce Fields
2013-12-12 16:01 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206204747.GB12613@fieldses.org \
--to=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sprabhu@redhat.com \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.