All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: linux-nfs@vger.kernel.org
Cc: vasily.isaenko@oracle.com, hch@infradead.org, sprabhu@redhat.com,
	bfields@fieldses.org, xfs@oss.sgi.com
Subject: Re: [PATCH] nfsd: revoking of suid/sgid bits after chown() in a consistent way
Date: Wed, 11 Dec 2013 15:00:22 +0400	[thread overview]
Message-ID: <52A845C6.2080109@oracle.com> (raw)
In-Reply-To: <1386756996-28083-1-git-send-email-stanislav.kholmanskikh@oracle.com>



On 12/11/2013 02:16 PM, Stanislav Kholmanskikh wrote:
[cut off]
>
> This patch makes NFS to behave like local file systems.
>
[cut off]

This patch allows to run generic/193 without any issues with NFSv3.

With NFSv4 generic/193 fails (but with the other issues, which existed 
even before the patch).

generic/193 expects that suid/sgid bits are cleared after the file 
truncation:

touch file
chown fsgqa:fsgqa file
chmod u+s file
echo 'xyz' > file
ls -l file
su fsgqa -c 'echo > file'
ls -l file

With ext4 (for example), we have expectable results:
-rwSr--r-- 1 fsgqa fsgqa 4 Dec 11 05:21 file
-rw-r--r-- 1 fsgqa fsgqa 1 Dec 11 05:22 file

With NFSv3 as well:
-rwSr--r-- 1 fsgqa fsgqa 4 Dec 11 05:24 file
-rw-r--r-- 1 fsgqa fsgqa 1 Dec 11 05:25 file

But with NFSv4 the bits are not cleared:
-rwSr--r-- 1 fsgqa fsgqa 1 Dec 11 05:19 file
-rwSr--r-- 1 fsgqa fsgqa 1 Dec 11 05:21 file

'echo > file' issues:

open("file", O_WRONLY|O_CREAT|O_TRUNC, 0666)

Can it be because of design differences between NFSv3 and NFSv4?

Thank you.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: linux-nfs@vger.kernel.org
Cc: vasily.isaenko@oracle.com, hch@infradead.org, xfs@oss.sgi.com,
	sprabhu@redhat.com, bfields@fieldses.org
Subject: Re: [PATCH] nfsd: revoking of suid/sgid bits after chown() in a consistent way
Date: Wed, 11 Dec 2013 15:00:22 +0400	[thread overview]
Message-ID: <52A845C6.2080109@oracle.com> (raw)
In-Reply-To: <1386756996-28083-1-git-send-email-stanislav.kholmanskikh@oracle.com>



On 12/11/2013 02:16 PM, Stanislav Kholmanskikh wrote:
[cut off]
>
> This patch makes NFS to behave like local file systems.
>
[cut off]

This patch allows to run generic/193 without any issues with NFSv3.

With NFSv4 generic/193 fails (but with the other issues, which existed 
even before the patch).

generic/193 expects that suid/sgid bits are cleared after the file 
truncation:

touch file
chown fsgqa:fsgqa file
chmod u+s file
echo 'xyz' > file
ls -l file
su fsgqa -c 'echo > file'
ls -l file

With ext4 (for example), we have expectable results:
-rwSr--r-- 1 fsgqa fsgqa 4 Dec 11 05:21 file
-rw-r--r-- 1 fsgqa fsgqa 1 Dec 11 05:22 file

With NFSv3 as well:
-rwSr--r-- 1 fsgqa fsgqa 4 Dec 11 05:24 file
-rw-r--r-- 1 fsgqa fsgqa 1 Dec 11 05:25 file

But with NFSv4 the bits are not cleared:
-rwSr--r-- 1 fsgqa fsgqa 1 Dec 11 05:19 file
-rwSr--r-- 1 fsgqa fsgqa 1 Dec 11 05:21 file

'echo > file' issues:

open("file", O_WRONLY|O_CREAT|O_TRUNC, 0666)

Can it be because of design differences between NFSv3 and NFSv4?

Thank you.

  reply	other threads:[~2013-12-11 11:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 11:56 nfs vs xfstests 193 Christoph Hellwig
2013-11-06 11:56 ` Christoph Hellwig
2013-12-06 13:20 ` Stanislav Kholmanskikh
2013-12-06 13:20   ` Stanislav Kholmanskikh
2013-12-06 18:08   ` Christoph Hellwig
2013-12-06 18:08     ` Christoph Hellwig
2013-12-06 20:44     ` J. Bruce Fields
2013-12-06 20:44       ` J. Bruce Fields
2013-12-06 20:47       ` J. Bruce Fields
2013-12-06 20:47         ` J. Bruce Fields
2013-12-10 14:43         ` Stanislav Kholmanskikh
2013-12-10 14:43           ` Stanislav Kholmanskikh
2013-12-11 10:16         ` [PATCH] nfsd: revoking of suid/sgid bits after chown() in a consistent way Stanislav Kholmanskikh
2013-12-11 10:16           ` Stanislav Kholmanskikh
2013-12-11 11:00           ` Stanislav Kholmanskikh [this message]
2013-12-11 11:00             ` Stanislav Kholmanskikh
2013-12-12  3:38             ` J. Bruce Fields
2013-12-12  3:38               ` J. Bruce Fields
2013-12-12  8:13               ` Christoph Hellwig
2013-12-12  8:13                 ` Christoph Hellwig
2013-12-12 11:44               ` Stanislav Kholmanskikh
2013-12-12 11:44                 ` Stanislav Kholmanskikh
2013-12-12 16:01           ` J. Bruce Fields
2013-12-12 16:01             ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A845C6.2080109@oracle.com \
    --to=stanislav.kholmanskikh@oracle.com \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=sprabhu@redhat.com \
    --cc=vasily.isaenko@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.