From: Ludovic Desroches <ludovic.desroches@atmel.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<linux-mmc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <iamjoonsoo.kim@lge.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: Re: possible regression on 3.13 when calling flush_dcache_page
Date: Mon, 16 Dec 2013 11:49:27 +0100 [thread overview]
Message-ID: <20131216104927.GA9627@ldesroches-Latitude-E6320> (raw)
In-Reply-To: <20131212171322.GT4360@n2100.arm.linux.org.uk>
On Thu, Dec 12, 2013 at 05:13:22PM +0000, Russell King - ARM Linux wrote:
> On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote:
> > I'll investigate on atmel-mci driver side but if someone has also this
> > issue or see what is wrong in the driver, please tell me all about it.
>
> I'm not entirely sure what's causing this, but calling flush_dcache_page()
> from an IRQ isn't the best idea, as one of its side effects will be to
> unmask IRQs at the CPU.
>
Thans for pointing this point. Having a look to other mmc drivers, it
seems flush_dcache_page() is also called from an IRQ. Not sure that
deferring it is the way to go.
What should be the most proper solution?
> BTW, the faulting function seems to have been removed in more recent
> kernels.
Same error with rc4 and linux-next.
WARNING: multiple messages have this Message-ID (diff)
From: Ludovic Desroches <ludovic.desroches@atmel.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
iamjoonsoo.kim@lge.com,
Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: Re: possible regression on 3.13 when calling flush_dcache_page
Date: Mon, 16 Dec 2013 11:49:27 +0100 [thread overview]
Message-ID: <20131216104927.GA9627@ldesroches-Latitude-E6320> (raw)
In-Reply-To: <20131212171322.GT4360@n2100.arm.linux.org.uk>
On Thu, Dec 12, 2013 at 05:13:22PM +0000, Russell King - ARM Linux wrote:
> On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote:
> > I'll investigate on atmel-mci driver side but if someone has also this
> > issue or see what is wrong in the driver, please tell me all about it.
>
> I'm not entirely sure what's causing this, but calling flush_dcache_page()
> from an IRQ isn't the best idea, as one of its side effects will be to
> unmask IRQs at the CPU.
>
Thans for pointing this point. Having a look to other mmc drivers, it
seems flush_dcache_page() is also called from an IRQ. Not sure that
deferring it is the way to go.
What should be the most proper solution?
> BTW, the faulting function seems to have been removed in more recent
> kernels.
Same error with rc4 and linux-next.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: ludovic.desroches@atmel.com (Ludovic Desroches)
To: linux-arm-kernel@lists.infradead.org
Subject: possible regression on 3.13 when calling flush_dcache_page
Date: Mon, 16 Dec 2013 11:49:27 +0100 [thread overview]
Message-ID: <20131216104927.GA9627@ldesroches-Latitude-E6320> (raw)
In-Reply-To: <20131212171322.GT4360@n2100.arm.linux.org.uk>
On Thu, Dec 12, 2013 at 05:13:22PM +0000, Russell King - ARM Linux wrote:
> On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote:
> > I'll investigate on atmel-mci driver side but if someone has also this
> > issue or see what is wrong in the driver, please tell me all about it.
>
> I'm not entirely sure what's causing this, but calling flush_dcache_page()
> from an IRQ isn't the best idea, as one of its side effects will be to
> unmask IRQs at the CPU.
>
Thans for pointing this point. Having a look to other mmc drivers, it
seems flush_dcache_page() is also called from an IRQ. Not sure that
deferring it is the way to go.
What should be the most proper solution?
> BTW, the faulting function seems to have been removed in more recent
> kernels.
Same error with rc4 and linux-next.
next prev parent reply other threads:[~2013-12-16 10:49 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 14:31 possible regression on 3.13 when calling flush_dcache_page Ludovic Desroches
2013-12-12 14:31 ` Ludovic Desroches
2013-12-12 14:31 ` Ludovic Desroches
2013-12-12 14:36 ` Ludovic Desroches
2013-12-12 14:36 ` Ludovic Desroches
2013-12-12 14:36 ` Ludovic Desroches
2013-12-12 14:36 ` Ludovic Desroches
2013-12-13 1:59 ` Joonsoo Kim
2013-12-13 1:59 ` Joonsoo Kim
2013-12-13 1:59 ` Joonsoo Kim
2013-12-16 14:43 ` Ludovic Desroches
2013-12-16 14:43 ` Ludovic Desroches
2013-12-16 14:43 ` Ludovic Desroches
2013-12-18 7:21 ` Joonsoo Kim
2013-12-18 7:21 ` Joonsoo Kim
2013-12-18 7:21 ` Joonsoo Kim
2013-12-20 8:08 ` Ludovic Desroches
2013-12-20 8:08 ` Ludovic Desroches
2013-12-20 8:08 ` Ludovic Desroches
2013-12-20 8:08 ` Ludovic Desroches
2013-12-23 22:44 ` Ludovic Desroches
2013-12-23 22:44 ` Ludovic Desroches
2013-12-23 22:44 ` Ludovic Desroches
2013-12-24 6:38 ` Joonsoo Kim
2013-12-24 6:38 ` Joonsoo Kim
2013-12-24 6:38 ` Joonsoo Kim
2014-01-03 14:54 ` Ludovic Desroches
2014-01-03 14:54 ` Ludovic Desroches
2014-01-03 14:54 ` Ludovic Desroches
2014-01-06 0:26 ` Joonsoo Kim
2014-01-06 0:26 ` Joonsoo Kim
2014-01-06 0:26 ` Joonsoo Kim
2014-01-06 9:34 ` Ludovic Desroches
2014-01-06 9:34 ` Ludovic Desroches
2014-01-06 9:34 ` Ludovic Desroches
2014-01-06 9:34 ` Ludovic Desroches
2014-01-09 7:16 ` Joonsoo Kim
2014-01-09 7:16 ` Joonsoo Kim
2014-01-09 7:16 ` Joonsoo Kim
2013-12-12 17:13 ` Russell King - ARM Linux
2013-12-12 17:13 ` Russell King - ARM Linux
2013-12-12 17:13 ` Russell King - ARM Linux
2013-12-16 10:49 ` Ludovic Desroches [this message]
2013-12-16 10:49 ` Ludovic Desroches
2013-12-16 10:49 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216104927.GA9627@ldesroches-Latitude-E6320 \
--to=ludovic.desroches@atmel.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.