All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	marex-ynQEQJNshbs@public.gmane.org,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCHv2 01/10] spi/spi.h: Add get_buf/put_buf support in spi master.
Date: Thu, 19 Dec 2013 13:31:05 +0000	[thread overview]
Message-ID: <20131219133105.GC31886@sirena.org.uk> (raw)
In-Reply-To: <1386339891-32717-2-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

On Fri, Dec 06, 2013 at 07:54:42PM +0530, Sourav Poddar wrote:
> Add get_buf, put_buf api support in spi master.

Please add this stuff along with the code implementing it.

> +	void	(*configure_from_slave)(struct spi_device *spi);
> +

I don't understand this API at all - it takes no parameters and doesn't
have a possibility of returning any error codes?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: marex@denx.de, devicetree@vger.kernel.org,
	computersforpeace@gmail.com, balbi@ti.com,
	linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
	bcousson@baylibre.com, linux-omap@vger.kernel.org,
	dwmw2@infradead.org
Subject: Re: [PATCHv2 01/10] spi/spi.h: Add get_buf/put_buf support in spi master.
Date: Thu, 19 Dec 2013 13:31:05 +0000	[thread overview]
Message-ID: <20131219133105.GC31886@sirena.org.uk> (raw)
In-Reply-To: <1386339891-32717-2-git-send-email-sourav.poddar@ti.com>

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

On Fri, Dec 06, 2013 at 07:54:42PM +0530, Sourav Poddar wrote:
> Add get_buf, put_buf api support in spi master.

Please add this stuff along with the code implementing it.

> +	void	(*configure_from_slave)(struct spi_device *spi);
> +

I don't understand this API at all - it takes no parameters and doesn't
have a possibility of returning any error codes?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2013-12-19 13:31 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 14:24 [PATCHv2 00/10] Add memory mapped support for ti qspi, m25p80 serial flash Sourav Poddar
2013-12-06 14:24 ` Sourav Poddar
2013-12-06 14:24 ` Sourav Poddar
2013-12-06 14:24 ` [PATCHv2 01/10] spi/spi.h: Add get_buf/put_buf support in spi master Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
     [not found]   ` <1386339891-32717-2-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-12-19 13:31     ` Mark Brown [this message]
2013-12-19 13:31       ` Mark Brown
2013-12-06 14:24 ` [PATCHv2 02/10] spi/qspi: parse register by name Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-19 13:34   ` Mark Brown
2013-12-19 13:34     ` Mark Brown
2013-12-06 14:24 ` [PATCHv2 03/10] spi/qspi: Add support to switc to memory mapped operation Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
     [not found]   ` <1386339891-32717-4-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-12-10 12:54     ` Marek Vasut
2013-12-10 12:54       ` Marek Vasut
2013-12-06 14:24 ` [PATCHv2 04/10] spi/qspi: configure set up register for memory map Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
     [not found]   ` <1386339891-32717-5-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-12-10 12:57     ` Marek Vasut
2013-12-10 12:57       ` Marek Vasut
     [not found]       ` <201312101357.54874.marex-ynQEQJNshbs@public.gmane.org>
2013-12-10 17:13         ` Sourav Poddar
2013-12-10 17:13           ` Sourav Poddar
2013-12-10 17:13           ` Sourav Poddar
2013-12-06 14:24 ` [PATCHv2 06/10] drivers: mtd: m25p80: Add api to configure master register Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
     [not found] ` <1386339891-32717-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-12-06 14:24   ` [PATCHv2 05/10] spi/qspi: Add api for get_buf/put_buf Sourav Poddar
2013-12-06 14:24     ` Sourav Poddar
2013-12-06 14:24     ` Sourav Poddar
     [not found]     ` <1386339891-32717-6-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-12-10 12:58       ` Marek Vasut
2013-12-10 12:58         ` Marek Vasut
2013-12-10 17:10         ` Sourav Poddar
2013-12-10 17:10           ` Sourav Poddar
2013-12-10 17:10           ` Sourav Poddar
2013-12-06 14:24   ` [PATCHv2 07/10] drivers: mtd: m25p80: Adapt driver to support memory mapped read Sourav Poddar
2013-12-06 14:24     ` Sourav Poddar
2013-12-06 14:24     ` Sourav Poddar
     [not found]     ` <1386339891-32717-8-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-12-12  7:55       ` Huang Shijie
2013-12-12  7:55         ` Huang Shijie
2013-12-12  8:15         ` Sourav Poddar
2013-12-12  8:15           ` Sourav Poddar
2013-12-12  8:15           ` Sourav Poddar
2013-12-12  8:31           ` Huang Shijie
2013-12-12  8:31             ` Huang Shijie
2013-12-06 14:24 ` [PATCHv2 08/10] Documentation: bindings: ti-qspi: update binding information Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-19 13:34   ` Mark Brown
2013-12-19 13:34     ` Mark Brown
2013-12-06 14:24 ` [PATCHv2 09/10] arm: dts: dra7: Add qspi device Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
     [not found]   ` <1386339891-32717-10-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-12-09 17:42     ` Tony Lindgren
2013-12-09 17:42       ` Tony Lindgren
     [not found]       ` <20131209174203.GB12527-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-12-10  4:25         ` Sourav Poddar
2013-12-10  4:25           ` Sourav Poddar
2013-12-10  4:25           ` Sourav Poddar
2013-12-10 10:31           ` Mark Brown
2013-12-10 10:31             ` Mark Brown
2013-12-10 10:45             ` Sourav Poddar
2013-12-10 10:45               ` Sourav Poddar
2013-12-10 10:45               ` Sourav Poddar
2013-12-12  4:20             ` Sourav Poddar
2013-12-12  4:20               ` Sourav Poddar
2013-12-06 14:24 ` [PATCHv2 10/10] arm: dts: am43x-epos: " Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-06 14:24   ` Sourav Poddar
2013-12-10 12:49 ` [PATCHv2 00/10] Add memory mapped support for ti qspi, m25p80 serial flash Marek Vasut
2013-12-10 12:49   ` Marek Vasut
     [not found]   ` <201312101349.13564.marex-ynQEQJNshbs@public.gmane.org>
2013-12-10 16:11     ` Mark Brown
2013-12-10 16:11       ` Mark Brown
     [not found]       ` <20131210161143.GK29268-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-10 18:22         ` Marek Vasut
2013-12-10 18:22           ` Marek Vasut
2013-12-10 18:29           ` Mark Brown
2013-12-10 18:29             ` Mark Brown
2013-12-10 18:34             ` Marek Vasut
2013-12-10 18:34               ` Marek Vasut
     [not found]             ` <20131210182904.GG11468-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-11  4:37               ` Sourav Poddar
2013-12-11  4:37                 ` Sourav Poddar
2013-12-11  4:37                 ` Sourav Poddar
     [not found]           ` <201312101922.10618.marex-ynQEQJNshbs@public.gmane.org>
2013-12-11  4:19             ` Sourav Poddar
2013-12-11  4:19               ` Sourav Poddar
2013-12-11  4:19               ` Sourav Poddar
2013-12-11  4:18     ` Sourav Poddar
2013-12-11  4:18       ` Sourav Poddar
2013-12-11  4:18       ` Sourav Poddar
     [not found]       ` <52A7E7A5.5000909-l0cyMroinI0@public.gmane.org>
2013-12-11 10:44         ` Marek Vasut
2013-12-11 10:44           ` Marek Vasut
2013-12-11 12:01           ` Mark Brown
2013-12-11 12:01             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131219133105.GC31886@sirena.org.uk \
    --to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marex-ynQEQJNshbs@public.gmane.org \
    --cc=sourav.poddar-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.