* [PATCH 1/2] mtd/ts5500: Add dependency
@ 2014-02-14 10:28 Jean Delvare
2014-02-14 10:32 ` Alexander Shiyan
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Jean Delvare @ 2014-02-14 10:28 UTC (permalink / raw)
To: linux-mtd; +Cc: Brian Norris, David Woodhouse, Vivien Didelot
There is no point in displaying the TS5500-specific driver entries if
TS5500 board support itself isn't enabled.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
drivers/mtd/maps/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.14-rc2.orig/drivers/mtd/maps/Kconfig 2014-02-14 11:21:15.116363700 +0100
+++ linux-3.14-rc2/drivers/mtd/maps/Kconfig 2014-02-14 11:23:53.286863374 +0100
@@ -124,7 +124,7 @@ config MTD_NETSC520
config MTD_TS5500
tristate "JEDEC Flash device mapped on Technologic Systems TS-5500"
- depends on X86
+ depends on TS5500 || (X86 && COMPILE_TEST)
select MTD_JEDECPROBE
select MTD_CFI_AMDSTD
help
--
Jean Delvare
Suse L3 Support
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] mtd/ts5500: Add dependency
2014-02-14 10:28 [PATCH 1/2] mtd/ts5500: Add dependency Jean Delvare
@ 2014-02-14 10:32 ` Alexander Shiyan
2014-02-14 10:44 ` Jean Delvare
2014-02-14 10:32 ` [PATCH 2/2] gpio-ts5500: " Jean Delvare
2014-02-23 2:01 ` [PATCH 1/2] mtd/ts5500: " Brian Norris
2 siblings, 1 reply; 9+ messages in thread
From: Alexander Shiyan @ 2014-02-14 10:32 UTC (permalink / raw)
To: Jean Delvare; +Cc: David Woodhouse, Brian Norris, linux-mtd, Vivien Didelot
Пятница, 14 февраля 2014, 11:28 +01:00 от Jean Delvare <jdelvare@suse.de>:
> There is no point in displaying the TS5500-specific driver entries if
> TS5500 board support itself isn't enabled.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
> drivers/mtd/maps/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-3.14-rc2.orig/drivers/mtd/maps/Kconfig 2014-02-14 11:21:15.116363700
> +0100
> +++ linux-3.14-rc2/drivers/mtd/maps/Kconfig 2014-02-14 11:23:53.286863374
> +0100
> @@ -124,7 +124,7 @@ config MTD_NETSC520
>
> config MTD_TS5500
> tristate "JEDEC Flash device mapped on Technologic Systems TS-5500"
> - depends on X86
> + depends on TS5500 || (X86 && COMPILE_TEST)
TS5500 && (X86 || COMPILE_TEST) ?
---
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] mtd/ts5500: Add dependency
2014-02-14 10:32 ` Alexander Shiyan
@ 2014-02-14 10:44 ` Jean Delvare
2014-02-14 10:56 ` Alexander Shiyan
0 siblings, 1 reply; 9+ messages in thread
From: Jean Delvare @ 2014-02-14 10:44 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: David Woodhouse, Brian Norris, linux-mtd, Vivien Didelot
Hi Alexander,
On Fri, 14 Feb 2014 14:32:06 +0400, Alexander Shiyan wrote:
> Пятница, 14 февраля 2014, 11:28 +01:00 от Jean Delvare <jdelvare@suse.de>:
> > There is no point in displaying the TS5500-specific driver entries if
> > TS5500 board support itself isn't enabled.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Brian Norris <computersforpeace@gmail.com>
> > Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > ---
> > drivers/mtd/maps/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-3.14-rc2.orig/drivers/mtd/maps/Kconfig 2014-02-14 11:21:15.116363700
> > +0100
> > +++ linux-3.14-rc2/drivers/mtd/maps/Kconfig 2014-02-14 11:23:53.286863374
> > +0100
> > @@ -124,7 +124,7 @@ config MTD_NETSC520
> >
> > config MTD_TS5500
> > tristate "JEDEC Flash device mapped on Technologic Systems TS-5500"
> > - depends on X86
> > + depends on TS5500 || (X86 && COMPILE_TEST)
>
> TS5500 && (X86 || COMPILE_TEST) ?
Hmm, no. The way I wrote it is correct I believe. TS5500 itself depends
on X86. The driver is only needed on TS5500, but can be test-built in
any X86 kernel if needed.
--
Jean Delvare
Suse L3 Support
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] mtd/ts5500: Add dependency
2014-02-14 10:44 ` Jean Delvare
@ 2014-02-14 10:56 ` Alexander Shiyan
0 siblings, 0 replies; 9+ messages in thread
From: Alexander Shiyan @ 2014-02-14 10:56 UTC (permalink / raw)
To: Jean Delvare; +Cc: David Woodhouse, Brian Norris, linux-mtd, Vivien Didelot
Пятница, 14 февраля 2014, 11:44 +01:00 от Jean Delvare <jdelvare@suse.de>:
> Hi Alexander,
>
> On Fri, 14 Feb 2014 14:32:06 +0400, Alexander Shiyan wrote:
> > Пятница, 14 февраля 2014, 11:28 +01:00 от Jean Delvare <jdelvare@suse.de>:
> > > There is no point in displaying the TS5500-specific driver entries if
> > > TS5500 board support itself isn't enabled.
> > >
> > > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > > Cc: David Woodhouse <dwmw2@infradead.org>
> > > Cc: Brian Norris <computersforpeace@gmail.com>
> > > Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > > ---
> > > drivers/mtd/maps/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > --- linux-3.14-rc2.orig/drivers/mtd/maps/Kconfig 2014-02-14
> 11:21:15.116363700
> > > +0100
> > > +++ linux-3.14-rc2/drivers/mtd/maps/Kconfig 2014-02-14 11:23:53.286863374
> > > +0100
> > > @@ -124,7 +124,7 @@ config MTD_NETSC520
> > >
> > > config MTD_TS5500
> > > tristate "JEDEC Flash device mapped on Technologic Systems TS-5500"
> > > - depends on X86
> > > + depends on TS5500 || (X86 && COMPILE_TEST)
> >
> > TS5500 && (X86 || COMPILE_TEST) ?
>
> Hmm, no. The way I wrote it is correct I believe. TS5500 itself depends
> on X86. The driver is only needed on TS5500, but can be test-built in
> any X86 kernel if needed.
If so, you are right. Sorry for noise.
---
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] gpio-ts5500: Add dependency
2014-02-14 10:28 [PATCH 1/2] mtd/ts5500: Add dependency Jean Delvare
2014-02-14 10:32 ` Alexander Shiyan
@ 2014-02-14 10:32 ` Jean Delvare
2014-02-22 2:00 ` Alexandre Courbot
2014-02-27 9:20 ` Linus Walleij
2014-02-23 2:01 ` [PATCH 1/2] mtd/ts5500: " Brian Norris
2 siblings, 2 replies; 9+ messages in thread
From: Jean Delvare @ 2014-02-14 10:32 UTC (permalink / raw)
To: linux-gpio; +Cc: Linus Walleij, Alexandre Courbot, Vivien Didelot
There is no point in displaying the TS5500-specific driver entries if
TS5500 board support itself isn't enabled.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
Note: a similar patch was sent for the TS5500-specific MTD driver.
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-3.14-rc2.orig/drivers/gpio/Kconfig 2014-02-14 11:21:15.116363700 +0100
+++ linux-3.14-rc2/drivers/gpio/Kconfig 2014-02-14 11:21:51.126174491 +0100
@@ -277,6 +277,7 @@ config GPIO_STA2X11
config GPIO_TS5500
tristate "TS-5500 DIO blocks and compatibles"
+ depends on TS5500 || COMPILE_TEST
help
This driver supports Digital I/O exposed by pin blocks found on some
Technologic Systems platforms. It includes, but is not limited to, 3
--
Jean Delvare
Suse L3 Support
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] gpio-ts5500: Add dependency
2014-02-14 10:32 ` [PATCH 2/2] gpio-ts5500: " Jean Delvare
@ 2014-02-22 2:00 ` Alexandre Courbot
2014-02-27 9:20 ` Linus Walleij
1 sibling, 0 replies; 9+ messages in thread
From: Alexandre Courbot @ 2014-02-22 2:00 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-gpio, Linus Walleij, Vivien Didelot
On Fri, Feb 14, 2014 at 7:32 PM, Jean Delvare <jdelvare@suse.de> wrote:
> There is no point in displaying the TS5500-specific driver entries if
> TS5500 board support itself isn't enabled.
Acked-by: Alexandre Courbot <gnurou@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] gpio-ts5500: Add dependency
2014-02-14 10:32 ` [PATCH 2/2] gpio-ts5500: " Jean Delvare
2014-02-22 2:00 ` Alexandre Courbot
@ 2014-02-27 9:20 ` Linus Walleij
1 sibling, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2014-02-27 9:20 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-gpio, Alexandre Courbot, Vivien Didelot
On Fri, Feb 14, 2014 at 11:32 AM, Jean Delvare <jdelvare@suse.de> wrote:
> There is no point in displaying the TS5500-specific driver entries if
> TS5500 board support itself isn't enabled.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] mtd/ts5500: Add dependency
2014-02-14 10:28 [PATCH 1/2] mtd/ts5500: Add dependency Jean Delvare
2014-02-14 10:32 ` Alexander Shiyan
2014-02-14 10:32 ` [PATCH 2/2] gpio-ts5500: " Jean Delvare
@ 2014-02-23 2:01 ` Brian Norris
2014-02-23 9:27 ` Jean Delvare
2 siblings, 1 reply; 9+ messages in thread
From: Brian Norris @ 2014-02-23 2:01 UTC (permalink / raw)
To: Jean Delvare; +Cc: David Woodhouse, linux-mtd, Vivien Didelot
On Fri, Feb 14, 2014 at 11:28:24AM +0100, Jean Delvare wrote:
> There is no point in displaying the TS5500-specific driver entries if
> TS5500 board support itself isn't enabled.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
> drivers/mtd/maps/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-3.14-rc2.orig/drivers/mtd/maps/Kconfig 2014-02-14 11:21:15.116363700 +0100
> +++ linux-3.14-rc2/drivers/mtd/maps/Kconfig 2014-02-14 11:23:53.286863374 +0100
> @@ -124,7 +124,7 @@ config MTD_NETSC520
>
> config MTD_TS5500
> tristate "JEDEC Flash device mapped on Technologic Systems TS-5500"
> - depends on X86
> + depends on TS5500 || (X86 && COMPILE_TEST)
Shouldn't this just be
depends on TS5500 || COMPILE_TEST
since it's such a simple driver, it can be compiled under any ARCH?
> select MTD_JEDECPROBE
> select MTD_CFI_AMDSTD
> help
>
>
Brian
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] mtd/ts5500: Add dependency
2014-02-23 2:01 ` [PATCH 1/2] mtd/ts5500: " Brian Norris
@ 2014-02-23 9:27 ` Jean Delvare
0 siblings, 0 replies; 9+ messages in thread
From: Jean Delvare @ 2014-02-23 9:27 UTC (permalink / raw)
To: Brian Norris; +Cc: David Woodhouse, linux-mtd, Vivien Didelot
Hi Brian,
On Sat, 22 Feb 2014 18:01:19 -0800, Brian Norris wrote:
> On Fri, Feb 14, 2014 at 11:28:24AM +0100, Jean Delvare wrote:
> > There is no point in displaying the TS5500-specific driver entries if
> > TS5500 board support itself isn't enabled.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Brian Norris <computersforpeace@gmail.com>
> > Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > ---
> > drivers/mtd/maps/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-3.14-rc2.orig/drivers/mtd/maps/Kconfig 2014-02-14 11:21:15.116363700 +0100
> > +++ linux-3.14-rc2/drivers/mtd/maps/Kconfig 2014-02-14 11:23:53.286863374 +0100
> > @@ -124,7 +124,7 @@ config MTD_NETSC520
> >
> > config MTD_TS5500
> > tristate "JEDEC Flash device mapped on Technologic Systems TS-5500"
> > - depends on X86
> > + depends on TS5500 || (X86 && COMPILE_TEST)
>
> Shouldn't this just be
>
> depends on TS5500 || COMPILE_TEST
>
> since it's such a simple driver, it can be compiled under any ARCH?
Could be. As I didn't have any other architecture to test on, I decided
to play it safe and assumed the dependency on X86 was there for a
reason. Looking at the code again, you appear to be right, there
doesn't seem to be a need to restrict compilation testing to X86.
I'll send an updated patch, thanks for the suggestion.
> > select MTD_JEDECPROBE
> > select MTD_CFI_AMDSTD
> > help
> >
> >
--
Jean Delvare
Suse L3 Support
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-02-27 9:20 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-14 10:28 [PATCH 1/2] mtd/ts5500: Add dependency Jean Delvare
2014-02-14 10:32 ` Alexander Shiyan
2014-02-14 10:44 ` Jean Delvare
2014-02-14 10:56 ` Alexander Shiyan
2014-02-14 10:32 ` [PATCH 2/2] gpio-ts5500: " Jean Delvare
2014-02-22 2:00 ` Alexandre Courbot
2014-02-27 9:20 ` Linus Walleij
2014-02-23 2:01 ` [PATCH 1/2] mtd/ts5500: " Brian Norris
2014-02-23 9:27 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.