From: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> To: David Rientjes <rientjes@google.com> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>, Andrew Morton <akpm@linux-foundation.org>, Fengguang Wu <fengguang.wu@intel.com>, David Cohen <david.a.cohen@linux.intel.com>, Al Viro <viro@zeniv.linux.org.uk>, Damien Ramonda <damien.ramonda@intel.com>, Jan Kara <jack@suse.cz>, linux-mm <linux-mm@kvack.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [RFC PATCH V5] mm readahead: Fix readahead fail for no local memory and limit readahead pages Date: Mon, 17 Feb 2014 17:31:00 -0800 [thread overview] Message-ID: <20140218013100.GA31998@linux.vnet.ibm.com> (raw) In-Reply-To: <alpine.DEB.2.02.1402171501001.25724@chino.kir.corp.google.com> On 17.02.2014 [15:14:06 -0800], David Rientjes wrote: > On Mon, 17 Feb 2014, Nishanth Aravamudan wrote: > > > Here is what I'm running into now: > > > > setup_arch -> > > do_init_bootmem -> > > cpu_numa_callback -> > > numa_setup_cpu -> > > map_cpu_to_node -> > > update_numa_cpu_lookup_table > > > > Which current updates the powerpc specific numa_cpu_lookup_table. I > > would like to update that function to use set_cpu_numa_node() and > > set_cpu_numa_mem(), but local_memory_node() is not yet functional > > because build_all_zonelists is called later in start_kernel. Would it > > make sense for first_zones_zonelist() to return NUMA_NO_NODE if we > > don't have a zone? > > > > Hmm, I don't think we'll want to modify the generic first_zones_zonelist() > for a special case that is only true during boot. Instead, would it make > sense to modify numa_setup_cpu() to use the generic cpu_to_node() instead > of using a powerpc mapping and then do the set_cpu_numa_mem() after > paging_init() when the zonelists will have been built and zones without > present pages are properly excluded? Sorry, I was unclear in my e-mail. I meant to modify local_memory_node(), not first_zones_zonelist(). Well, it only needs the following, I think? diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e3758a0..5de4337 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3650,6 +3650,8 @@ int local_memory_node(int node) gfp_zone(GFP_KERNEL), NULL, &zone); + if (!zone) + return NUMA_NO_NODE; return zone->node; } #endif I think that condition should only happen during boot -- maybe even deserving of an unlikely, but I don't think the above is considered a hot-path. If the above isn't palatable, I can look into your suggestion instead. Thanks, Nish
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> To: David Rientjes <rientjes@google.com> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>, Andrew Morton <akpm@linux-foundation.org>, Fengguang Wu <fengguang.wu@intel.com>, David Cohen <david.a.cohen@linux.intel.com>, Al Viro <viro@zeniv.linux.org.uk>, Damien Ramonda <damien.ramonda@intel.com>, Jan Kara <jack@suse.cz>, linux-mm <linux-mm@kvack.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [RFC PATCH V5] mm readahead: Fix readahead fail for no local memory and limit readahead pages Date: Mon, 17 Feb 2014 17:31:00 -0800 [thread overview] Message-ID: <20140218013100.GA31998@linux.vnet.ibm.com> (raw) In-Reply-To: <alpine.DEB.2.02.1402171501001.25724@chino.kir.corp.google.com> On 17.02.2014 [15:14:06 -0800], David Rientjes wrote: > On Mon, 17 Feb 2014, Nishanth Aravamudan wrote: > > > Here is what I'm running into now: > > > > setup_arch -> > > do_init_bootmem -> > > cpu_numa_callback -> > > numa_setup_cpu -> > > map_cpu_to_node -> > > update_numa_cpu_lookup_table > > > > Which current updates the powerpc specific numa_cpu_lookup_table. I > > would like to update that function to use set_cpu_numa_node() and > > set_cpu_numa_mem(), but local_memory_node() is not yet functional > > because build_all_zonelists is called later in start_kernel. Would it > > make sense for first_zones_zonelist() to return NUMA_NO_NODE if we > > don't have a zone? > > > > Hmm, I don't think we'll want to modify the generic first_zones_zonelist() > for a special case that is only true during boot. Instead, would it make > sense to modify numa_setup_cpu() to use the generic cpu_to_node() instead > of using a powerpc mapping and then do the set_cpu_numa_mem() after > paging_init() when the zonelists will have been built and zones without > present pages are properly excluded? Sorry, I was unclear in my e-mail. I meant to modify local_memory_node(), not first_zones_zonelist(). Well, it only needs the following, I think? diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e3758a0..5de4337 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3650,6 +3650,8 @@ int local_memory_node(int node) gfp_zone(GFP_KERNEL), NULL, &zone); + if (!zone) + return NUMA_NO_NODE; return zone->node; } #endif I think that condition should only happen during boot -- maybe even deserving of an unlikely, but I don't think the above is considered a hot-path. If the above isn't palatable, I can look into your suggestion instead. Thanks, Nish -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-02-18 1:31 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-01-22 10:53 [RFC PATCH V5] mm readahead: Fix readahead fail for no local memory and limit readahead pages Raghavendra K T 2014-01-22 10:53 ` Raghavendra K T 2014-02-03 8:30 ` Raghavendra K T 2014-02-03 8:30 ` Raghavendra K T 2014-02-06 22:51 ` Andrew Morton 2014-02-06 22:51 ` Andrew Morton 2014-02-06 22:58 ` David Rientjes 2014-02-06 22:58 ` David Rientjes 2014-02-06 23:22 ` Andrew Morton 2014-02-06 23:22 ` Andrew Morton 2014-02-06 23:48 ` David Rientjes 2014-02-06 23:48 ` David Rientjes 2014-02-06 23:58 ` David Rientjes 2014-02-06 23:58 ` David Rientjes 2014-02-07 10:42 ` Raghavendra K T 2014-02-07 10:42 ` Raghavendra K T 2014-02-07 20:41 ` David Rientjes 2014-02-07 20:41 ` David Rientjes 2014-02-10 8:21 ` Raghavendra K T 2014-02-10 8:21 ` Raghavendra K T 2014-02-10 10:05 ` David Rientjes 2014-02-10 10:05 ` David Rientjes 2014-02-10 12:25 ` Raghavendra K T 2014-02-10 12:25 ` Raghavendra K T 2014-02-10 21:35 ` David Rientjes 2014-02-10 21:35 ` David Rientjes 2014-02-13 7:07 ` Raghavendra K T 2014-02-13 7:07 ` Raghavendra K T 2014-02-13 8:05 ` David Rientjes 2014-02-13 8:05 ` David Rientjes 2014-02-13 10:04 ` Raghavendra K T 2014-02-13 10:04 ` Raghavendra K T 2014-02-13 22:41 ` David Rientjes 2014-02-13 22:41 ` David Rientjes 2014-02-14 0:14 ` Nishanth Aravamudan 2014-02-14 0:14 ` Nishanth Aravamudan 2014-02-14 0:37 ` Linus Torvalds 2014-02-14 0:37 ` Linus Torvalds 2014-02-14 0:45 ` Andrew Morton 2014-02-14 0:45 ` Andrew Morton 2014-02-14 4:32 ` Nishanth Aravamudan 2014-02-14 4:32 ` Nishanth Aravamudan 2014-02-14 10:54 ` David Rientjes 2014-02-14 10:54 ` David Rientjes 2014-02-17 19:28 ` Nishanth Aravamudan 2014-02-17 19:28 ` Nishanth Aravamudan 2014-02-17 23:14 ` David Rientjes 2014-02-17 23:14 ` David Rientjes 2014-02-18 1:31 ` Nishanth Aravamudan [this message] 2014-02-18 1:31 ` Nishanth Aravamudan 2014-02-17 22:59 ` Linus Torvalds 2014-02-17 22:59 ` Linus Torvalds 2014-02-14 7:43 ` Jan Kara 2014-02-14 7:43 ` Jan Kara 2014-02-17 22:57 ` Linus Torvalds 2014-02-17 22:57 ` Linus Torvalds 2014-02-14 5:47 ` Nishanth Aravamudan 2014-02-14 5:47 ` Nishanth Aravamudan 2014-02-13 21:06 ` Andrew Morton 2014-02-13 21:06 ` Andrew Morton 2014-02-13 21:42 ` Nishanth Aravamudan 2014-02-13 21:42 ` Nishanth Aravamudan 2014-02-10 8:29 ` [RFC PATCH V5 RESEND] " Raghavendra K T 2014-02-10 8:29 ` Raghavendra K T
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140218013100.GA31998@linux.vnet.ibm.com \ --to=nacc@linux.vnet.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=damien.ramonda@intel.com \ --cc=david.a.cohen@linux.intel.com \ --cc=fengguang.wu@intel.com \ --cc=jack@suse.cz \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=raghavendra.kt@linux.vnet.ibm.com \ --cc=rientjes@google.com \ --cc=torvalds@linux-foundation.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.