All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Walters <walters@verbum.org>
To: systemd Mailing List <systemd-devel@lists.freedesktop.org>,
	SELinux-NSA <SELinux@tycho.nsa.gov>
Subject: Re: [systemd-devel] [PATCH] selinux: Only attempt to load policy exactly once, in the real root
Date: Thu, 20 Feb 2014 20:52:08 +0000	[thread overview]
Message-ID: <20140220205709.BFC67C00005@frontend1.nyi.mail.srv.osa> (raw)
In-Reply-To: <53065B50.1030004@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]

On Thu, Feb 20, 2014 at 2:45 PM, Daniel J Walsh <dwalsh@redhat.com> 
wrote:
>> 
>> 
> You mean
> 
> "!in_initrd() || access(selinux_path(), F_OK) >= 0"?
> 

I don't think so - that would mean we would silently continue if 
enforcing=1, but we happen to not find a policy on disk.  Right?

I think my patch is better than this - systemd will attempt to load 
policy from *only* the real root (not the initramfs), using the exact 
same logic as is in libselinux currently.

For example, it would allow explicitly specifying enforcing=1 on the 
kernel command line, and that would continue to cause an explicit 
failure if policy is not found.




[-- Attachment #2: Type: text/html, Size: 860 bytes --]

  reply	other threads:[~2014-02-20 20:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-20 15:42 [PATCH] selinux: Only attempt to load policy exactly once, in the real root Colin Walters
2014-02-20 18:06 ` Stephen Smalley
2014-02-20 18:17   ` Colin Walters
2014-02-20 18:36     ` [systemd-devel] " Lennart Poettering
2014-02-20 18:47       ` Colin Walters
2014-02-20 18:50       ` Eric Paris
2014-02-20 19:26         ` Lennart Poettering
2014-02-20 19:27           ` Eric Paris
2014-02-20 19:45             ` Daniel J Walsh
2014-02-20 20:52               ` Colin Walters [this message]
2014-02-20 21:10                 ` Eric Paris
2014-02-20 21:21                   ` Colin Walters
2014-02-20 23:44                     ` Colin Walters
2014-02-21  2:33                       ` Lennart Poettering
2014-02-20 18:51     ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140220205709.BFC67C00005@frontend1.nyi.mail.srv.osa \
    --to=walters@verbum.org \
    --cc=SELinux@tycho.nsa.gov \
    --cc=systemd-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.