From: Sebastian Capella <sebastian.capella@linaro.org> To: Sebastian Capella <sebastian.capella@linaro.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Len Brown <len.brown@intel.com>, "linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>, Russell King <linux@arm.linux.org.uk>, Jonathan Austin <Jonathan.Austin@arm.com>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, Will Deacon <Will.Deacon@arm.com>, Nicolas Pitre <nico@linaro.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>, Russ Dill <Russ.Dill@ti.com>, Pavel Machek <pavel@ucw.cz>, Catalin Marinas <Catalin.Marinas@arm.com>, Santosh Shilimkar <santosh.shilimkar@ti.com>, Stephen Boyd <sboyd@codeaurora.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk Date: Fri, 21 Feb 2014 15:59:11 -0800 [thread overview] Message-ID: <20140221235911.14777.13919@capellas-linux> (raw) In-Reply-To: <20140221183956.29890.80931@capellas-linux> - Cyril Chemparathy as his email is bouncing back to me. Quoting Sebastian Capella (2014-02-21 10:39:56) > Quoting Lorenzo Pieralisi (2014-02-20 08:27:55) > > > > > + cpu_switch_mm(idmap_pgd, &init_mm); [ ... ] > I can try removing it and seeing if there are side effects. FYI, It's definitely hanging with this removed, still looking. > In this state I believe: > - our stack is safe because it's in nosave. > - userspace is frozen, those pages are 'don't care', as we're > discarding its state. > - our instructions and globals are ok, because they're in the > same place as last boot and are not getting restored. None are in > modules. > - Globals: restore_pblist, idmap_pgd, init_mm, swapper_pg_dir Sorry, this last bit about the globals is not correct. Of course they're getting restored. What I meant to say is that they shouldn't be affected by the mmu switch as they remain at the same address. For our purposes, I think we won't care about their state as we're not referencing them after we start restoring. We start the list with restore_pblist, but after following the initial pointer, we don't reference it again. From then on, we're walking safe memory lists. Sorry for the misleading statements. Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: sebastian.capella@linaro.org (Sebastian Capella) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk Date: Fri, 21 Feb 2014 15:59:11 -0800 [thread overview] Message-ID: <20140221235911.14777.13919@capellas-linux> (raw) In-Reply-To: <20140221183956.29890.80931@capellas-linux> - Cyril Chemparathy as his email is bouncing back to me. Quoting Sebastian Capella (2014-02-21 10:39:56) > Quoting Lorenzo Pieralisi (2014-02-20 08:27:55) > > > > > + cpu_switch_mm(idmap_pgd, &init_mm); [ ... ] > I can try removing it and seeing if there are side effects. FYI, It's definitely hanging with this removed, still looking. > In this state I believe: > - our stack is safe because it's in nosave. > - userspace is frozen, those pages are 'don't care', as we're > discarding its state. > - our instructions and globals are ok, because they're in the > same place as last boot and are not getting restored. None are in > modules. > - Globals: restore_pblist, idmap_pgd, init_mm, swapper_pg_dir Sorry, this last bit about the globals is not correct. Of course they're getting restored. What I meant to say is that they shouldn't be affected by the mmu switch as they remain at the same address. For our purposes, I think we won't care about their state as we're not referencing them after we start restoring. We start the list with restore_pblist, but after following the initial pointer, we don't reference it again. From then on, we're walking safe memory lists. Sorry for the misleading statements. Sebastian
next prev parent reply other threads:[~2014-02-21 23:59 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-19 1:52 [PATCH RFC v1 0/3] hibernation support on ARM Sebastian Capella 2014-02-19 1:52 ` Sebastian Capella 2014-02-19 1:52 ` [PATCH RFC v1 1/3] ARM: Add irq disabled version of soft_restart Sebastian Capella 2014-02-19 1:52 ` Sebastian Capella 2014-02-22 10:26 ` Russell King - ARM Linux 2014-02-22 10:26 ` Russell King - ARM Linux 2014-02-24 23:13 ` Sebastian Capella 2014-02-24 23:13 ` Sebastian Capella 2014-02-25 0:22 ` Sebastian Capella 2014-02-25 0:22 ` Sebastian Capella 2014-02-25 7:56 ` Russ Dill 2014-02-25 7:56 ` Russ Dill 2014-02-25 7:56 ` Russ Dill 2014-02-25 10:27 ` Thomas Gleixner 2014-02-25 10:27 ` Thomas Gleixner 2014-02-25 17:15 ` Russ Dill 2014-02-25 17:15 ` Russ Dill 2014-02-25 17:15 ` Russ Dill 2014-02-25 23:24 ` Sebastian Capella 2014-02-25 23:24 ` Sebastian Capella 2014-02-19 1:52 ` [PATCH RFC v1 2/3] Fix hibernation restore hang in freeze_processes Sebastian Capella 2014-02-19 1:52 ` Sebastian Capella 2014-02-24 7:09 ` Ming Lei 2014-02-24 7:09 ` Ming Lei 2014-02-19 1:52 ` [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk Sebastian Capella 2014-02-19 1:52 ` Sebastian Capella 2014-02-19 16:12 ` Lorenzo Pieralisi 2014-02-19 16:12 ` Lorenzo Pieralisi 2014-02-19 16:12 ` Lorenzo Pieralisi 2014-02-19 19:10 ` Russ Dill 2014-02-19 19:10 ` Russ Dill 2014-02-19 19:10 ` Russ Dill 2014-02-20 10:37 ` Lorenzo Pieralisi 2014-02-20 10:37 ` Lorenzo Pieralisi 2014-02-20 10:37 ` Lorenzo Pieralisi 2014-02-19 19:33 ` Sebastian Capella 2014-02-19 19:33 ` Sebastian Capella 2014-02-20 16:27 ` Lorenzo Pieralisi 2014-02-20 16:27 ` Lorenzo Pieralisi 2014-02-20 16:27 ` Lorenzo Pieralisi 2014-02-21 18:39 ` Sebastian Capella 2014-02-21 18:39 ` Sebastian Capella 2014-02-21 23:59 ` Sebastian Capella [this message] 2014-02-21 23:59 ` Sebastian Capella 2014-02-22 4:37 ` Sebastian Capella 2014-02-22 4:37 ` Sebastian Capella 2014-02-22 6:46 ` Russ Dill 2014-02-22 6:46 ` Russ Dill 2014-02-22 6:46 ` Russ Dill 2014-02-22 10:22 ` Russell King - ARM Linux 2014-02-22 10:22 ` Russell King - ARM Linux 2014-02-22 10:22 ` Russell King - ARM Linux 2014-02-22 10:16 ` Russell King - ARM Linux 2014-02-22 10:16 ` Russell King - ARM Linux 2014-02-22 10:16 ` Russell King - ARM Linux 2014-02-22 12:13 ` Lorenzo Pieralisi 2014-02-22 12:13 ` Lorenzo Pieralisi 2014-02-22 12:13 ` Lorenzo Pieralisi 2014-02-22 22:30 ` Pavel Machek 2014-02-22 22:30 ` Pavel Machek 2014-02-22 22:30 ` Pavel Machek 2014-02-21 1:01 ` Sebastian Capella 2014-02-21 1:01 ` Sebastian Capella 2014-02-22 10:38 ` Russell King - ARM Linux 2014-02-22 10:38 ` Russell King - ARM Linux 2014-02-22 10:38 ` Russell King - ARM Linux 2014-02-22 12:09 ` Lorenzo Pieralisi 2014-02-22 12:09 ` Lorenzo Pieralisi 2014-02-22 12:09 ` Lorenzo Pieralisi 2014-02-22 22:28 ` Pavel Machek 2014-02-22 22:28 ` Pavel Machek 2014-02-22 22:28 ` Pavel Machek 2014-02-23 19:52 ` Sebastian Capella 2014-02-23 19:52 ` Sebastian Capella 2014-02-23 19:52 ` Sebastian Capella 2014-02-23 20:02 ` Sebastian Capella 2014-02-23 20:02 ` Sebastian Capella 2014-02-23 20:02 ` Sebastian Capella 2014-02-25 11:32 ` Lorenzo Pieralisi 2014-02-25 11:32 ` Lorenzo Pieralisi 2014-02-25 11:32 ` Lorenzo Pieralisi 2014-02-25 17:55 ` Sebastian Capella 2014-02-25 17:55 ` Sebastian Capella 2014-02-26 10:24 ` Lorenzo Pieralisi 2014-02-26 10:24 ` Lorenzo Pieralisi 2014-02-26 10:24 ` Lorenzo Pieralisi 2014-02-26 17:50 ` Sebastian Capella 2014-02-26 17:50 ` Sebastian Capella 2014-02-26 19:03 ` Lorenzo Pieralisi 2014-02-26 19:03 ` Lorenzo Pieralisi 2014-02-26 19:03 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140221235911.14777.13919@capellas-linux \ --to=sebastian.capella@linaro.org \ --cc=Catalin.Marinas@arm.com \ --cc=Jonathan.Austin@arm.com \ --cc=Russ.Dill@ti.com \ --cc=Will.Deacon@arm.com \ --cc=len.brown@intel.com \ --cc=linaro-kernel@lists.linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=lorenzo.pieralisi@arm.com \ --cc=nico@linaro.org \ --cc=pavel@ucw.cz \ --cc=rjw@rjwysocki.net \ --cc=santosh.shilimkar@ti.com \ --cc=sboyd@codeaurora.org \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.