From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Sebastian Capella <sebastian.capella@linaro.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Len Brown <len.brown@intel.com>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Jonathan Austin <Jonathan.Austin@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Will Deacon <Will.Deacon@arm.com>,
Nicolas Pitre <nico@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>,
Russ Dill <Russ.Dill@ti.com>, Pavel Machek <pavel@ucw.cz>,
Cyril Chemparathy <cyril@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk
Date: Wed, 26 Feb 2014 19:03:33 +0000 [thread overview]
Message-ID: <20140226190333.GD22839@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <20140226175055.3502.49656@capellas-linux>
On Wed, Feb 26, 2014 at 05:50:55PM +0000, Sebastian Capella wrote:
> Quoting Lorenzo Pieralisi (2014-02-26 02:24:27)
> > On Tue, Feb 25, 2014 at 05:55:31PM +0000, Sebastian Capella wrote:
> >
> > Please add:
> >
> > "swsusp_save() is executed in the suspend finisher so that the CPU context
> > pointer and memory are part of the saved image, which is required by the
> > resume kernel image to restart execution from swsusp_arch_suspend()"
> >
> > > * soft_restart is not technically needed, but is used
> > > * to get success returned from cpu_suspend.
> > > * After resume, the hibernation snapshot is written out.
> >
> > "When soft reboot completes, the hibernation snapshot is written out."
> >
> > Resume is confusing since this code is resuming twice :D on image saving
> > and on kernel image restoration.
>
> Thanks Lorenzo!
>
> Here's what I've got.
>
> /*
> * Snapshot kernel memory and reset the system.
> *
> * swsusp_save() is executed in the suspend finisher so that the CPU
> * context pointer and memory are part of the saved image, which is
> * required by the resume kernel image to restart execution from
> * swsusp_arch_suspend().
> *
> * soft_restart is not technically needed, but is used to get success
> * returned from cpu_suspend.
> *
> * When soft reboot completes, the hibernation snapshot is
> * written out.
> */
>
> Does this look ok? I'll prepare a v4 patchset.
Yes it does, I will wait and review v4 then.
Thank you,
Lorenzo
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Sebastian Capella <sebastian.capella@linaro.org>
Cc: Len Brown <len.brown@intel.com>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Jonathan Austin <Jonathan.Austin@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Nicolas Pitre <nico@linaro.org>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>,
Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>,
Russ Dill <Russ.Dill@ti.com>, Cyril Chemparathy <cyril@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk
Date: Wed, 26 Feb 2014 19:03:33 +0000 [thread overview]
Message-ID: <20140226190333.GD22839@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <20140226175055.3502.49656@capellas-linux>
On Wed, Feb 26, 2014 at 05:50:55PM +0000, Sebastian Capella wrote:
> Quoting Lorenzo Pieralisi (2014-02-26 02:24:27)
> > On Tue, Feb 25, 2014 at 05:55:31PM +0000, Sebastian Capella wrote:
> >
> > Please add:
> >
> > "swsusp_save() is executed in the suspend finisher so that the CPU context
> > pointer and memory are part of the saved image, which is required by the
> > resume kernel image to restart execution from swsusp_arch_suspend()"
> >
> > > * soft_restart is not technically needed, but is used
> > > * to get success returned from cpu_suspend.
> > > * After resume, the hibernation snapshot is written out.
> >
> > "When soft reboot completes, the hibernation snapshot is written out."
> >
> > Resume is confusing since this code is resuming twice :D on image saving
> > and on kernel image restoration.
>
> Thanks Lorenzo!
>
> Here's what I've got.
>
> /*
> * Snapshot kernel memory and reset the system.
> *
> * swsusp_save() is executed in the suspend finisher so that the CPU
> * context pointer and memory are part of the saved image, which is
> * required by the resume kernel image to restart execution from
> * swsusp_arch_suspend().
> *
> * soft_restart is not technically needed, but is used to get success
> * returned from cpu_suspend.
> *
> * When soft reboot completes, the hibernation snapshot is
> * written out.
> */
>
> Does this look ok? I'll prepare a v4 patchset.
Yes it does, I will wait and review v4 then.
Thank you,
Lorenzo
WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk
Date: Wed, 26 Feb 2014 19:03:33 +0000 [thread overview]
Message-ID: <20140226190333.GD22839@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <20140226175055.3502.49656@capellas-linux>
On Wed, Feb 26, 2014 at 05:50:55PM +0000, Sebastian Capella wrote:
> Quoting Lorenzo Pieralisi (2014-02-26 02:24:27)
> > On Tue, Feb 25, 2014 at 05:55:31PM +0000, Sebastian Capella wrote:
> >
> > Please add:
> >
> > "swsusp_save() is executed in the suspend finisher so that the CPU context
> > pointer and memory are part of the saved image, which is required by the
> > resume kernel image to restart execution from swsusp_arch_suspend()"
> >
> > > * soft_restart is not technically needed, but is used
> > > * to get success returned from cpu_suspend.
> > > * After resume, the hibernation snapshot is written out.
> >
> > "When soft reboot completes, the hibernation snapshot is written out."
> >
> > Resume is confusing since this code is resuming twice :D on image saving
> > and on kernel image restoration.
>
> Thanks Lorenzo!
>
> Here's what I've got.
>
> /*
> * Snapshot kernel memory and reset the system.
> *
> * swsusp_save() is executed in the suspend finisher so that the CPU
> * context pointer and memory are part of the saved image, which is
> * required by the resume kernel image to restart execution from
> * swsusp_arch_suspend().
> *
> * soft_restart is not technically needed, but is used to get success
> * returned from cpu_suspend.
> *
> * When soft reboot completes, the hibernation snapshot is
> * written out.
> */
>
> Does this look ok? I'll prepare a v4 patchset.
Yes it does, I will wait and review v4 then.
Thank you,
Lorenzo
next prev parent reply other threads:[~2014-02-26 19:03 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 1:52 [PATCH RFC v1 0/3] hibernation support on ARM Sebastian Capella
2014-02-19 1:52 ` Sebastian Capella
2014-02-19 1:52 ` [PATCH RFC v1 1/3] ARM: Add irq disabled version of soft_restart Sebastian Capella
2014-02-19 1:52 ` Sebastian Capella
2014-02-22 10:26 ` Russell King - ARM Linux
2014-02-22 10:26 ` Russell King - ARM Linux
2014-02-24 23:13 ` Sebastian Capella
2014-02-24 23:13 ` Sebastian Capella
2014-02-25 0:22 ` Sebastian Capella
2014-02-25 0:22 ` Sebastian Capella
2014-02-25 7:56 ` Russ Dill
2014-02-25 7:56 ` Russ Dill
2014-02-25 7:56 ` Russ Dill
2014-02-25 10:27 ` Thomas Gleixner
2014-02-25 10:27 ` Thomas Gleixner
2014-02-25 17:15 ` Russ Dill
2014-02-25 17:15 ` Russ Dill
2014-02-25 17:15 ` Russ Dill
2014-02-25 23:24 ` Sebastian Capella
2014-02-25 23:24 ` Sebastian Capella
2014-02-19 1:52 ` [PATCH RFC v1 2/3] Fix hibernation restore hang in freeze_processes Sebastian Capella
2014-02-19 1:52 ` Sebastian Capella
2014-02-24 7:09 ` Ming Lei
2014-02-24 7:09 ` Ming Lei
2014-02-19 1:52 ` [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk Sebastian Capella
2014-02-19 1:52 ` Sebastian Capella
2014-02-19 16:12 ` Lorenzo Pieralisi
2014-02-19 16:12 ` Lorenzo Pieralisi
2014-02-19 16:12 ` Lorenzo Pieralisi
2014-02-19 19:10 ` Russ Dill
2014-02-19 19:10 ` Russ Dill
2014-02-19 19:10 ` Russ Dill
2014-02-20 10:37 ` Lorenzo Pieralisi
2014-02-20 10:37 ` Lorenzo Pieralisi
2014-02-20 10:37 ` Lorenzo Pieralisi
2014-02-19 19:33 ` Sebastian Capella
2014-02-19 19:33 ` Sebastian Capella
2014-02-20 16:27 ` Lorenzo Pieralisi
2014-02-20 16:27 ` Lorenzo Pieralisi
2014-02-20 16:27 ` Lorenzo Pieralisi
2014-02-21 18:39 ` Sebastian Capella
2014-02-21 18:39 ` Sebastian Capella
2014-02-21 23:59 ` Sebastian Capella
2014-02-21 23:59 ` Sebastian Capella
2014-02-22 4:37 ` Sebastian Capella
2014-02-22 4:37 ` Sebastian Capella
2014-02-22 6:46 ` Russ Dill
2014-02-22 6:46 ` Russ Dill
2014-02-22 6:46 ` Russ Dill
2014-02-22 10:22 ` Russell King - ARM Linux
2014-02-22 10:22 ` Russell King - ARM Linux
2014-02-22 10:22 ` Russell King - ARM Linux
2014-02-22 10:16 ` Russell King - ARM Linux
2014-02-22 10:16 ` Russell King - ARM Linux
2014-02-22 10:16 ` Russell King - ARM Linux
2014-02-22 12:13 ` Lorenzo Pieralisi
2014-02-22 12:13 ` Lorenzo Pieralisi
2014-02-22 12:13 ` Lorenzo Pieralisi
2014-02-22 22:30 ` Pavel Machek
2014-02-22 22:30 ` Pavel Machek
2014-02-22 22:30 ` Pavel Machek
2014-02-21 1:01 ` Sebastian Capella
2014-02-21 1:01 ` Sebastian Capella
2014-02-22 10:38 ` Russell King - ARM Linux
2014-02-22 10:38 ` Russell King - ARM Linux
2014-02-22 10:38 ` Russell King - ARM Linux
2014-02-22 12:09 ` Lorenzo Pieralisi
2014-02-22 12:09 ` Lorenzo Pieralisi
2014-02-22 12:09 ` Lorenzo Pieralisi
2014-02-22 22:28 ` Pavel Machek
2014-02-22 22:28 ` Pavel Machek
2014-02-22 22:28 ` Pavel Machek
2014-02-23 19:52 ` Sebastian Capella
2014-02-23 19:52 ` Sebastian Capella
2014-02-23 19:52 ` Sebastian Capella
2014-02-23 20:02 ` Sebastian Capella
2014-02-23 20:02 ` Sebastian Capella
2014-02-23 20:02 ` Sebastian Capella
2014-02-25 11:32 ` Lorenzo Pieralisi
2014-02-25 11:32 ` Lorenzo Pieralisi
2014-02-25 11:32 ` Lorenzo Pieralisi
2014-02-25 17:55 ` Sebastian Capella
2014-02-25 17:55 ` Sebastian Capella
2014-02-26 10:24 ` Lorenzo Pieralisi
2014-02-26 10:24 ` Lorenzo Pieralisi
2014-02-26 10:24 ` Lorenzo Pieralisi
2014-02-26 17:50 ` Sebastian Capella
2014-02-26 17:50 ` Sebastian Capella
2014-02-26 19:03 ` Lorenzo Pieralisi [this message]
2014-02-26 19:03 ` Lorenzo Pieralisi
2014-02-26 19:03 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226190333.GD22839@e102568-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Jonathan.Austin@arm.com \
--cc=Russ.Dill@ti.com \
--cc=Will.Deacon@arm.com \
--cc=cyril@ti.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@linaro.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=santosh.shilimkar@ti.com \
--cc=sboyd@codeaurora.org \
--cc=sebastian.capella@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.