From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> Cc: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>, Paul Mundt <lethal@linux-sh.org>, sh <linux-sh@vger.kernel.org> Subject: [patch 05/26] sh: Use irq_set_affinity instead of homebrewn code Date: Sun, 23 Feb 2014 21:40:10 +0000 [thread overview] Message-ID: <20140223212736.774961401@linutronix.de> (raw) In-Reply-To: 20140223212703.511977310@linutronix.de There is no point in having an incomplete copy of irq_set_affinity() for the hotplug irq migration code. Use the core function instead. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Paul Mundt <lethal@linux-sh.org> Cc: sh <linux-sh@vger.kernel.org> --- arch/sh/kernel/irq.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) Index: tip/arch/sh/kernel/irq.c =================================--- tip.orig/arch/sh/kernel/irq.c +++ tip/arch/sh/kernel/irq.c @@ -217,19 +217,6 @@ void __init init_IRQ(void) } #ifdef CONFIG_HOTPLUG_CPU -static void route_irq(struct irq_data *data, unsigned int irq, unsigned int cpu) -{ - struct irq_desc *desc = irq_to_desc(irq); - struct irq_chip *chip = irq_data_get_irq_chip(data); - - printk(KERN_INFO "IRQ%u: moving from cpu%u to cpu%u\n", - irq, data->node, cpu); - - raw_spin_lock_irq(&desc->lock); - chip->irq_set_affinity(data, cpumask_of(cpu), false); - raw_spin_unlock_irq(&desc->lock); -} - /* * The CPU has been marked offline. Migrate IRQs off this CPU. If * the affinity settings do not allow other CPUs, force them onto any @@ -253,8 +240,7 @@ void migrate_irqs(void) newcpu = cpumask_any_and(data->affinity, cpu_online_mask); } - - route_irq(data, irq, newcpu); + irq_set_affinity(irq, cpumask_of(newcpu)); } } }
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> Cc: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>, Paul Mundt <lethal@linux-sh.org>, sh <linux-sh@vger.kernel.org> Subject: [patch 05/26] sh: Use irq_set_affinity instead of homebrewn code Date: Sun, 23 Feb 2014 21:40:10 -0000 [thread overview] Message-ID: <20140223212736.774961401@linutronix.de> (raw) In-Reply-To: 20140223212703.511977310@linutronix.de [-- Attachment #1: sh-irq-use-the-proper-core-functions.patch --] [-- Type: text/plain, Size: 1377 bytes --] There is no point in having an incomplete copy of irq_set_affinity() for the hotplug irq migration code. Use the core function instead. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Paul Mundt <lethal@linux-sh.org> Cc: sh <linux-sh@vger.kernel.org> --- arch/sh/kernel/irq.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) Index: tip/arch/sh/kernel/irq.c =================================================================== --- tip.orig/arch/sh/kernel/irq.c +++ tip/arch/sh/kernel/irq.c @@ -217,19 +217,6 @@ void __init init_IRQ(void) } #ifdef CONFIG_HOTPLUG_CPU -static void route_irq(struct irq_data *data, unsigned int irq, unsigned int cpu) -{ - struct irq_desc *desc = irq_to_desc(irq); - struct irq_chip *chip = irq_data_get_irq_chip(data); - - printk(KERN_INFO "IRQ%u: moving from cpu%u to cpu%u\n", - irq, data->node, cpu); - - raw_spin_lock_irq(&desc->lock); - chip->irq_set_affinity(data, cpumask_of(cpu), false); - raw_spin_unlock_irq(&desc->lock); -} - /* * The CPU has been marked offline. Migrate IRQs off this CPU. If * the affinity settings do not allow other CPUs, force them onto any @@ -253,8 +240,7 @@ void migrate_irqs(void) newcpu = cpumask_any_and(data->affinity, cpu_online_mask); } - - route_irq(data, irq, newcpu); + irq_set_affinity(irq, cpumask_of(newcpu)); } } }
next prev parent reply other threads:[~2014-02-23 21:40 UTC|newest] Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-23 21:40 [patch 00/26] genirq: Another round of tree wide cleanups Thomas Gleixner 2014-02-23 21:40 ` [patch 01/26] powerpc: irq: Use generic_handle_irq Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:39 ` [tip:irq/core] powerpc: Irq: " tip-bot for Thomas Gleixner 2014-03-04 16:39 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 02/26] powerpc:evh_pic: Kill irq_desc abuse Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:39 ` [tip:irq/core] powerpc:eVh_pic: " tip-bot for Thomas Gleixner 2014-03-04 16:39 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 03/26] powerpc: eeh: Kill another abuse of irq_desc Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-23 22:26 ` Benjamin Herrenschmidt 2014-02-23 22:26 ` Benjamin Herrenschmidt 2014-02-24 7:56 ` Gavin Shan 2014-02-24 11:32 ` Thomas Gleixner 2014-02-24 11:32 ` Thomas Gleixner 2014-03-04 16:40 ` [tip:irq/core] powerpc: Eeh: " tip-bot for Thomas Gleixner 2014-03-04 16:40 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 04/26] xtensa: Use irq_set_affinity instead of homebrewn code Thomas Gleixner 2014-02-24 0:32 ` Max Filippov 2014-03-04 16:43 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner [this message] 2014-02-23 21:40 ` [patch 05/26] sh: " Thomas Gleixner 2014-03-04 16:43 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 16:43 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 06/26] metag: " Thomas Gleixner 2014-02-24 13:24 ` James Hogan 2014-02-24 13:24 ` James Hogan 2014-02-24 14:24 ` Thomas Gleixner 2014-02-24 14:24 ` Thomas Gleixner 2014-02-25 18:56 ` Thomas Gleixner 2014-02-25 18:56 ` Thomas Gleixner 2014-02-25 21:57 ` James Hogan 2014-02-27 10:59 ` Thomas Gleixner 2014-02-27 10:59 ` Thomas Gleixner 2014-02-23 21:40 ` [patch 07/26] pci: pcie-designware: Remove irq_desc abuse Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:40 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 08/26] arm: Replace various irq_desc accesses Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-24 2:55 ` Shawn Guo 2014-02-24 2:55 ` Shawn Guo 2014-02-24 2:55 ` Shawn Guo 2014-02-26 17:05 ` Tony Lindgren 2014-02-26 17:05 ` Tony Lindgren 2014-03-04 16:40 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-20 15:22 ` [patch 08/26] " Arnd Bergmann 2014-03-20 15:22 ` Arnd Bergmann 2014-03-20 15:22 ` Arnd Bergmann 2014-02-23 21:40 ` [patch 10/26] blackfin:Use generic /proc/interrupts implementation Thomas Gleixner 2014-02-26 10:00 ` Steven Miao 2014-02-23 21:40 ` [patch 09/26] arm: mmp: Remove pointless fiddling with irq internals Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-23 23:17 ` Uwe Kleine-König 2014-02-23 23:17 ` Uwe Kleine-König 2014-02-24 6:07 ` Chao Xie 2014-02-24 6:07 ` Chao Xie 2014-02-24 6:43 ` Haojian Zhuang 2014-02-24 6:43 ` Haojian Zhuang 2014-02-24 11:31 ` Thomas Gleixner 2014-02-24 11:31 ` Thomas Gleixner 2014-02-27 1:37 ` Chao Xie 2014-02-27 1:37 ` Chao Xie 2014-02-27 2:19 ` Haojian Zhuang 2014-02-27 2:19 ` Haojian Zhuang 2014-02-27 11:28 ` Thomas Gleixner 2014-02-27 11:28 ` Thomas Gleixner 2014-02-24 11:27 ` Thomas Gleixner 2014-02-24 11:27 ` Thomas Gleixner 2014-03-04 16:40 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 12/26] mips: Use the core irq stats function Thomas Gleixner 2014-03-04 16:41 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 11/26] genirq: Add a kstat helper to increment irq stats Thomas Gleixner 2014-03-04 16:41 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 13/26] sparc: Use the core irq stats function Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:41 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 18:57 ` [patch 13/26] " David Miller 2014-03-04 18:57 ` David Miller 2014-02-23 21:40 ` [patch 14/26] mn10300: " Thomas Gleixner 2014-03-04 16:42 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 15/26] x86: xen: " Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-24 14:20 ` David Vrabel 2014-02-24 14:20 ` [Xen-devel] " David Vrabel 2014-03-04 16:41 ` [tip:irq/core] x86: Xen: " tip-bot for Thomas Gleixner 2014-03-04 16:41 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 17/26] ia64: " Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:42 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 16:42 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 16/26] s390: cio: " Thomas Gleixner 2014-03-04 16:42 ` [tip:irq/core] s390: Cio: " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 18/26] xen: Use the proper irq functions Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-24 14:24 ` [Xen-devel] " David Vrabel 2014-02-24 21:13 ` Thomas Gleixner 2014-02-24 21:13 ` [Xen-devel] " Thomas Gleixner 2014-02-24 14:24 ` David Vrabel 2014-03-04 16:40 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 16:40 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 19/26] genirq: Provide irqd_irq_has_actions() Thomas Gleixner 2014-02-23 21:40 ` [patch 20/26] genirq: Provide irq_is_allocated() Thomas Gleixner 2014-02-23 21:40 ` [patch 21/26] xen: Get rid of the last irq_desc abuse Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-24 14:33 ` David Vrabel 2014-02-24 14:33 ` [Xen-devel] " David Vrabel 2014-02-24 21:12 ` Thomas Gleixner 2014-02-24 21:12 ` [Xen-devel] " Thomas Gleixner 2014-03-04 16:41 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 16:41 ` tip-bot for Thomas Gleixner 2014-03-04 17:16 ` David Vrabel 2014-03-04 17:16 ` [Xen-devel] " David Vrabel 2014-02-23 21:40 ` [patch 22/26] x86: Add proper vector accounting for HyperV Thomas Gleixner 2014-02-25 12:24 ` KY Srinivasan 2014-03-04 16:42 ` [tip:irq/core] x86: Add proper vector accounting for HYPERVISOR_CALLBACK_VECTOR tip-bot for Thomas Gleixner 2014-09-22 21:03 ` [patch 22/26] x86: Add proper vector accounting for HyperV Elliott, Robert (Server Storage) 2014-02-23 21:40 ` [patch 23/26] xen: Add proper irq accounting for HYPERCALL vector Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-24 14:48 ` David Vrabel 2014-02-24 14:48 ` [Xen-devel] " David Vrabel 2014-03-04 16:42 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 16:42 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 24/26] genirq: Provide handle_percpu_simple_irq() Thomas Gleixner 2014-02-25 12:25 ` KY Srinivasan 2014-02-23 21:40 ` [patch 25/26] x86: hyperv: Cleanup the irq mess Thomas Gleixner 2014-02-25 12:24 ` KY Srinivasan 2014-02-25 19:10 ` Thomas Gleixner 2014-02-28 2:50 ` KY Srinivasan 2014-03-04 16:42 ` [tip:irq/core] x86: Hyperv: " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 26/26] genirq: Move kstats_inc_irqs_this_cpu() to core Thomas Gleixner 2014-03-04 16:43 ` [tip:irq/core] genirq: Move kstat_incr_irqs_this_cpu() " tip-bot for Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140223212736.774961401@linutronix.de \ --to=tglx@linutronix.de \ --cc=lethal@linux-sh.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=peterz@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.