From: tip-bot for Thomas Gleixner <tipbot@zytor.com> To: linux-tip-commits@vger.kernel.org Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, linuxppc-dev@lists.ozlabs.org, peterz@infradead.org, benh@kernel.crashing.org, tglx@linutronix.de, shangw@linux.vnet.ibm.com Subject: [tip:irq/core] powerpc: Eeh: Kill another abuse of irq_desc Date: Tue, 4 Mar 2014 08:40:05 -0800 [thread overview] Message-ID: <tip-b8a9a11b976810ba12a43c4fe699a14892c97e52@git.kernel.org> (raw) In-Reply-To: <20140223212736.562906212@linutronix.de> Commit-ID: b8a9a11b976810ba12a43c4fe699a14892c97e52 Gitweb: http://git.kernel.org/tip/b8a9a11b976810ba12a43c4fe699a14892c97e52 Author: Thomas Gleixner <tglx@linutronix.de> AuthorDate: Sun, 23 Feb 2014 21:40:09 +0000 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Tue, 4 Mar 2014 17:37:52 +0100 powerpc: Eeh: Kill another abuse of irq_desc commit 91150af3a (powerpc/eeh: Fix unbalanced enable for IRQ) is another brilliant example of trainwreck engineering. The patch "fixes" the issue of an unbalanced call to irq_enable() which causes a prominent warning by checking the disabled state of the interrupt line and call conditionally into the core code. This is wrong in two aspects: 1) The warning is there to tell users, that they need to fix their asymetric enable/disable patterns by finding the root cause and solving it there. It's definitely not meant to work around it by conditionally calling into the core code depending on the random state of the irq line. Asymetric irq_disable/enable calls are a clear sign of wrong usage of the interfaces which have to be cured at the root and not by somehow hacking around it. 2) The abuse of core internal data structure instead of using the proper interfaces for retrieving the information for the 'hack around' irq_desc is core internal and it's clear enough stated. Replace at least the irq_desc abuse with the proper functions and add a big fat comment why this is absurd and completely wrong. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Gavin Shan <shangw@linux.vnet.ibm.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: ppc <linuxppc-dev@lists.ozlabs.org> Link: http://lkml.kernel.org/r/20140223212736.562906212@linutronix.de Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- arch/powerpc/kernel/eeh_driver.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c index fdc679d..3e1d7de 100644 --- a/arch/powerpc/kernel/eeh_driver.c +++ b/arch/powerpc/kernel/eeh_driver.c @@ -143,15 +143,31 @@ static void eeh_disable_irq(struct pci_dev *dev) static void eeh_enable_irq(struct pci_dev *dev) { struct eeh_dev *edev = pci_dev_to_eeh_dev(dev); - struct irq_desc *desc; if ((edev->mode) & EEH_DEV_IRQ_DISABLED) { edev->mode &= ~EEH_DEV_IRQ_DISABLED; - - desc = irq_to_desc(dev->irq); - if (desc && desc->depth > 0) + /* + * FIXME !!!!! + * + * This is just ass backwards. This maze has + * unbalanced irq_enable/disable calls. So instead of + * finding the root cause it works around the warning + * in the irq_enable code by conditionally calling + * into it. + * + * That's just wrong.The warning in the core code is + * there to tell people to fix their assymetries in + * their own code, not by abusing the core information + * to avoid it. + * + * I so wish that the assymetry would be the other way + * round and a few more irq_disable calls render that + * shit unusable forever. + * + * tglx + */ + if (irqd_irq_disabled(irq_get_irq_data(dev->irq)) enable_irq(dev->irq); - } } /**
WARNING: multiple messages have this Message-ID (diff)
From: tip-bot for Thomas Gleixner <tipbot@zytor.com> To: linux-tip-commits@vger.kernel.org Cc: shangw@linux.vnet.ibm.com, peterz@infradead.org, linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org Subject: [tip:irq/core] powerpc: Eeh: Kill another abuse of irq_desc Date: Tue, 4 Mar 2014 08:40:05 -0800 [thread overview] Message-ID: <tip-b8a9a11b976810ba12a43c4fe699a14892c97e52@git.kernel.org> (raw) In-Reply-To: <20140223212736.562906212@linutronix.de> Commit-ID: b8a9a11b976810ba12a43c4fe699a14892c97e52 Gitweb: http://git.kernel.org/tip/b8a9a11b976810ba12a43c4fe699a14892c97e52 Author: Thomas Gleixner <tglx@linutronix.de> AuthorDate: Sun, 23 Feb 2014 21:40:09 +0000 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Tue, 4 Mar 2014 17:37:52 +0100 powerpc: Eeh: Kill another abuse of irq_desc commit 91150af3a (powerpc/eeh: Fix unbalanced enable for IRQ) is another brilliant example of trainwreck engineering. The patch "fixes" the issue of an unbalanced call to irq_enable() which causes a prominent warning by checking the disabled state of the interrupt line and call conditionally into the core code. This is wrong in two aspects: 1) The warning is there to tell users, that they need to fix their asymetric enable/disable patterns by finding the root cause and solving it there. It's definitely not meant to work around it by conditionally calling into the core code depending on the random state of the irq line. Asymetric irq_disable/enable calls are a clear sign of wrong usage of the interfaces which have to be cured at the root and not by somehow hacking around it. 2) The abuse of core internal data structure instead of using the proper interfaces for retrieving the information for the 'hack around' irq_desc is core internal and it's clear enough stated. Replace at least the irq_desc abuse with the proper functions and add a big fat comment why this is absurd and completely wrong. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Gavin Shan <shangw@linux.vnet.ibm.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: ppc <linuxppc-dev@lists.ozlabs.org> Link: http://lkml.kernel.org/r/20140223212736.562906212@linutronix.de Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- arch/powerpc/kernel/eeh_driver.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c index fdc679d..3e1d7de 100644 --- a/arch/powerpc/kernel/eeh_driver.c +++ b/arch/powerpc/kernel/eeh_driver.c @@ -143,15 +143,31 @@ static void eeh_disable_irq(struct pci_dev *dev) static void eeh_enable_irq(struct pci_dev *dev) { struct eeh_dev *edev = pci_dev_to_eeh_dev(dev); - struct irq_desc *desc; if ((edev->mode) & EEH_DEV_IRQ_DISABLED) { edev->mode &= ~EEH_DEV_IRQ_DISABLED; - - desc = irq_to_desc(dev->irq); - if (desc && desc->depth > 0) + /* + * FIXME !!!!! + * + * This is just ass backwards. This maze has + * unbalanced irq_enable/disable calls. So instead of + * finding the root cause it works around the warning + * in the irq_enable code by conditionally calling + * into it. + * + * That's just wrong.The warning in the core code is + * there to tell people to fix their assymetries in + * their own code, not by abusing the core information + * to avoid it. + * + * I so wish that the assymetry would be the other way + * round and a few more irq_disable calls render that + * shit unusable forever. + * + * tglx + */ + if (irqd_irq_disabled(irq_get_irq_data(dev->irq)) enable_irq(dev->irq); - } } /**
next prev parent reply other threads:[~2014-03-04 16:48 UTC|newest] Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-23 21:40 [patch 00/26] genirq: Another round of tree wide cleanups Thomas Gleixner 2014-02-23 21:40 ` [patch 01/26] powerpc: irq: Use generic_handle_irq Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:39 ` [tip:irq/core] powerpc: Irq: " tip-bot for Thomas Gleixner 2014-03-04 16:39 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 02/26] powerpc:evh_pic: Kill irq_desc abuse Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:39 ` [tip:irq/core] powerpc:eVh_pic: " tip-bot for Thomas Gleixner 2014-03-04 16:39 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 03/26] powerpc: eeh: Kill another abuse of irq_desc Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-23 22:26 ` Benjamin Herrenschmidt 2014-02-23 22:26 ` Benjamin Herrenschmidt 2014-02-24 7:56 ` Gavin Shan 2014-02-24 11:32 ` Thomas Gleixner 2014-02-24 11:32 ` Thomas Gleixner 2014-03-04 16:40 ` tip-bot for Thomas Gleixner [this message] 2014-03-04 16:40 ` [tip:irq/core] powerpc: Eeh: " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 04/26] xtensa: Use irq_set_affinity instead of homebrewn code Thomas Gleixner 2014-02-24 0:32 ` Max Filippov 2014-03-04 16:43 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 05/26] sh: " Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:43 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 16:43 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 06/26] metag: " Thomas Gleixner 2014-02-24 13:24 ` James Hogan 2014-02-24 13:24 ` James Hogan 2014-02-24 14:24 ` Thomas Gleixner 2014-02-24 14:24 ` Thomas Gleixner 2014-02-25 18:56 ` Thomas Gleixner 2014-02-25 18:56 ` Thomas Gleixner 2014-02-25 21:57 ` James Hogan 2014-02-27 10:59 ` Thomas Gleixner 2014-02-27 10:59 ` Thomas Gleixner 2014-02-23 21:40 ` [patch 07/26] pci: pcie-designware: Remove irq_desc abuse Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:40 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 08/26] arm: Replace various irq_desc accesses Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-24 2:55 ` Shawn Guo 2014-02-24 2:55 ` Shawn Guo 2014-02-24 2:55 ` Shawn Guo 2014-02-26 17:05 ` Tony Lindgren 2014-02-26 17:05 ` Tony Lindgren 2014-03-04 16:40 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-20 15:22 ` [patch 08/26] " Arnd Bergmann 2014-03-20 15:22 ` Arnd Bergmann 2014-03-20 15:22 ` Arnd Bergmann 2014-02-23 21:40 ` [patch 10/26] blackfin:Use generic /proc/interrupts implementation Thomas Gleixner 2014-02-26 10:00 ` Steven Miao 2014-02-23 21:40 ` [patch 09/26] arm: mmp: Remove pointless fiddling with irq internals Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-23 23:17 ` Uwe Kleine-König 2014-02-23 23:17 ` Uwe Kleine-König 2014-02-24 6:07 ` Chao Xie 2014-02-24 6:07 ` Chao Xie 2014-02-24 6:43 ` Haojian Zhuang 2014-02-24 6:43 ` Haojian Zhuang 2014-02-24 11:31 ` Thomas Gleixner 2014-02-24 11:31 ` Thomas Gleixner 2014-02-27 1:37 ` Chao Xie 2014-02-27 1:37 ` Chao Xie 2014-02-27 2:19 ` Haojian Zhuang 2014-02-27 2:19 ` Haojian Zhuang 2014-02-27 11:28 ` Thomas Gleixner 2014-02-27 11:28 ` Thomas Gleixner 2014-02-24 11:27 ` Thomas Gleixner 2014-02-24 11:27 ` Thomas Gleixner 2014-03-04 16:40 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 12/26] mips: Use the core irq stats function Thomas Gleixner 2014-03-04 16:41 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 11/26] genirq: Add a kstat helper to increment irq stats Thomas Gleixner 2014-03-04 16:41 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 13/26] sparc: Use the core irq stats function Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:41 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 18:57 ` [patch 13/26] " David Miller 2014-03-04 18:57 ` David Miller 2014-02-23 21:40 ` [patch 14/26] mn10300: " Thomas Gleixner 2014-03-04 16:42 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 15/26] x86: xen: " Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-24 14:20 ` David Vrabel 2014-02-24 14:20 ` [Xen-devel] " David Vrabel 2014-03-04 16:41 ` [tip:irq/core] x86: Xen: " tip-bot for Thomas Gleixner 2014-03-04 16:41 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 17/26] ia64: " Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-03-04 16:42 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 16:42 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 16/26] s390: cio: " Thomas Gleixner 2014-03-04 16:42 ` [tip:irq/core] s390: Cio: " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 18/26] xen: Use the proper irq functions Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-24 14:24 ` [Xen-devel] " David Vrabel 2014-02-24 21:13 ` Thomas Gleixner 2014-02-24 21:13 ` [Xen-devel] " Thomas Gleixner 2014-02-24 14:24 ` David Vrabel 2014-03-04 16:40 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 16:40 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 19/26] genirq: Provide irqd_irq_has_actions() Thomas Gleixner 2014-02-23 21:40 ` [patch 20/26] genirq: Provide irq_is_allocated() Thomas Gleixner 2014-02-23 21:40 ` [patch 21/26] xen: Get rid of the last irq_desc abuse Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-24 14:33 ` David Vrabel 2014-02-24 14:33 ` [Xen-devel] " David Vrabel 2014-02-24 21:12 ` Thomas Gleixner 2014-02-24 21:12 ` [Xen-devel] " Thomas Gleixner 2014-03-04 16:41 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 16:41 ` tip-bot for Thomas Gleixner 2014-03-04 17:16 ` David Vrabel 2014-03-04 17:16 ` [Xen-devel] " David Vrabel 2014-02-23 21:40 ` [patch 22/26] x86: Add proper vector accounting for HyperV Thomas Gleixner 2014-02-25 12:24 ` KY Srinivasan 2014-03-04 16:42 ` [tip:irq/core] x86: Add proper vector accounting for HYPERVISOR_CALLBACK_VECTOR tip-bot for Thomas Gleixner 2014-09-22 21:03 ` [patch 22/26] x86: Add proper vector accounting for HyperV Elliott, Robert (Server Storage) 2014-02-23 21:40 ` [patch 23/26] xen: Add proper irq accounting for HYPERCALL vector Thomas Gleixner 2014-02-23 21:40 ` Thomas Gleixner 2014-02-24 14:48 ` David Vrabel 2014-02-24 14:48 ` [Xen-devel] " David Vrabel 2014-03-04 16:42 ` [tip:irq/core] " tip-bot for Thomas Gleixner 2014-03-04 16:42 ` tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 24/26] genirq: Provide handle_percpu_simple_irq() Thomas Gleixner 2014-02-25 12:25 ` KY Srinivasan 2014-02-23 21:40 ` [patch 25/26] x86: hyperv: Cleanup the irq mess Thomas Gleixner 2014-02-25 12:24 ` KY Srinivasan 2014-02-25 19:10 ` Thomas Gleixner 2014-02-28 2:50 ` KY Srinivasan 2014-03-04 16:42 ` [tip:irq/core] x86: Hyperv: " tip-bot for Thomas Gleixner 2014-02-23 21:40 ` [patch 26/26] genirq: Move kstats_inc_irqs_this_cpu() to core Thomas Gleixner 2014-03-04 16:43 ` [tip:irq/core] genirq: Move kstat_incr_irqs_this_cpu() " tip-bot for Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tip-b8a9a11b976810ba12a43c4fe699a14892c97e52@git.kernel.org \ --to=tipbot@zytor.com \ --cc=benh@kernel.crashing.org \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tip-commits@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=shangw@linux.vnet.ibm.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.