All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org
Subject: Re: [PATCH v4 5/9] Input: pmic8xxx-pwrkey - Migrate to DT
Date: Fri, 28 Feb 2014 10:32:37 -0800	[thread overview]
Message-ID: <20140228183237.GE2487@codeaurora.org> (raw)
In-Reply-To: <20140228034547.GE7308@joshc.qualcomm.com>

On 02/27, Josh Cartwright wrote:
> On Thu, Feb 27, 2014 at 05:55:16PM -0800, Stephen Boyd wrote:
> > The driver is only supported on DT enabled platforms. Convert the
> > driver to DT so that it can probe properly.
> > 
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> > --- a/drivers/input/misc/pmic8xxx-pwrkey.c
> > +++ b/drivers/input/misc/pmic8xxx-pwrkey.c
> > @@ -172,7 +178,7 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev)
> >  	}
> >  
> >  	platform_set_drvdata(pdev, pwrkey);
> > -	device_init_wakeup(&pdev->dev, pdata->wakeup);
> > +	device_init_wakeup(&pdev->dev, 1);
> 
> Is there a particular reason you aren't providing a 'linux,wakeup'
> property for pwrkey?
> 

In all the users of this device I've never seen wakeup set to 0.
Given that this is a power key it makes sense because this is
used to wake up a phone from suspend (also see the comment above
device_init_wakeup() where power buttons are explicitly called
out).

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/9] Input: pmic8xxx-pwrkey - Migrate to DT
Date: Fri, 28 Feb 2014 10:32:37 -0800	[thread overview]
Message-ID: <20140228183237.GE2487@codeaurora.org> (raw)
In-Reply-To: <20140228034547.GE7308@joshc.qualcomm.com>

On 02/27, Josh Cartwright wrote:
> On Thu, Feb 27, 2014 at 05:55:16PM -0800, Stephen Boyd wrote:
> > The driver is only supported on DT enabled platforms. Convert the
> > driver to DT so that it can probe properly.
> > 
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> > --- a/drivers/input/misc/pmic8xxx-pwrkey.c
> > +++ b/drivers/input/misc/pmic8xxx-pwrkey.c
> > @@ -172,7 +178,7 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev)
> >  	}
> >  
> >  	platform_set_drvdata(pdev, pwrkey);
> > -	device_init_wakeup(&pdev->dev, pdata->wakeup);
> > +	device_init_wakeup(&pdev->dev, 1);
> 
> Is there a particular reason you aren't providing a 'linux,wakeup'
> property for pwrkey?
> 

In all the users of this device I've never seen wakeup set to 0.
Given that this is a power key it makes sense because this is
used to wake up a phone from suspend (also see the comment above
device_init_wakeup() where power buttons are explicitly called
out).

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2014-02-28 18:32 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28  1:55 [PATCH v4 0/9] Use regmap+devm+DT in pm8xxx input drivers Stephen Boyd
2014-02-28  1:55 ` Stephen Boyd
2014-02-28  1:55 ` Stephen Boyd
2014-02-28  1:55 ` [PATCH v4 1/9] Input: pmic8xxx-keypad - Fix build by removing gpio configuration Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  1:55 ` [PATCH v4 2/9] Input: pmic8xxx-keypad - Migrate to devm_* APIs Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  1:55 ` [PATCH v4 3/9] Input: pmic8xxx-keypad - Migrate to regmap APIs Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  1:55 ` [PATCH v4 4/9] Input: pmic8xxx-keypad - Migrate to DT Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  3:41   ` Josh Cartwright
2014-02-28  3:41     ` Josh Cartwright
2014-02-28 18:29     ` Stephen Boyd
2014-02-28 18:29       ` Stephen Boyd
2014-02-28  1:55 ` [PATCH v4 5/9] Input: pmic8xxx-pwrkey " Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  3:45   ` Josh Cartwright
2014-02-28  3:45     ` Josh Cartwright
2014-02-28 18:32     ` Stephen Boyd [this message]
2014-02-28 18:32       ` Stephen Boyd
2014-02-28  1:55 ` [PATCH v4 6/9] Input: pm8xxx-vibrator - Add DT match table Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  1:55 ` [PATCH v4 7/9] devicetree: bindings: Document PM8921/8058 keypads Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28 13:55   ` Josh Cartwright
2014-02-28 13:55     ` Josh Cartwright
2014-02-28 18:37     ` Stephen Boyd
2014-02-28 18:37       ` Stephen Boyd
2014-02-28 19:11       ` Josh Cartwright
2014-02-28 19:11         ` Josh Cartwright
2014-02-28  1:55 ` [PATCH v4 8/9] devicetree: bindings: Document PM8921/8058 power keys Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  1:55 ` [PATCH v4 9/9] devicetree: bindings: Document PM8921/8058 vibrators Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd
2014-02-28  1:55   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140228183237.GE2487@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=joshc@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.