From: Josh Cartwright <joshc@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Josh Cartwright <joshc@codeaurora.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 7/9] devicetree: bindings: Document PM8921/8058 keypads
Date: Fri, 28 Feb 2014 13:11:29 -0600 [thread overview]
Message-ID: <20140228191129.GH7308@joshc.qualcomm.com> (raw)
In-Reply-To: <20140228183708.GF2487@codeaurora.org>
On Fri, Feb 28, 2014 at 10:37:08AM -0800, Stephen Boyd wrote:
> On 02/28, Josh Cartwright wrote:
> > On Thu, Feb 27, 2014 at 05:55:18PM -0800, Stephen Boyd wrote:
> > > +
> > > +EXAMPLE
> > > +
> > > + keypad {
> > > + compatible = "qcom,pm8921-keypad";
> > > + interrupt-parent = <&pmicintc>;
> > > + interrupts = <74 1>, <75 1>;
> > > + linux,keymap = <
> > > + MATRIX_KEY(0, 0, KEY_VOLUMEUP)
> > > + MATRIX_KEY(0, 1, KEY_VOLUMEDOWN)
> > > + MATRIX_KEY(0, 2, KEY_CAMERA_FOCUS)
> > > + MATRIX_KEY(0, 3, KEY_CAMERA)
> > > + >;
> > > + keypad,num-rows = <1>;
> > > + keypad,num-columns = <5>;
> > > + debounce = <15>;
> > > + scan-delay = <32>;
> > > + row-hold = <91500>;
> > > + };
> >
> > It odd to me that these newly created bindings don't have 'reg'
> > properties, even though the device clearly has a register region.
> >
> > I suppose it makes sense from a "port over from platform data to DT"
> > perspective, as these drivers have just assumed the location of their
> > registers to be fixed; however I suspect things will need to be changed
> > if/when we hope to share these drivers with pm8841/pm8941 and beyond...
> >
>
> Agreed. I would love it if the platform OF code would create
> IORESOURCE_REG resources for any reg properties that aren't
> translatable to CPU addresses. That way we don't have to pick out the
> reg property from DT with special OF code (like you've done in
> rtc-pm8xxx).
Yes, I agree this would be nice. The rtc-pm8xxx register parsing magic
is misplaced/ugly. I'll see about taking a crack at this and seeing
what it looks like.
> I'll throw the reg property into the binding so that in
> the future we can support the register moving around (although at the
> moment the driver will ignore it).
Great, I think this sounds good.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: joshc@codeaurora.org (Josh Cartwright)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/9] devicetree: bindings: Document PM8921/8058 keypads
Date: Fri, 28 Feb 2014 13:11:29 -0600 [thread overview]
Message-ID: <20140228191129.GH7308@joshc.qualcomm.com> (raw)
In-Reply-To: <20140228183708.GF2487@codeaurora.org>
On Fri, Feb 28, 2014 at 10:37:08AM -0800, Stephen Boyd wrote:
> On 02/28, Josh Cartwright wrote:
> > On Thu, Feb 27, 2014 at 05:55:18PM -0800, Stephen Boyd wrote:
> > > +
> > > +EXAMPLE
> > > +
> > > + keypad {
> > > + compatible = "qcom,pm8921-keypad";
> > > + interrupt-parent = <&pmicintc>;
> > > + interrupts = <74 1>, <75 1>;
> > > + linux,keymap = <
> > > + MATRIX_KEY(0, 0, KEY_VOLUMEUP)
> > > + MATRIX_KEY(0, 1, KEY_VOLUMEDOWN)
> > > + MATRIX_KEY(0, 2, KEY_CAMERA_FOCUS)
> > > + MATRIX_KEY(0, 3, KEY_CAMERA)
> > > + >;
> > > + keypad,num-rows = <1>;
> > > + keypad,num-columns = <5>;
> > > + debounce = <15>;
> > > + scan-delay = <32>;
> > > + row-hold = <91500>;
> > > + };
> >
> > It odd to me that these newly created bindings don't have 'reg'
> > properties, even though the device clearly has a register region.
> >
> > I suppose it makes sense from a "port over from platform data to DT"
> > perspective, as these drivers have just assumed the location of their
> > registers to be fixed; however I suspect things will need to be changed
> > if/when we hope to share these drivers with pm8841/pm8941 and beyond...
> >
>
> Agreed. I would love it if the platform OF code would create
> IORESOURCE_REG resources for any reg properties that aren't
> translatable to CPU addresses. That way we don't have to pick out the
> reg property from DT with special OF code (like you've done in
> rtc-pm8xxx).
Yes, I agree this would be nice. The rtc-pm8xxx register parsing magic
is misplaced/ugly. I'll see about taking a crack at this and seeing
what it looks like.
> I'll throw the reg property into the binding so that in
> the future we can support the register moving around (although at the
> moment the driver will ignore it).
Great, I think this sounds good.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-28 19:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 1:55 [PATCH v4 0/9] Use regmap+devm+DT in pm8xxx input drivers Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 1/9] Input: pmic8xxx-keypad - Fix build by removing gpio configuration Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 2/9] Input: pmic8xxx-keypad - Migrate to devm_* APIs Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 3/9] Input: pmic8xxx-keypad - Migrate to regmap APIs Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 4/9] Input: pmic8xxx-keypad - Migrate to DT Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 3:41 ` Josh Cartwright
2014-02-28 3:41 ` Josh Cartwright
2014-02-28 18:29 ` Stephen Boyd
2014-02-28 18:29 ` Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 5/9] Input: pmic8xxx-pwrkey " Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 3:45 ` Josh Cartwright
2014-02-28 3:45 ` Josh Cartwright
2014-02-28 18:32 ` Stephen Boyd
2014-02-28 18:32 ` Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 6/9] Input: pm8xxx-vibrator - Add DT match table Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 7/9] devicetree: bindings: Document PM8921/8058 keypads Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 13:55 ` Josh Cartwright
2014-02-28 13:55 ` Josh Cartwright
2014-02-28 18:37 ` Stephen Boyd
2014-02-28 18:37 ` Stephen Boyd
2014-02-28 19:11 ` Josh Cartwright [this message]
2014-02-28 19:11 ` Josh Cartwright
2014-02-28 1:55 ` [PATCH v4 8/9] devicetree: bindings: Document PM8921/8058 power keys Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 9/9] devicetree: bindings: Document PM8921/8058 vibrators Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
2014-02-28 1:55 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228191129.GH7308@joshc.qualcomm.com \
--to=joshc@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.