* [PATCH 2/6] watchdog: pc87413: split module author names
2014-02-27 5:41 [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Jingoo Han
@ 2014-02-27 5:43 ` Jingoo Han
2014-02-28 3:21 ` Guenter Roeck
2014-02-27 5:44 ` [PATCH 3/6] watchdog: w83697hf: " Jingoo Han
` (5 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Jingoo Han @ 2014-02-27 5:43 UTC (permalink / raw)
To: 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Guenter Roeck', 'Jingoo Han',
'Jonathan McDowell'
Split module author names and remove unnecessary braces, in order
to fix the following checkpatch issues.
WARNING: quoted string split across lines
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/pc87413_wdt.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c
index 5211d56..9f15dd9 100644
--- a/drivers/watchdog/pc87413_wdt.c
+++ b/drivers/watchdog/pc87413_wdt.c
@@ -512,9 +512,8 @@ static int __init pc87413_init(void)
return -EBUSY;
ret = register_reboot_notifier(&pc87413_notifier);
- if (ret != 0) {
+ if (ret != 0)
pr_err("cannot register reboot notifier (err=%d)\n", ret);
- }
ret = misc_register(&pc87413_miscdev);
if (ret != 0) {
@@ -575,8 +574,8 @@ static void __exit pc87413_exit(void)
module_init(pc87413_init);
module_exit(pc87413_exit);
-MODULE_AUTHOR("Sven Anders <anders@anduras.de>, "
- "Marcus Junker <junker@anduras.de>,");
+MODULE_AUTHOR("Sven Anders <anders@anduras.de>");
+MODULE_AUTHOR("Marcus Junker <junker@anduras.de>");
MODULE_DESCRIPTION("PC87413 WDT driver");
MODULE_LICENSE("GPL");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 2/6] watchdog: pc87413: split module author names
2014-02-27 5:43 ` [PATCH 2/6] watchdog: pc87413: " Jingoo Han
@ 2014-02-28 3:21 ` Guenter Roeck
0 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2014-02-28 3:21 UTC (permalink / raw)
To: Jingoo Han, 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Jonathan McDowell'
On 02/26/2014 09:43 PM, Jingoo Han wrote:
> Split module author names and remove unnecessary braces, in order
> to fix the following checkpatch issues.
>
> WARNING: quoted string split across lines
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/6] watchdog: w83697hf: split module author names
2014-02-27 5:41 [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Jingoo Han
2014-02-27 5:43 ` [PATCH 2/6] watchdog: pc87413: " Jingoo Han
@ 2014-02-27 5:44 ` Jingoo Han
2014-02-28 3:21 ` Guenter Roeck
2014-02-27 5:46 ` [PATCH 4/6] watchdog: ibmasr: fix incorrect placement of __initdata marker Jingoo Han
` (4 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Jingoo Han @ 2014-02-27 5:44 UTC (permalink / raw)
To: 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Guenter Roeck', 'Jingoo Han',
'Stanislav Kholmanskikh'
Split module author names and remove unnecessary braces, in order
to fix the following checkpatch issue.
WARNING: quoted string split across lines
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/w83697hf_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/w83697hf_wdt.c b/drivers/watchdog/w83697hf_wdt.c
index 68b45fc..e9ea856 100644
--- a/drivers/watchdog/w83697hf_wdt.c
+++ b/drivers/watchdog/w83697hf_wdt.c
@@ -455,6 +455,6 @@ module_init(wdt_init);
module_exit(wdt_exit);
MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Marcus Junker <junker@anduras.de>, "
- "Samuel Tardieu <sam@rfc1149.net>");
+MODULE_AUTHOR("Marcus Junker <junker@anduras.de>");
+MODULE_AUTHOR("Samuel Tardieu <sam@rfc1149.net>");
MODULE_DESCRIPTION("w83697hf/hg WDT driver");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 3/6] watchdog: w83697hf: split module author names
2014-02-27 5:44 ` [PATCH 3/6] watchdog: w83697hf: " Jingoo Han
@ 2014-02-28 3:21 ` Guenter Roeck
0 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2014-02-28 3:21 UTC (permalink / raw)
To: Jingoo Han, 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Stanislav Kholmanskikh'
On 02/26/2014 09:44 PM, Jingoo Han wrote:
> Split module author names and remove unnecessary braces, in order
> to fix the following checkpatch issue.
>
> WARNING: quoted string split across lines
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 4/6] watchdog: ibmasr: fix incorrect placement of __initdata marker
2014-02-27 5:41 [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Jingoo Han
2014-02-27 5:43 ` [PATCH 2/6] watchdog: pc87413: " Jingoo Han
2014-02-27 5:44 ` [PATCH 3/6] watchdog: w83697hf: " Jingoo Han
@ 2014-02-27 5:46 ` Jingoo Han
2014-02-28 3:21 ` Guenter Roeck
2014-02-27 5:48 ` [PATCH 5/6] watchdog: iTCO_wdt: remove unnecessary spaces Jingoo Han
` (3 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Jingoo Han @ 2014-02-27 5:46 UTC (permalink / raw)
To: 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Guenter Roeck', 'Jingoo Han',
'Akinobu Mita'
The __initdata marker can be virtually anywhere on the line,
EXCEPT right after "struct". The preferred location is before
the "=" sign if there is one, or before the trailing ";"
otherwise. It also fixes the following chechpatch warning.
WARNING: __initdata should be placed after ibmasr_id_table[]
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/ibmasr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/ibmasr.c b/drivers/watchdog/ibmasr.c
index db0a344..366b047 100644
--- a/drivers/watchdog/ibmasr.c
+++ b/drivers/watchdog/ibmasr.c
@@ -360,7 +360,7 @@ struct ibmasr_id {
int type;
};
-static struct ibmasr_id __initdata ibmasr_id_table[] = {
+static struct ibmasr_id ibmasr_id_table[] __initdata = {
{ "IBM Automatic Server Restart - eserver xSeries 220", ASMTYPE_TOPAZ },
{ "IBM Automatic Server Restart - Machine Type 8673", ASMTYPE_PEARL },
{ "IBM Automatic Server Restart - Machine Type 8480", ASMTYPE_JASPER },
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 5/6] watchdog: iTCO_wdt: remove unnecessary spaces
2014-02-27 5:41 [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Jingoo Han
` (2 preceding siblings ...)
2014-02-27 5:46 ` [PATCH 4/6] watchdog: ibmasr: fix incorrect placement of __initdata marker Jingoo Han
@ 2014-02-27 5:48 ` Jingoo Han
2014-02-28 3:21 ` Guenter Roeck
2014-02-27 5:48 ` [PATCH 6/6] watchdog: softdog: remove unnecessary initialization of static variable Jingoo Han
` (2 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Jingoo Han @ 2014-02-27 5:48 UTC (permalink / raw)
To: 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Guenter Roeck', 'Jingoo Han',
'Jan Beulich', 'Aaron Sierra'
Remove unnecessary space in order to fix the following
checkpatch issues.
WARNING: please, no space before tabs
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/iTCO_wdt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
index 04f8af6..6532e7a 100644
--- a/drivers/watchdog/iTCO_wdt.c
+++ b/drivers/watchdog/iTCO_wdt.c
@@ -347,15 +347,15 @@ static const struct watchdog_info ident = {
static const struct watchdog_ops iTCO_wdt_ops = {
.owner = THIS_MODULE,
.start = iTCO_wdt_start,
- .stop = iTCO_wdt_stop,
- .ping = iTCO_wdt_ping,
+ .stop = iTCO_wdt_stop,
+ .ping = iTCO_wdt_ping,
.set_timeout = iTCO_wdt_set_timeout,
.get_timeleft = iTCO_wdt_get_timeleft,
};
static struct watchdog_device iTCO_wdt_watchdog_dev = {
.info = &ident,
- .ops = &iTCO_wdt_ops,
+ .ops = &iTCO_wdt_ops,
};
/*
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 6/6] watchdog: softdog: remove unnecessary initialization of static variable
2014-02-27 5:41 [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Jingoo Han
` (3 preceding siblings ...)
2014-02-27 5:48 ` [PATCH 5/6] watchdog: iTCO_wdt: remove unnecessary spaces Jingoo Han
@ 2014-02-27 5:48 ` Jingoo Han
2014-02-28 3:22 ` Guenter Roeck
2014-02-28 3:20 ` [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Guenter Roeck
2014-03-02 14:03 ` Wim Van Sebroeck
6 siblings, 1 reply; 13+ messages in thread
From: Jingoo Han @ 2014-02-27 5:48 UTC (permalink / raw)
To: 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Guenter Roeck', 'Jingoo Han',
'Kim Milo'
Remove unnecessary initialization of static variable in order to
fix the following checkpatch issue.
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/softdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/softdog.c b/drivers/watchdog/softdog.c
index c04a1aa..0dc5e323d 100644
--- a/drivers/watchdog/softdog.c
+++ b/drivers/watchdog/softdog.c
@@ -62,7 +62,7 @@ MODULE_PARM_DESC(nowayout,
"Watchdog cannot be stopped once started (default="
__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
-static int soft_noboot = 0;
+static int soft_noboot;
module_param(soft_noboot, int, 0);
MODULE_PARM_DESC(soft_noboot,
"Softdog action, set to 1 to ignore reboots, 0 to reboot (default=0)");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 1/6] watchdog: ep93xx_wdt: split module author names
2014-02-27 5:41 [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Jingoo Han
` (4 preceding siblings ...)
2014-02-27 5:48 ` [PATCH 6/6] watchdog: softdog: remove unnecessary initialization of static variable Jingoo Han
@ 2014-02-28 3:20 ` Guenter Roeck
2014-03-02 14:03 ` Wim Van Sebroeck
6 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2014-02-28 3:20 UTC (permalink / raw)
To: Jingoo Han, 'Wim Van Sebroeck'
Cc: linux-watchdog, 'H Hartley Sweeten', 'Mika Westerberg'
On 02/26/2014 09:41 PM, Jingoo Han wrote:
> Split module author names in order to fix the following
> checkpatch warning.
>
> WARNING: quoted string split across lines
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/6] watchdog: ep93xx_wdt: split module author names
2014-02-27 5:41 [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Jingoo Han
` (5 preceding siblings ...)
2014-02-28 3:20 ` [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Guenter Roeck
@ 2014-03-02 14:03 ` Wim Van Sebroeck
6 siblings, 0 replies; 13+ messages in thread
From: Wim Van Sebroeck @ 2014-03-02 14:03 UTC (permalink / raw)
To: Jingoo Han
Cc: linux-watchdog, 'Guenter Roeck',
'H Hartley Sweeten', 'Mika Westerberg'
Hi Jingoo,
> Split module author names in order to fix the following
> checkpatch warning.
>
> WARNING: quoted string split across lines
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
This series of 6 patches has been added to linux-watchdog-next as a single patch.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 13+ messages in thread